[Pharo-project] Bug in FileSystem

Mariano Martinez Peck marianopeck at gmail.com
Sun Jan 8 08:37:05 EST 2012


On Sat, Jan 7, 2012 at 2:05 PM, Henrik Sperre Johansen <
henrik.s.johansen at veloxit.no> wrote:

> On 07.01.2012 13:20, Stéphane Ducasse wrote:
>
>> sounds like :)
>>
>> Stef
>>
>> On Jan 7, 2012, at 1:10 PM, Mariano Martinez Peck wrote:
>>
>>  FSReadStream>>  next: count
>>>     | result |
>>>     result := ByteArray new: count.
>>>     handle at: position read: result startingAt: 1 count: count.
>>>     position := position + 1.
>>>      ^ result
>>>
>>>
>>> shouldn't be
>>>
>>> FSReadStream>>  next: count
>>>     | result |
>>>     result := ByteArray new: count.
>>>     handle at: position read: result startingAt: 1 count: count.
>>>     position := position + count.
>>>      ^ result
>>>
>>> At least with that (among some extensions) Fuel tests pass with FS :)
>>>
>>> Cheers
>>>
>>> --
>>> Mariano
>>> http://marianopeck.wordpress.**com <http://marianopeck.wordpress.com>
>>>
>>>
>>  Still wrong though, I think...
> It doesn't handle the case where you try to read past end of stream.
>
> next: count
> ^self nextInto: (ByteArray new: count)
>
> would probably be better.
>
>
Indeed.



> Cheers,
> Henry
>
>
>


-- 
Mariano
http://marianopeck.wordpress.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pharo.org/pipermail/pharo-dev_lists.pharo.org/attachments/20120108/468e027c/attachment-0001.html>


More information about the Pharo-dev mailing list