Hi,

On Oct 9, 2016, at 11:49 PM, phil@highoctane.be wrote:

Doru,

This looks very nice.

I used a previous version of this I think.

Is performance better?

The performance is a bit better, but more importantly, it is more extensible and can be kept in sync with the official parser. Cheers, Doru

Phil

On Sun, Oct 9, 2016 at 11:23 PM, Tudor Girba <tudor@tudorgirba.com> wrote: Hi,

Pillar now ships with a text editor that also features a syntax highlighter.

So, now, if you load the development version of Pillar:

Gofer new smalltalkhubUser: 'Pier' project: 'Pillar'; configuration; loadDevelopment.

You will have an extra presentation when inspecting a .pillar file:

<pillar-editor.png>

The new thing here is that the highlighter is based on the Pillar PetitParser, and it is extensible for highlighting more parts if needed. The highlighting also can support actions. For example, the picture above shows the file to the right after clicking on the reference.

Please take a look and let me know what you think.

Cheers, Doru

-- www.tudorgirba.com www.feenk.com

"Things happen when they happen, not when you talk about them happening."

-- www.tudorgirba.com www.feenk.com "No matter how many recipes we know, we still value a chef."

Hi,

On Oct 10, 2016, at 8:48 AM, stepharo <stepharo@free.fr> wrote:

Doru do you think that we could get a simple visitor that could create a preview in Pharo?

What kind of preview?

One of the things I would like is:

- minimal package for a pillar core so that we can display class comment using pillar

You already have a showcase for this if you inspect a Class. We should integrate it next in the comment pane of Nautilus.

- a nice looking set of fonts

Do you mean fonts for editing, or for rendering? For the editing part, I used the fonts that we have in Pharo because they are part of the same family and they work reasonably well together. We still have an issue in Rubric in that the cursor is not updated when the font changes (for example, when we switch the font from regular to monospace). I do not know how to fix that yet, and it would be great if someone else would help on that. Cheers, Doru

Stef

Le 9/10/16 à 23:23, Tudor Girba a écrit :

...

Hi,

Pillar now ships with a text editor that also features a syntax highlighter.

So, now, if you load the development version of Pillar:

Gofer new smalltalkhubUser: 'Pier' project: 'Pillar'; configuration; loadDevelopment.

You will have an extra presentation when inspecting a .pillar file:

<Mail Attachment.png>

The new thing here is that the highlighter is based on the Pillar PetitParser, and it is extensible for highlighting more parts if needed. The highlighting also can support actions. For example, the picture above shows the file to the right after clicking on the reference.

Please take a look and let me know what you think.

Cheers, Doru

-- www.tudorgirba.com www.feenk.com

"Things happen when they happen, not when you talk about them happening."

-- www.tudorgirba.com www.feenk.com "Value is always contextual."

Hi, A suggestion from one year ago. Should be this converted into issues? Cheers, Offray On 10/10/16 13:26, Offray Vladimir Luna Cárdenas wrote:

Hi Doru,

I was exploring Stephan Eggermont's code Panel because the zooming in/out behavior implemented there, but I would like to add your Pillar text editor to the exploration.

I would like to add two things:

1. Font decrease/increase buttons/shorcuts, because for long documents, default font size can be tiresome.

2. Augmenting the amount of syntax highlighting languages, starting with markdown. I think that this would be strategic in making writing inside the image, more appealing, giving the spread of markdown as a documentation syntax in different context (GitHub, Scholar markdown, wikis, discussion, Slack clones, etc).

I installed the extension today on a Pharo 5 system, but trying to use it, bring me the error detailed at the end of this mail, so after having it working on Pharo, I would like to explore/help in implementing items 1 and 2, avove.

Cheers,

Offray

Error report =========== Author: OffrayLuna

Array(Object)>>shouldNotImplement Array(ArrayedCollection)>>add: [ :each | self add: each ] in Array(Collection)>>addAll: Array(SequenceableCollection)>>do: Array(Collection)>>addAll: [ :array | ({array first}     addAll: array last;     yourself)     collect: [ :each |         ('' join: each first)             -> (each second ifNotNil: [ :second | '' join: second ]) ] ] in GTPillarHighlighter>>scriptParameters PPActionParser>>parseOn: PPDelegateParser>>parseOn: PPSequenceParser>>parseOn: PPActionParser>>parseOn: PPDelegateParser>>parseOn: PPChoiceParser>>parseOn: PPDelegateParser>>parseOn: PPChoiceParser>>parseOn: PPPossessiveRepeatingParser>>parseOn: PPDelegateParser>>parseOn: PPEndOfInputParser>>parseOn: GTPillarHighlighter(PPDelegateParser)>>parseOn: GTPillarHighlighter(PPParser)>>parseWithContext: GTPillarHighlighter(PPParser)>>parse:withContext: GTPillarHighlighter(PPParser)>>parse: GTPillarHighlighterTextDecorator>>parse:onError: GLMHighlighterTextParserStyler>>privateStyle: [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ] in [ backgroundProcess := [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ]     forkAt: Processor userBackgroundPriority ] in GLMHighlighterTextParserStyler(SHTextStyler)>>styleInBackgroundProcess: [ self value. Processor terminateActive ] in BlockClosure>>newProcess ===============

On 09/10/16 16:23, Tudor Girba wrote:

...

Hi,

Pillar now ships with a text editor that also features a syntax highlighter.

So, now, if you load the development version of Pillar:

Gofer new      smalltalkhubUser: 'Pier' project: 'Pillar';     configuration;     loadDevelopment.

You will have an extra presentation when inspecting a .pillar file:

The new thing here is that the highlighter is based on the Pillar PetitParser, and it is extensible for highlighting more parts if needed. The highlighting also can support actions. For example, the picture above shows the file to the right after clicking on the reference.

Please take a look and let me know what you think.

Cheers, Doru

-- www.tudorgirba.com <http://www.tudorgirba.com> www.feenk.com

"Things happen when they happen, not when you talk about them happening."

Thanks Doru, Installation works, but syntax hightligthning and image preview are disabled. I don't know if this is because is the same image with the installation of GT Documenter, installed. Cheers, Offray On 14/11/17 12:15, Tudor Girba wrote:

Hi,

Please retry again by loading the #development version in Pharo 6.1:

Gofer new smalltalkhubUser: 'Pier' project: 'Pillar'; configuration; loadDevelopment.

You should get the extension out of the box.

Please let me know if it works.

Cheers, Doru

...

On Nov 14, 2017, at 5:55 PM, Offray Vladimir Luna Cárdenas <offray.luna@mutabit.com> wrote:

Hi,

A suggestion from one year ago. Should be this converted into issues?

Cheers,

Offray

On 10/10/16 13:26, Offray Vladimir Luna Cárdenas wrote:

...

Hi Doru,

I was exploring Stephan Eggermont's code Panel because the zooming in/out behavior implemented there, but I would like to add your Pillar text editor to the exploration. I would like to add two things:

1. Font decrease/increase buttons/shorcuts, because for long documents, default font size can be tiresome.

2. Augmenting the amount of syntax highlighting languages, starting with markdown. I think that this would be strategic in making writing inside the image, more appealing, giving the spread of markdown as a documentation syntax in different context (GitHub, Scholar markdown, wikis, discussion, Slack clones, etc). I installed the extension today on a Pharo 5 system, but trying to use it, bring me the error detailed at the end of this mail, so after having it working on Pharo, I would like to explore/help in implementing items 1 and 2, avove.

Cheers,

Offray

Error report =========== Author: OffrayLuna

Array(Object)>>shouldNotImplement Array(ArrayedCollection)>>add: [ :each | self add: each ] in Array(Collection)>>addAll: Array(SequenceableCollection)>>do: Array(Collection)>>addAll: [ :array | ({array first} addAll: array last; yourself) collect: [ :each | ('' join: each first) -> (each second ifNotNil: [ :second | '' join: second ]) ] ] in GTPillarHighlighter>>scriptParameters PPActionParser>>parseOn: PPDelegateParser>>parseOn: PPSequenceParser>>parseOn: PPActionParser>>parseOn: PPDelegateParser>>parseOn: PPChoiceParser>>parseOn: PPDelegateParser>>parseOn: PPChoiceParser>>parseOn: PPPossessiveRepeatingParser>>parseOn: PPDelegateParser>>parseOn: PPEndOfInputParser>>parseOn: GTPillarHighlighter(PPDelegateParser)>>parseOn: GTPillarHighlighter(PPParser)>>parseWithContext: GTPillarHighlighter(PPParser)>>parse:withContext: GTPillarHighlighter(PPParser)>>parse: GTPillarHighlighterTextDecorator>>parse:onError: GLMHighlighterTextParserStyler>>privateStyle: [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ] in [ backgroundProcess := [ self privateStyle: text. view ifNotNil: [ view stylerStyledInBackground: text ] ] forkAt: Processor userBackgroundPriority ] in GLMHighlighterTextParserStyler(SHTextStyler)>>styleInBackgroundProcess: [ self value. Processor terminateActive ] in BlockClosure>>newProcess ===============

On 09/10/16 16:23, Tudor Girba wrote:

...

Hi,

Pillar now ships with a text editor that also features a syntax highlighter.

So, now, if you load the development version of Pillar:

Gofer new smalltalkhubUser: 'Pier' project: 'Pillar'; configuration; loadDevelopment.

You will have an extra presentation when inspecting a .pillar file:

<gjkebecengkghnjk.png>

The new thing here is that the highlighter is based on the Pillar PetitParser, and it is extensible for highlighting more parts if needed. The highlighting also can support actions. For example, the picture above shows the file to the right after clicking on the reference.

Please take a look and let me know what you think.

Cheers, Doru

-- www.tudorgirba.com www.feenk.com

"Things happen when they happen, not when you talk about them happening."

-- www.tudorgirba.com www.feenk.com

"We are all great at making mistakes."