Hi All, TextAction appears to have a couple of issues: TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor" "may be self is included in the event or an Object. " ^ actOnClickBlock cull: self cull: anEvent cull: anObject cull: paragraph cull: editor #cull:cull:cull:cull:cull: doesn't exist, so should be something like: TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor" "may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor) It is also missing the Rubric version: TextAction>>rubActOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor" "may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor) I've followed the convention in the other implementations of #rubActOnClick:for:in:editor: and reimplemented the code, but it could just as easily call #actOnClick:for:in:editor:. Any reason not to submit this as a formal bug report? Should it be submitted as two separate bug reports since they are in separate packages? Thanks! Alistair
2016-05-16 8:29 GMT+02:00 Alistair Grant <akgrant0710@gmail.com>:
Hi All,
TextAction appears to have a couple of issues:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock cull: self cull: anEvent cull: anObject cull: paragraph cull: editor
#cull:cull:cull:cull:cull: doesn't exist, so should be something like:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
It is also missing the Rubric version:
TextAction>>rubActOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
I've followed the convention in the other implementations of #rubActOnClick:for:in:editor: and reimplemented the code, but it could just as easily call #actOnClick:for:in:editor:.
Any reason not to submit this as a formal bug report?
Should it be submitted as two separate bug reports since they are in separate packages?
There is already a bug report for the first issue you described: 18200 <https://pharo.fogbugz.com/f/cases/18200/TextAction-calls-unimplemented-metho...> TextAction calls unimplemented method #cull:cull:cull:cull:cull:
Thanks! Alistair
On Mon, May 16, 2016 at 01:42:16PM +0200, Nicolai Hess wrote:
2016-05-16 8:29 GMT+02:00 Alistair Grant <akgrant0710@gmail.com>:
Hi All,
TextAction appears to have a couple of issues:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor     "sent when a user clicks on a piece of text to which I am applied in an editor"
    "may be self is included in the event or an Object. "     ^ actOnClickBlock cull: self cull: anEvent cull: anObject cull: paragraph cull: editor
#cull:cull:cull:cull:cull: doesn't exist, so should be something like:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor     "sent when a user clicks on a piece of text to which I am applied in an editor"
    "may be self is included in the event or an Object. "     ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
It is also missing the Rubric version:
TextAction>>rubActOnClick: anEvent for: anObject in: paragraph editor: editor     "sent when a user clicks on a piece of text to which I am applied in an editor"
    "may be self is included in the event or an Object. "     ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
I've followed the convention in the other implementations of #rubActOnClick:for:in:editor: and reimplemented the code, but it could just as easily call #actOnClick:for:in:editor:.
Any reason not to submit this as a formal bug report?
Should it be submitted as two separate bug reports since they are in separate packages?
There is already a bug report for the first issue you described: 18200 TextAction calls unimplemented method #cull:cull:cull:cull:cull:
Sigh, guilty (and embarrassed) about not checking the bug tracker first. It looks like there isn't a fix proposed (I couldn't see it in the bug report or in Pharo60Inbox), so if you don't have any objection I'll add my proposed fix. I also couldn't find any reference to the second issue, so will raise a new issue and submit the proposed fix. Thanks for pointing this out, Alistair
Hi all :)
Hi All,
TextAction appears to have a couple of issues:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock cull: self cull: anEvent cull: anObject cull: paragraph cull: editor To me this use of cull: is plain plain plain bad. cull: is a plague. People use is far too often. It indicates a lack of - design - object because with one object the block would get it and select what is needed. - then I do not get why we need to pass the paragraph and the editor
#cull:cull:cull:cull:cull: doesn't exist, so should be something like:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
it looks already better.
It is also missing the Rubric version:
TextAction>>rubActOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
I've followed the convention in the other implementations of #rubActOnClick:for:in:editor: and reimplemented the code, but it could just as easily call #actOnClick:for:in:editor:.
Any reason not to submit this as a formal bug report?
Should it be submitted as two separate bug reports since they are in separate packages?
Thanks! Alistair
On Mon, May 16, 2016 at 08:15:28PM +0200, stepharo wrote:
Hi all :)
Hi All,
TextAction appears to have a couple of issues:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock cull: self cull: anEvent cull: anObject cull: paragraph cull: editor To me this use of cull: is plain plain plain bad. cull: is a plague. People use is far too often. It indicates a lack of - design - object because with one object the block would get it and select what is needed.
+1
- then I do not get why we need to pass the paragraph and the editor
#cull:cull:cull:cull:cull: doesn't exist, so should be something like:
TextAction>>actOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
it looks already better.
Slice submitted to Pharo60Inbox (issue 18200). Thanks for your positive feedback. Cheers, Alistair
It is also missing the Rubric version:
TextAction>>rubActOnClick: anEvent for: anObject in: paragraph editor: editor "sent when a user clicks on a piece of text to which I am applied in an editor"
"may be self is included in the event or an Object. " ^ actOnClickBlock valueWithEnoughArguments: (Array with: self with: anEvent with: anObject with: paragraph with: editor)
I've followed the convention in the other implementations of #rubActOnClick:for:in:editor: and reimplemented the code, but it could just as easily call #actOnClick:for:in:editor:.
Any reason not to submit this as a formal bug report?
Should it be submitted as two separate bug reports since they are in separate packages?
Thanks! Alistair
participants (3)
-
Alistair Grant -
Nicolai Hess -
stepharo