I've found this problem in Pharo 3 (seems to happen in Pharo 4 too): Do: 1. Fileout Seaside-Tests-Core 2. Remove Seaside-Test-Core 3. File in the file created in step 1 You will find: a. The structure of the package changes. b. Comments for WaContextTest are lost c. You get a bunch of errors in Transcript while filing in Any ideas? Thanks in advance.
On 30/10/14 06:57, José Comesaña wrote:
I've found this problem in Pharo 3 (seems to happen in Pharo 4 too):
Do:
1. Fileout Seaside-Tests-Core 2. Remove Seaside-Test-Core 3. File in the file created in step 1
You will find:
a. The structure of the package changes. What do you mean by it changes? New packages? Removed packages? dirty ones?
b. Comments for WaContextTest are lost May be the fileout does not export the comment. Did you check in the .st file?
c. You get a bunch of errors in Transcript while filing in No magic ball so we cannot guess.
Any ideas?
Thanks in advance.
2014-10-30 13:16 GMT+01:00 stepharo <stepharo@free.fr>:
On 30/10/14 06:57, José Comesaña wrote:
I've found this problem in Pharo 3 (seems to happen in Pharo 4 too):
Do:
1. Fileout Seaside-Tests-Core 2. Remove Seaside-Test-Core 3. File in the file created in step 1
You will find:
a. The structure of the package changes.
What do you mean by it changes? New packages? Removed packages? dirty ones?
New package: Seaside-Tests-Core-RequestHandling. WaContextText is now in that package
b. Comments for WaContextTest are lost
May be the fileout does not export the comment. Did you check in the .st file?
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared) WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared) WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared) WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared) WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared) WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared) It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem. Thanks
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging. Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do... Now a simpler and clearer test: 1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest. Maybe, if I get a couple of free hours I could dare to debug a little.... Best 2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
Actually it is a bug in FileOUT! 14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods 2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
Fixed and integrated (pharo 40350) I'll open another issue for backporting to pharo3 2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Actually it is a bug in FileOUT!
14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods
2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
14405 <https://pharo.fogbugz.com/default.asp?14405> (backport pharo3) FileOut creates invalid comment entries for classes with class side methods fix in pharo3inbox 2014-11-04 22:51 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Fixed and integrated (pharo 40350) I'll open another issue for backporting to pharo3
2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Actually it is a bug in FileOUT!
14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods
2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
Ok, thanks a lot for your work. Regards 2014-11-05 20:12 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
14405 <https://pharo.fogbugz.com/default.asp?14405> (backport pharo3) FileOut creates invalid comment entries for classes with class side methods fix in pharo3inbox
2014-11-04 22:51 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Fixed and integrated (pharo 40350) I'll open another issue for backporting to pharo3
2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Actually it is a bug in FileOUT!
14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods
2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
Yes, this has been annoying for a long time. Does backport means that it will be in the downloadable image of 3.0? Thanks a lot! Phil Le 6 nov. 2014 20:16, "José Comesaña" <jose.comesana@gmail.com> a écrit :
Ok, thanks a lot for your work.
Regards
2014-11-05 20:12 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
14405 <https://pharo.fogbugz.com/default.asp?14405> (backport pharo3) FileOut creates invalid comment entries for classes with class side methods fix in pharo3inbox
2014-11-04 22:51 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Fixed and integrated (pharo 40350) I'll open another issue for backporting to pharo3
2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
Actually it is a bug in FileOUT!
14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods
2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
Yes, this has been annoying for a long time.
Does backport means that it will be in the downloadable image of 3.0?
probably.
Thanks a lot!
Phil
Le 6 nov. 2014 20:16, "José Comesaña" <jose.comesana@gmail.com <mailto:jose.comesana@gmail.com>> a écrit :
Ok, thanks a lot for your work.
Regards
2014-11-05 20:12 GMT+01:00 Nicolai Hess <nicolaihess@web.de <mailto:nicolaihess@web.de>>:
14405 <https://pharo.fogbugz.com/default.asp?14405> (backport pharo3) FileOut creates invalid comment entries for classes with class side methods fix in pharo3inbox
2014-11-04 22:51 GMT+01:00 Nicolai Hess <nicolaihess@web.de <mailto:nicolaihess@web.de>>:
Fixed and integrated (pharo 40350) I'll open another issue for backporting to pharo3
2014-11-02 22:24 GMT+01:00 Nicolai Hess <nicolaihess@web.de <mailto:nicolaihess@web.de>>:
Actually it is a bug in FileOUT!
14377 <https://pharo.fogbugz.com/default.asp?14377> FileOut creates invalid comment entries for classes with class side methods
2014-11-02 17:42 GMT+01:00 Nicolai Hess <nicolaihess@web.de <mailto:nicolaihess@web.de>>:
2014-10-31 0:11 GMT+01:00 José Comesaña <jose.comesana@gmail.com <mailto:jose.comesana@gmail.com>>:
I see. But WATestError it is in the same package it is "Fileing", on line 3284 and is referenced many times before. I am sorry I have not enough knowledge about the internals to do more debugging.
Seems to be a lack of coordination between FileOut and FileIn. Maybe nothing to do...
Now a simpler and clearer test:
1. Back to the original situation. 2. FileOut *only* WAContextTest. It has a comment: "I am the base class for all tests that need a WARequestContext present.", in .st file in line 8. 3. Remove it. 4. FileIn again. No errors on Transcript BUT no comment appears for WAContextTest.
Maybe, if I get a couple of free hours I could dare to debug a little....
Best
2014-10-30 23:30 GMT+01:00 stepharo <stepharo@free.fr <mailto:stepharo@free.fr>>:
It says that the class WATestError is not available.
Yes, I did. It is in the .st file
c. You get a bunch of errors in Transcript while filing in
No magic ball so we cannot guess.
Example of Transcript messages (in case it helps): WADocumentHandlerResponseTest>>createAndVerifyBinaryDocumentNamed:hasAttachment: (WATestingFiles is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testCommaReturnsExceptionSet (WATestError is Undeclared)
WAExceptionHandlerTest>>testInternalError (WATestError is Undeclared)
It happens in more cases. I just took this one because this is a package anyone can install in order to reproduce the problem.
Thanks
Yes, it is a bug. Verified on Pharo4 with class ZnMessageBenchmark. The class has a comment, after fileout/remove class/filein this class is without a comment. I'll open a bug report.
On 06 Nov 2014, at 21:59, phil@highoctane.be wrote:
Yes, this has been annoying for a long time.
Does backport means that it will be in the downloadable image of 3.0?
Thanks a lot!
Yes! It is already noted as âfix to includeâ, I will do an update for Pharo3 today. Marcus
Great. This platform is a joy to work with and becomes better all the time. 2015 will be a great Pharo4 year :-) Phil On Fri, Nov 7, 2014 at 7:47 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On 06 Nov 2014, at 21:59, phil@highoctane.be wrote:
Yes, this has been annoying for a long time.
Does backport means that it will be in the downloadable image of 3.0?
Thanks a lot!
Yes! It is already noted as âfix to includeâ, I will do an update for Pharo3 today.
Marcus
On 07 Nov 2014, at 08:36, phil@highoctane.be wrote:
Great.
This platform is a joy to work with and becomes better all the time.
2015 will be a great Pharo4 year :-)
Phil
+10
On Fri, Nov 7, 2014 at 7:47 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On 06 Nov 2014, at 21:59, phil@highoctane.be wrote:
Yes, this has been annoying for a long time.
Does backport means that it will be in the downloadable image of 3.0?
Thanks a lot!
Yes! It is already noted as âfix to includeâ, I will do an update for Pharo3 today.
Marcus
participants (6)
-
José Comesaña -
Marcus Denker -
Nicolai Hess -
phil＠highoctane.be -
stepharo -
Sven Van Caekenberghe