And give me concrete steps to see that it is not working (if you will find it)��

2017-11-09 23:47 GMT+01:00 Tim Mackinnon <tim@testit.works>:
Thanks Denis - I'll try my simple TDD test case in Pharo 7 (I haven't tried it yet - probably time to).

I think it is correct to show green if you fix your problem in the debugger and then proceed and ��it passes all assertions. But it should equally fail if you proceed and it asserts false or craps out.

Strange it would vary in 6.1 - but I'll check.

Tim

Sent from my iPhone



Sent from my iPhone
On 9 Nov 2017, at 19:54, Denis Kudriashov <dionisiydk@gmail.com> wrote:

In Pharo 7 it works.

2017-11-09 18:29 GMT+01:00 Tim Mackinnon <tim@testit.works>:
Thanks for looking at this - there is an issue however - when you apply that change (at least in a Pharo 6.1 image) - it shows green even when a test fails? So I think its turned one problem into the opposite one.

Unfortunately I haven���t got a chance to look a bit deeper to help - but it might be worth rolling back this change for now. We should fix it though - and the answer must be in the area you have identified.

tim

On 9 Nov 2017, at 12:43, Denis Kudriashov <dionisiydk@gmail.com> wrote:

And now it is in latest Pharo

2017-11-09 12:16 GMT+01:00 Denis Kudriashov <dionisiydk@gmail.com>:
Hi Tim.

Thank's for reporting. It forces me to fix. I always noticed it but never take it seriously :)

2017-11-09 11:32 GMT+01:00 Tim Mackinnon <tim@testit.works>:
Hi - I really like the build in test runner in the Pharo browsers, and I was preparing a talk to show how great TDD is in Pharo and how we aren���t ashamed of our debugger when testing (it augments the experience in fact - letting you poke around and get your thoughts straight).

However - if I pick rerun in the test runner debugger - and step through a test and then correct the failing code, and hit resume - the browser always shows a red failure, even though the execution is now correct. I have to run the test again.

This doesn���t seem right to me - are we missing a success event or something?


Tim