Just made this convenience, sharing: Path>>parentUpTo: aParentDirName "Answers the path of the parent dir with name aParentDirName or root if not found." self withParents reversed do:[:dir| dir basename = aParentDirName ifTrue:[^dir]]. ^ Path root
hi seb could you add a test or two and a bug entry so that we include it in FS? Stef On 25 Feb 2014, at 03:18, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Just made this convenience, sharing:
Path>>parentUpTo: aParentDirName "Answers the path of the parent dir with name aParentDirName or root if not found."
self withParents reversed do:[:dir| dir basename = aParentDirName ifTrue:[^dir]].
^ Path root
Would this be okay? https://pharo.fogbugz.com/f/cases/12991/navigation-enhancement-Path-parentUp... On Feb 25, 2014, at 4:05 AM, Pharo4Stef <pharo4Stef@free.fr> wrote:
hi seb
could you add a test or two and a bug entry so that we include it in FS?
Stef
On 25 Feb 2014, at 03:18, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Just made this convenience, sharing:
Path>>parentUpTo: aParentDirName "Answers the path of the parent dir with name aParentDirName or root if not found."
self withParents reversed do:[:dir| dir basename = aParentDirName ifTrue:[^dir]].
^ Path root
On 25 Feb 2014, at 14:36, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Would this be okay?
https://pharo.fogbugz.com/f/cases/12991/navigation-enhancement-Path-parentUp...
Well, not yet, you should learn how to make a actual slice... http://www.pharo-project.org/community/issue-tracking there are 2 movies and there is an explanation. Sven
Okay, Iâll take a look later (donât know when) and I keep the impression of unnecessary friction to receive contributions Something to think about On Feb 25, 2014, at 10:40 AM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 25 Feb 2014, at 14:36, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Would this be okay?
https://pharo.fogbugz.com/f/cases/12991/navigation-enhancement-Path-parentUp...
Well, not yet, you should learn how to make a actual slice...
http://www.pharo-project.org/community/issue-tracking
there are 2 movies and there is an explanation.
Sven
On 25 Feb 2014, at 15:01, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Okay, Iâll take a look later (donât know when)
and
I keep the impression of unnecessary friction to receive contributions
Something to think about
I am sorry it feels that way, but it is not. It is the difference between sending an actual git pull request on the source code and an email with some partial, copied code. The first is more work for you, but can be used in automated systems like our CI, can be merged with one operation and will serve as a historic record. The latter pushes all the work to the integrators, who are already overloaded. Making a slice is not more work that using Monticello, which you are probably doing every day.
On Feb 25, 2014, at 10:40 AM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 25 Feb 2014, at 14:36, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Would this be okay?
https://pharo.fogbugz.com/f/cases/12991/navigation-enhancement-Path-parentUp...
Well, not yet, you should learn how to make a actual slice...
http://www.pharo-project.org/community/issue-tracking
there are 2 movies and there is an explanation.
Sven
thanks for explaining Sven, donât be sorry for me, be sorry for the less abundant contributions the community main artifact gets. I get what you mean Iâm all for automation My point is that we deserve (and should aim?) to get the best of both worlds: 1. easy to provide (read: low friction) bug reports / contributions 2. easy to digest (even automated) bug reports / contributions While I understand that we are in a trade off now, I continue with the impression of unnecessary friction and a bit worried about the less chances of getting more valuable contributions How to make things easy for those both publics is the âsomething to think aboutâ Iâm mentioning It would be interesting to hear what ideas come from that because lowering that friction has chances to be a breakthrough On Feb 25, 2014, at 11:12 AM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 25 Feb 2014, at 15:01, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Okay, Iâll take a look later (donât know when)
and
I keep the impression of unnecessary friction to receive contributions
Something to think about
I am sorry it feels that way, but it is not.
It is the difference between sending an actual git pull request on the source code and an email with some partial, copied code. The first is more work for you, but can be used in automated systems like our CI, can be merged with one operation and will serve as a historic record. The latter pushes all the work to the integrators, who are already overloaded.
Making a slice is not more work that using Monticello, which you are probably doing every day.
On Feb 25, 2014, at 10:40 AM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 25 Feb 2014, at 14:36, Sebastian Sastre <sebastian@flowingconcept.com> wrote:
Would this be okay?
https://pharo.fogbugz.com/f/cases/12991/navigation-enhancement-Path-parentUp...
Well, not yet, you should learn how to make a actual slice...
http://www.pharo-project.org/community/issue-tracking
there are 2 movies and there is an explanation.
Sven
participants (3)
-
Pharo4Stef -
Sebastian Sastre -
Sven Van Caekenberghe