Is GTSpotter theme-aware ? It does not seem to use the Dark Theme: Sven
Hi, For now testing Spotter for every existing theme is not on the first place in our TODO list. But Spotter uses themer mechanism, so anyone can customize it :) Cheers, Alex On Dec 10, 2014 4:42 PM, "Sven Van Caekenberghe" <sven@stfx.eu> wrote:
Is GTSpotter theme-aware ?
It does not seem to use the Dark Theme:
Sven
it doesnât need to be made for every theme around, just âtheme awareâ, which means do not use hardcoded values but the ones defined in the themes. Esteban
On 10 Dec 2014, at 16:47, Aliaksei Syrel <alex.syrel@gmail.com> wrote:
Hi,
For now testing Spotter for every existing theme is not on the first place in our TODO list. But Spotter uses themer mechanism, so anyone can customize it :)
Cheers, Alex
On Dec 10, 2014 4:42 PM, "Sven Van Caekenberghe" <sven@stfx.eu <mailto:sven@stfx.eu>> wrote: Is GTSpotter theme-aware ?
It does not seem to use the Dark Theme:
<Screen Shot 2014-12-10 at 16.40.23.png>
Sven
It is. Read my mail :). Doru On Wed, Dec 10, 2014 at 4:59 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
it doesnât need to be made for every theme around, just âtheme awareâ, which means do not use hardcoded values but the ones defined in the themes.
Esteban
On 10 Dec 2014, at 16:47, Aliaksei Syrel <alex.syrel@gmail.com> wrote:
Hi,
For now testing Spotter for every existing theme is not on the first place in our TODO list. But Spotter uses themer mechanism, so anyone can customize it :)
Cheers, Alex On Dec 10, 2014 4:42 PM, "Sven Van Caekenberghe" <sven@stfx.eu> wrote:
Is GTSpotter theme-aware ?
It does not seem to use the Dark Theme:
<Screen Shot 2014-12-10 at 16.40.23.png>
Sven
-- www.tudorgirba.com "Every thing has its own flow"
So the proposed solution is to do separate them class hierarchies with essentially the same properties (colors, fonts, etc) on a Tool-by-Tool basis? I'm certainly no lover of the current UITheme, but that doesn't sound like it scales a whole lot better to me... (Ref. your example, having UITheme methods aimed at giving Dialogs specific active fill colors (so, active fill colors for other types of windows are potentially different?) sounds rather the wrong way to go about things...) Cheers, Henry
On 10 Dec 2014, at 5:03 , Tudor Girba <tudor@tudorgirba.com> wrote:
It is. Read my mail :).
Doru
On Wed, Dec 10, 2014 at 4:59 PM, Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>> wrote: it doesnât need to be made for every theme around, just âtheme awareâ, which means do not use hardcoded values but the ones defined in the themes.
Esteban
On 10 Dec 2014, at 16:47, Aliaksei Syrel <alex.syrel@gmail.com <mailto:alex.syrel@gmail.com>> wrote:
Hi,
For now testing Spotter for every existing theme is not on the first place in our TODO list. But Spotter uses themer mechanism, so anyone can customize it :)
Cheers, Alex
On Dec 10, 2014 4:42 PM, "Sven Van Caekenberghe" <sven@stfx.eu <mailto:sven@stfx.eu>> wrote: Is GTSpotter theme-aware ?
It does not seem to use the Dark Theme:
<Screen Shot 2014-12-10 at 16.40.23.png>
Sven
-- www.tudorgirba.com <http://www.tudorgirba.com/>
"Every thing has its own flow"
It was made to be themeable, but there is only one theme implemented. In fact, this is the first tool that is based completely on the pattern I described previously: http://www.humane-assessment.com/blog/a-pharo-refactoring-story-adding-theme... The theming is done in GTSpotterWidgetThemer. To contextualize it for the DarkTheme one would need to: - Subclass GTSpotterWidgetThemer - Override UITheme>>spotterWidgetThemer ^ GTSpotterWidgetThemer new Like this, UITheme becomes a composite of concrete independent themer objects and can be more manageable. Doru On Wed, Dec 10, 2014 at 4:41 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Is GTSpotter theme-aware ?
It does not seem to use the Dark Theme:
Sven
-- www.tudorgirba.com "Every thing has its own flow"
participants (5)
-
Aliaksei Syrel -
Esteban Lorenzano -
Henrik Johansen -
Sven Van Caekenberghe -
Tudor Girba