[Pharo-project] [update] #10492 (1.0rc1)
10492 (this is the stream of the branch 1.0rc1) ----- - Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258) ___________________ http://www.adrian-lienhard.ch/
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber". Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2 This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails. Also, a test is added to test and document the new squeezing number out of strings behavior. Example usage: self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0. Cheers, Niko On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: Â [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: Â HostWindowTests>>testOne is failing in Windows - Issue 1345: Â Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Thanks niko So does everybody agree with asNumber raising an error and squeezeOutNumber I like the proposal. Stef On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code. Adrian On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with asNumber raising an error and squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Yes a good deprecation is needed. Stef On Oct 24, 2009, at 11:13 AM, Adrian Lienhard wrote:
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code.
Adrian
On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with asNumber raising an error and squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Well, what do you propose? Deprecating asNumber calls altogether? Cheers, Niko On Sat, Oct 24, 2009 at 10:32 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Yes a good deprecation is needed.
Stef On Oct 24, 2009, at 11:13 AM, Adrian Lienhard wrote:
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code.
Adrian
On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with    asNumber raising an error    and    squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
   self assert: '123blabla' squeezeOutNumber equals: 123.   self assert: 'blabla123' squeezeOutNumber equals: 123.   self assert: 'blabla12blabla' squeezeOutNumber equals: 12.   self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001.   self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: Â [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: Â HostWindowTests>>testOne is failing in Windows - Issue 1345: Â Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Not really we could do the following - check all the users of asNumber and let them as asNUmber or squeezeOutNumber - then put a deprecation during the alpha phase that state that they should pay attention - when we are in rc 1.1 we remove the deprecation - create a package which would override it with a deprecation. stef On Oct 27, 2009, at 2:38 PM, Niko Schwarz wrote:
Well, what do you propose? Deprecating asNumber calls altogether?
Cheers,
Niko
On Sat, Oct 24, 2009 at 10:32 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Yes a good deprecation is needed.
Stef On Oct 24, 2009, at 11:13 AM, Adrian Lienhard wrote:
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code.
Adrian
On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with asNumber raising an error and squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Well, by doing that you will confuse users that only relied on the consensual functionality of asNumber. It's difficult both ways, and because of that, I'd suggest going the lazy way and not helping the users other than by adding a comment to #asNumber which explains the evolution of the message and points to #squeezeOutNumber. I know that the users would appreciate help in the migration, but I don't see a non-obtrusive way to do so. Cheers, Niko On Tue, Oct 27, 2009 at 2:59 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Not really
we could do the following     - check all the users of asNumber and let them as asNUmber or squeezeOutNumber     - then put a deprecation during the alpha phase that state that they should pay attention     - when we are in rc 1.1 we remove the deprecation     - create a package which would override it with a deprecation.
stef
On Oct 27, 2009, at 2:38 PM, Niko Schwarz wrote:
Well, what do you propose? Deprecating asNumber calls altogether?
Cheers,
Niko
On Sat, Oct 24, 2009 at 10:32 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Yes a good deprecation is needed.
Stef On Oct 24, 2009, at 11:13 AM, Adrian Lienhard wrote:
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code.
Adrian
On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with    asNumber raising an error    and    squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
   self assert: '123blabla' squeezeOutNumber equals: 123.   self assert: 'blabla123' squeezeOutNumber equals: 123.   self assert: 'blabla12blabla' squeezeOutNumber equals: 12.   self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001.   self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: Â [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: Â HostWindowTests>>testOne is failing in Windows - Issue 1345: Â Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
may be you are right. I do not know so at least we should check all the users in the system On Oct 27, 2009, at 3:13 PM, Niko Schwarz wrote:
Well, by doing that you will confuse users that only relied on the consensual functionality of asNumber.
It's difficult both ways, and because of that, I'd suggest going the lazy way and not helping the users other than by adding a comment to #asNumber which explains the evolution of the message and points to #squeezeOutNumber. I know that the users would appreciate help in the migration, but I don't see a non-obtrusive way to do so.
Cheers,
Niko
On Tue, Oct 27, 2009 at 2:59 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Not really
we could do the following - check all the users of asNumber and let them as asNUmber or squeezeOutNumber - then put a deprecation during the alpha phase that state that they should pay attention - when we are in rc 1.1 we remove the deprecation - create a package which would override it with a deprecation.
stef
On Oct 27, 2009, at 2:38 PM, Niko Schwarz wrote:
Well, what do you propose? Deprecating asNumber calls altogether?
Cheers,
Niko
On Sat, Oct 24, 2009 at 10:32 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Yes a good deprecation is needed.
Stef On Oct 24, 2009, at 11:13 AM, Adrian Lienhard wrote:
Sounds ok. At the same time as integrating the change, all senders of asNumber in the image need to be checked and adapted to the new semantics if necessary. IIRC MC was not properly working after the change. Also, users and maintainers of external packages should be made aware of the change since it may break their code.
Adrian
On Oct 24, 2009, at 10:46 , Stéphane Ducasse wrote:
Thanks niko
So does everybody agree with asNumber raising an error and squeezeOutNumber
I like the proposal.
Stef
On Oct 24, 2009, at 10:30 AM, Niko Schwarz wrote:
Hi all, I made a follow-up patch like discussed on the workshop. Now porting becomes as easy as changing "asNumber" to "squeezeOutNumber".
Name: SLICE-issue-1258-squeezeOutNumber-NikoSchwarz.2
This slice adds squeezeNumberOutOfString: to Number, as discussed in the Pharo workshop. On the way, it fixes an issue in SqNumberParser, where it would return itself rather than the result of the failblack, when parsing fails.
Also, a test is added to test and document the new squeezing number out of strings behavior.
Example usage:
self assert: '123blabla' squeezeOutNumber equals: 123. self assert: 'blabla123' squeezeOutNumber equals: 123. self assert: 'blabla12blabla' squeezeOutNumber equals: 12. self assert: ('12.3bla' squeezeOutNumber -12.3 ) abs < 0.0001. self assert: '.1' squeezeOutNumber > 0.
Cheers,
Niko
On Tue, Oct 20, 2009 at 2:14 PM, Adrian Lienhard <adi@netstyle.ch
wrote:
10492 (this is the stream of the branch 1.0rc1) -----
- Issue 1320: [squeak trunk] Sort the conflicts. This is required when merging a distant version, like Pharo for example... - Issue 1338: HostWindowTests>>testOne is failing in Windows - Issue 1345: Revert Number class>>readFrom: (was integrated with issue 1258)
___________________ http://www.adrian-lienhard.ch/
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo- project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (3)
-
Adrian Lienhard -
Niko Schwarz -
Stéphane Ducasse