[Pharo-project] troubles with glamour finder in pharo 1.4
Hi, We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes. The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :). Cheers, Doru -- www.tudorgirba.com "Next time you see your life passing by, say 'hi' and get to know her."
If you tell me how to load the code easily, and where to have a look, I can do that ;) Ben On Feb 14, 2012, at 9:58 PM, Tudor Girba wrote:
Hi,
We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes.
The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :).
Cheers, Doru
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
Thanks, Ben. You can: - load it in Pharo 1.4: Gofer new squeaksource: 'Glamour'; package: 'ConfigurationOfGlamour'; load. (ConfigurationOfGlamour project version: 'default') load: #('Core' 'Morphic') - or download the ready-made Moose image: http://ci.moosetechnology.org/job/moose-latest-dev/lastSuccessfulBuild/artif... To reproduce the problem, try this: GLMFinder new show: [:a | a list display: [:x | 1 to: x ]]; openOn: 100 and then click on the first and on the second to try to get the third pane. The third pane does not appear, but the scrollbar does. The relevant code is in GLMPaneScroller. Cheers, Doru On 14 Feb 2012, at 22:07, Benjamin wrote:
If you tell me how to load the code easily, and where to have a look, I can do that ;)
Ben
On Feb 14, 2012, at 9:58 PM, Tudor Girba wrote:
Hi,
We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes.
The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :).
Cheers, Doru
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
-- www.tudorgirba.com "From an abstract enough point of view, any two things are similar."
Hi, For your information, the bug is now fixed. The issue was that Scrollbar changed the way it sets the scroll value in the model. Before, we had some magic way of inferring the selector, now the selector must be explicitly set: ScrollBar new model: self; setValueSelector: #scrollBarValue:; yourself. This is a good thing, but perhaps others will have similar problems so I thought of documenting it. Cheers, Doru On 15 Feb 2012, at 07:02, Tudor Girba wrote:
Thanks, Ben.
You can: - load it in Pharo 1.4: Gofer new squeaksource: 'Glamour'; package: 'ConfigurationOfGlamour'; load. (ConfigurationOfGlamour project version: 'default') load: #('Core' 'Morphic')
- or download the ready-made Moose image: http://ci.moosetechnology.org/job/moose-latest-dev/lastSuccessfulBuild/artif...
To reproduce the problem, try this: GLMFinder new show: [:a | a list display: [:x | 1 to: x ]]; openOn: 100
and then click on the first and on the second to try to get the third pane. The third pane does not appear, but the scrollbar does.
The relevant code is in GLMPaneScroller.
Cheers, Doru
On 14 Feb 2012, at 22:07, Benjamin wrote:
If you tell me how to load the code easily, and where to have a look, I can do that ;)
Ben
On Feb 14, 2012, at 9:58 PM, Tudor Girba wrote:
Hi,
We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes.
The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :).
Cheers, Doru
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
-- www.tudorgirba.com
"From an abstract enough point of view, any two things are similar."
-- www.tudorgirba.com "Every now and then stop and ask yourself if the war you're fighting is the right one."
thanks doru. What about an initialize and a default value? Because I find that strange. Stef On Feb 17, 2012, at 9:39 AM, Tudor Girba wrote:
Hi,
For your information, the bug is now fixed.
The issue was that Scrollbar changed the way it sets the scroll value in the model. Before, we had some magic way of inferring the selector, now the selector must be explicitly set: ScrollBar new model: self; setValueSelector: #scrollBarValue:; yourself.
This is a good thing, but perhaps others will have similar problems so I thought of documenting it.
Cheers, Doru
On 15 Feb 2012, at 07:02, Tudor Girba wrote:
Thanks, Ben.
You can: - load it in Pharo 1.4: Gofer new squeaksource: 'Glamour'; package: 'ConfigurationOfGlamour'; load. (ConfigurationOfGlamour project version: 'default') load: #('Core' 'Morphic')
- or download the ready-made Moose image: http://ci.moosetechnology.org/job/moose-latest-dev/lastSuccessfulBuild/artif...
To reproduce the problem, try this: GLMFinder new show: [:a | a list display: [:x | 1 to: x ]]; openOn: 100
and then click on the first and on the second to try to get the third pane. The third pane does not appear, but the scrollbar does.
The relevant code is in GLMPaneScroller.
Cheers, Doru
On 14 Feb 2012, at 22:07, Benjamin wrote:
If you tell me how to load the code easily, and where to have a look, I can do that ;)
Ben
On Feb 14, 2012, at 9:58 PM, Tudor Girba wrote:
Hi,
We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes.
The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :).
Cheers, Doru
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
-- www.tudorgirba.com
"From an abstract enough point of view, any two things are similar."
-- www.tudorgirba.com
"Every now and then stop and ask yourself if the war you're fighting is the right one."
Cool :) You find it before me :) Indeed, you shouldn't be the only one with this problem :s Ben On Feb 17, 2012, at 9:39 AM, Tudor Girba wrote:
Hi,
For your information, the bug is now fixed.
The issue was that Scrollbar changed the way it sets the scroll value in the model. Before, we had some magic way of inferring the selector, now the selector must be explicitly set: ScrollBar new model: self; setValueSelector: #scrollBarValue:; yourself.
This is a good thing, but perhaps others will have similar problems so I thought of documenting it.
Cheers, Doru
On 15 Feb 2012, at 07:02, Tudor Girba wrote:
Thanks, Ben.
You can: - load it in Pharo 1.4: Gofer new squeaksource: 'Glamour'; package: 'ConfigurationOfGlamour'; load. (ConfigurationOfGlamour project version: 'default') load: #('Core' 'Morphic')
- or download the ready-made Moose image: http://ci.moosetechnology.org/job/moose-latest-dev/lastSuccessfulBuild/artif...
To reproduce the problem, try this: GLMFinder new show: [:a | a list display: [:x | 1 to: x ]]; openOn: 100
and then click on the first and on the second to try to get the third pane. The third pane does not appear, but the scrollbar does.
The relevant code is in GLMPaneScroller.
Cheers, Doru
On 14 Feb 2012, at 22:07, Benjamin wrote:
If you tell me how to load the code easily, and where to have a look, I can do that ;)
Ben
On Feb 14, 2012, at 9:58 PM, Tudor Girba wrote:
Hi,
We are almost done with getting Glamour work on 1.4. The model works, and most of the rendering is fine as well. The only major trouble is with the rendering of the finder. In particular, the problem is the scrolling through the panes.
The scrolling code was basically copied from OB (shamelessly :)). Something must have changed in Pharo 1.4 that disables some of the behavior. Could anyone spare a pair of eyes to look into this :).
Cheers, Doru
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
-- www.tudorgirba.com
"From an abstract enough point of view, any two things are similar."
-- www.tudorgirba.com
"Every now and then stop and ask yourself if the war you're fighting is the right one."
participants (3)
-
Benjamin -
Stéphane Ducasse -
Tudor Girba