[Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi, in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example: senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod]. debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side). With #allReferencesTo: senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16" Is this a bug in #allSendersOf: or I don't understand ? Cheers, Laurent Laffont http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
Look like the suspect is in SystemNavigation and is here (change "class" to "behavior" when creating the Method reference): addSelectorsReferingTo: aSymbol in: class to: sortedSenders special: special byte: byte {class. class class} do: [:behavior| (behavior thoroughWhichSelectorsReferTo: aSymbol special: special byte: byte) do: [ :sel | sortedSenders add: (MethodReference class: behavior selector: sel) ]] ----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein) From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo: Hi, in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example: senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18"senders collect: [:aReference| aReference compiledMethod]. debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side). With #allReferencesTo: senders := (SystemNavigation default allReferencesTo: #methodsFor:).senders size. "answers 16" Is this a bug in #allSendersOf: or I don't understand ? Cheers,Laurent Laffont http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/ _________________________________________________________________ MSN Dating: Find someone special. Start now. http://go.microsoft.com/?linkid=9734384
Fix attached. Hope this helps! ----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein) From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo: Hi, in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example: senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18"senders collect: [:aReference| aReference compiledMethod]. debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side). With #allReferencesTo: senders := (SystemNavigation default allReferencesTo: #methodsFor:).senders size. "answers 16" Is this a bug in #allSendersOf: or I don't understand ? Cheers,Laurent Laffont http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/ _________________________________________________________________ Learn more ways to connect with your buddies now http://go.microsoft.com/?linkid=9734388
On Sun, Jun 27, 2010 at 10:01 AM, Benoit St-Jean <bstjean@hotmail.ca> wrote:
Fix attached.
Hope this helps!
Thank you. http://code.google.com/p/pharo/issues/detail?id=2593 <http://code.google.com/p/pharo/issues/detail?id=2593>Laurent -----------------
Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
------------------------------ From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
------------------------------ Enter for a chance to get your town photo on Bing.ca! Submit a Photo Now! <http://go.microsoft.com/?linkid=9734383>
http://code.google.com/p/pharo/issues/detail?id=2592 :) On Jun 27, 2010, at 10:16 AM, laurent laffont wrote:
On Sun, Jun 27, 2010 at 10:01 AM, Benoit St-Jean <bstjean@hotmail.ca> wrote: Fix attached.
Hope this helps!
Thank you. http://code.google.com/p/pharo/issues/detail?id=2593
Laurent
----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
Enter for a chance to get your town photo on Bing.ca! Submit a Photo Now!
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Thanks. SystemNavigation is the result of a merge between behavior defined in browser and systemdictionary so having a nice pass over it would be great. http://code.google.com/p/pharo/issues/detail?id=2592 Stef On Jun 27, 2010, at 10:01 AM, Benoit St-Jean wrote:
Fix attached.
Hope this helps!
Sure it does Benoit did you sign the license agreement? Stef
----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
Enter for a chance to get your town photo on Bing.ca! Submit a Photo Now! <SystemNavigation-addSelectorsReferingTointospecialbyte.st>_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
In PharoInbox: SLICE-Issue-2593-SystemNavigationAddSelectorsReferingTo-LaurentLaffont.1 Apply Benoit St-Jean patch + add non-regression test Laurent Laffont On Sun, Jun 27, 2010 at 10:01 AM, Benoit St-Jean <bstjean@hotmail.ca> wrote:
Fix attached.
Hope this helps!
----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
------------------------------ From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
------------------------------ Enter for a chance to get your town photo on Bing.ca! Submit a Photo Now! <http://go.microsoft.com/?linkid=9734383>
If that helps (please say yes, it took HOURS to run!), here are the latest results of running all unit tests for: Image: Pharo-1.1-11400-rc2 Latest update: #11400 OS: Windows XP, SP3 VM version string: Squeak3.10.2 of ''5 June 2008'' [latest update: #7179] Hope this helps! ----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein) From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo: Hi, in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example: senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18"senders collect: [:aReference| aReference compiledMethod]. debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side). With #allReferencesTo: senders := (SystemNavigation default allReferencesTo: #methodsFor:).senders size. "answers 16" Is this a bug in #allSendersOf: or I don't understand ? Cheers,Laurent Laffont http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/ _________________________________________________________________ Look 'em in the eye: FREE Messenger video chat http://go.microsoft.com/?linkid=9734386
2010/6/27 Benoit St-Jean <bstjean@hotmail.ca>
If that helps (please say yes, it took HOURS to run!), here are the latest results of running all unit tests for:
Hi Benoit St-Jean. Yes, they are always useful. The HOURS is because I added Metacello tests to the dev image, which are a lot.
Image: Pharo-1.1-11400-rc2 Latest update: #11400 OS: Windows XP, SP3 VM version string: Squeak3.10.2 of ''5 June 2008'' [latest update: #7179]
Hope this helps!
What it is interesting is that when you have few minutes and want to contribute to Pharo, you just take a particular test, adn try to analyze it. If possibe, fix it. BTW, there is a new way to exporting the results of a tests run: notice the button "file out results" in the right of the test runner. Then, search the file in the same directory where the image is. Cheers Mariano
----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
------------------------------ From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
------------------------------ Turn down-time into play-time with Messenger games Play Now!<http://go.microsoft.com/?linkid=9734381>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
uffff sorry....I have just seen your second attachment...forget what I said ;) 2010/6/27 Benoit St-Jean <bstjean@hotmail.ca>
If that helps (please say yes, it took HOURS to run!), here are the latest results of running all unit tests for:
Image: Pharo-1.1-11400-rc2 Latest update: #11400 OS: Windows XP, SP3 VM version string: Squeak3.10.2 of ''5 June 2008'' [latest update: #7179]
Hope this helps!
----------------- Benoit St-Jean A standpoint is an intellectual horizon of radius zero. (Albert Einstein)
------------------------------ From: laurent.laffont@gmail.com Date: Sun, 27 Jun 2010 08:33:52 +0200 To: pharo-project@lists.gforge.inria.fr Subject: [Pharo-project] SystemNavigation#allSendersOf: vs SystemNavigation#allReferencesTo:
Hi,
in Autotest I search for all senders of a method. The first version used SystemNavigation#allSendersOf: which sometimes returns wrong results (I think). For example:
senders := (SystemNavigation default allSendersOf: #methodsFor:). senders size. "answers 18" senders collect: [:aReference| aReference compiledMethod].
debuggers open as ChangeSet#scanCategory doesn't exist (it's on the class side but allSendersOf: returns #scanCategory reference on class side and instance side).
With #allReferencesTo:
senders := (SystemNavigation default allReferencesTo: #methodsFor:). senders size. "answers 16"
Is this a bug in #allSendersOf: or I don't understand ?
Cheers,
Laurent Laffont
http://pharocasts.blogspot.com/ http://magaloma.blogspot.com/
------------------------------ Turn down-time into play-time with Messenger games Play Now!<http://go.microsoft.com/?linkid=9734381>
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (4)
-
Benoit St-Jean -
laurent laffont -
Mariano Martinez Peck -
Stéphane Ducasse