[Pharo-project] Comments on Metacello and ConfigurationOfExternalWebBrowser
They are doing an excellent work
+1
if you saw the typos, an if it was even versioned code, why didn't you fix them and commit ?
It's in package "Metacello-Tutorial" and the repo http://seaside.gemstone.com/ss/metacello is READ only
Don't put initials.
But the examples in the lesson use initials "dkh". Thats why I asked and recommended more infos (name, initials, contact) like in Java Maven POM's.
I have two erros
Dont know about your image, config and changes - I just tried in a clean udated core image #10506
you are using for FFI '1.0-baseline'
Thats by intention since I dont think there will be another baseline and I want the latest. But since I use it with transitive dependency in a release version of ExternalWebBrowser you are right. It's fixed now.
And the other thing is that you put everything under spec for: #common
Depends on the meaning of common (only Pharo and other Squeak Distributions) or does it include other Smalltalks (VW, VAST) too? If Metacello gets ported then you are right. The tutorial only says: "In addition to #common, there are pre-defined attributes for each of the platforms upon which Metacello runs (#pharo, #squeak, #gemstone and #squeakCommon)." However FFI (which is definitely limited to Squeak derivates) is also #common and I used it as a template. Maybe #squeakCommon is right for FFI and ExternalWebBrowser since this is what is used in the seaside, swazoo, ... configs. Bye T. -- Preisknaller: GMX DSL Flatrate für nur 16,99 Euro/mtl.! http://portal.gmx.net/de/go/dsl02
On Wed, Jan 13, 2010 at 3:34 PM, Torsten Bergmann <astares@gmx.de> wrote:
They are doing an excellent work
+1
if you saw the typos, an if it was even versioned code, why didn't you fix them and commit ?
It's in package "Metacello-Tutorial" and the repo http://seaside.gemstone.com/ss/metacello is READ only
Come on!!! That's not an excuse ;) You can send the .ch for mail, ask for access, etc :)
Don't put initials.
But the examples in the lesson use initials "dkh". Thats why I asked and recommended more infos (name, initials, contact) like in Java Maven POM's.
mmm now that I think it again, is true, sometimes I saw dkh instead of the name...You are right. Let's wait what Dale says.
I have two erros
Dont know about your image, config and changes - I just tried in a clean udated core image #10506
you are using for FFI '1.0-baseline'
Thats by intention since I dont think there will be another baseline and I want the latest. But since I use it with transitive dependency in a release version of ExternalWebBrowser you are right. It's fixed now.
And the other thing is that you put everything under spec for: #common
Depends on the meaning of common (only Pharo and other Squeak Distributions) or does it include other Smalltalks (VW, VAST) too?
#common always mean common, all. Metacello *should* work on every Smalltalk that supports Monticello. Right now, I know it is working in Squeak, Pharo and Gemstone. So, if it works in all of them, then it is correct to put them in #common. Otherwise, put it where it works. There is also something like #commonSqueak or something like that , which is for pharo and squeak (but not gemstone). But I don't remember exactly how is it.
If Metacello gets ported then you are right.
The tutorial only says: "In addition to #common, there are pre-defined attributes for each of the platforms upon which Metacello runs (#pharo, #squeak, #gemstone and #squeakCommon)."
However FFI (which is definitely limited to Squeak derivates) is also #common and I used it as a template.
Maybe #squeakCommon is right for FFI and ExternalWebBrowser since this is what is used in the seaside, swazoo, ... configs.
Exactly :)
Bye T.
-- Preisknaller: GMX DSL Flatrate für nur 16,99 Euro/mtl.! http://portal.gmx.net/de/go/dsl02
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (2)
-
Mariano Martinez Peck -
Torsten Bergmann