[Pharo-project] Problem in Pharo 1.1 (Igor?) : You have reached the size limit of the changes file.
Hi. I have the following error: 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.' I know this is a known error, but I thought that with Igor's new method trailer this was fixed. Tested in 11355 Thanks Mariano
Ahh, yes, and of course, the size of the .changes file is 32 MB On Thu, May 13, 2010 at 12:12 AM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
Hi. I have the following error:
'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Tested in 11355
Thanks
Mariano
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit. Close this error. And attempt to proceed. :)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
I found this message in CompiledMethod, which should be: CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings if the end of the changes file is approaching a fixed size limit, and finally halt with an error if the limit is reached." ^ SourceFiles checkOKToAdd: size at: filePosition looks like Pharo didn't integrated this method. also, make sure you using a proper source file array.. SourceFiles class == ExpandedSourceFileArray On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. Â And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
oops Igor do you have more information? how do we do that? Stef
I found this message in CompiledMethod, which should be:
CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings if the end of the changes file is approaching a fixed size limit, and finally halt with an error if the limit is reached."
^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper source file array..
SourceFiles class == ExpandedSourceFileArray
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 13 May 2010 10:33, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk. As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry. I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
Stef
I found this message in  CompiledMethod, which should be:
CompiledMethod>>checkOKToAdd: size at: filePosition    "Issue several warnings if the end of the changes file is approaching    a fixed size limit, and finally halt with an error if the limit is reached."
   ^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper  source file array..
SourceFiles class == ExpandedSourceFileArray
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error.  Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. Â And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
Basically, i would remove the old cruft in SourceFileArray and all paranoia about reaching size limit, and leave only a fresh implementation (ExpandedSourceFileArray). I don't see why someone would want to revert to old behavior. On 13 May 2010 10:56, Igor Stasenko <siguctua@gmail.com> wrote:
On 13 May 2010 10:33, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
Stef
I found this message in  CompiledMethod, which should be:
CompiledMethod>>checkOKToAdd: size at: filePosition    "Issue several warnings if the end of the changes file is approaching    a fixed size limit, and finally halt with an error if the limit is reached."
   ^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper  source file array..
SourceFiles class == ExpandedSourceFileArray
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error.  Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. Â And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
:) But yes if people send code for that it will be the first item for 1.2 :) We want more :) Have source of published pharo version in a large database :) Stef On May 13, 2010, at 10:01 AM, Igor Stasenko wrote:
Basically, i would remove the old cruft in SourceFileArray and all paranoia about reaching size limit, and leave only a fresh implementation (ExpandedSourceFileArray). I don't see why someone would want to revert to old behavior.
On 13 May 2010 10:56, Igor Stasenko <siguctua@gmail.com> wrote:
On 13 May 2010 10:33, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
Stef
I found this message in CompiledMethod, which should be:
CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings if the end of the changes file is approaching a fixed size limit, and finally halt with an error if the limit is reached."
^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper source file array..
SourceFiles class == ExpandedSourceFileArray
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
this is exactly the same in pharo and squeak trunk
CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings if the end of the changes file is approaching a fixed size limit, and finally halt with an error if the limit is reached."
^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper source file array..
SourceFiles class == ExpandedSourceFileArray
SourceFiles class -> ExpandedSourceFileArray I integrated the squeak squeak and they are all green. so I'm puzzled
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 13 May 2010 20:27, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
this is exactly the same in pharo and squeak trunk
Huh? In Pharo-1.1.-11343 CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings as the end of the changes file approaches its limit, and finally halt with an error when the end is reached." | fileSizeLimit margin | fileSizeLimit := 16r2000000. 3 to: 1 by: -1 do: [:i | margin := i*100000. (filePosition + size + margin) > fileSizeLimit ifTrue: [(filePosition + margin) > fileSizeLimit ifFalse: [self inform: 'WARNING: your changes file is within ' , margin printString , ' characters of its size limit. You should take action soon to reduce its size. You may proceed.']] ifFalse: [^ self]]. (filePosition + size > fileSizeLimit) ifFalse: [^ self]. self error: 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
CompiledMethod>>checkOKToAdd: size at: filePosition    "Issue several warnings if the end of the changes file is approaching    a fixed size limit, and finally halt with an error if the limit is reached."
   ^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper  source file array..
SourceFiles class == ExpandedSourceFileArray
SourceFiles class     ->  ExpandedSourceFileArray
I integrated the squeak squeak and they are all green. so I'm puzzled
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
 'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error.  Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. Â And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
ok I thought that we should change that openSourceFiles self imageName = LastImageName ifFalse: ["Reset the author full name to blank when the image gets moved" LastImageName := self imageName. Author fullName: '']. self checkAndOpenSourcesAndChanges. StandardSourceFileArray install Stef On May 13, 2010, at 9:56 AM, Igor Stasenko wrote:
On 13 May 2010 10:33, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
Stef
I found this message in CompiledMethod, which should be:
CompiledMethod>>checkOKToAdd: size at: filePosition "Issue several warnings if the end of the changes file is approaching a fixed size limit, and finally halt with an error if the limit is reached."
^ SourceFiles checkOKToAdd: size at: filePosition
looks like Pharo didn't integrated this method.
also, make sure you using a proper source file array..
SourceFiles class == ExpandedSourceFileArray
On 13 May 2010 03:10, Igor Stasenko <siguctua@gmail.com> wrote:
2010/5/13 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi. I have the following error:
'You have reached the size limit of the changes file. You must take action now to reduce it. Close this error. Do not attempt to proceed.'
I know this is a known error, but I thought that with Igor's new method trailer this was fixed.
Seems like a leftovers of old stuff, with precautions once you reaching the size limit.
Close this error. And attempt to proceed.
:)
Tested in 11355
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size. Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;) Dave
thanks david for the advice. I will check that but right now I have several other pending item on non pharo stuff. Stef On May 13, 2010, at 1:17 PM, David T. Lewis wrote:
On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size.
Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;)
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Thu, May 13, 2010 at 1:17 PM, David T. Lewis <lewis@mail.msen.com> wrote:
On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size.
Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;)
Thanks Dave. In my case, I accidently did something similar: I installed Seaside 3.0 a couple of times: Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfSeaside'; load. And then evaluate: ConfigurationOfSeaside project latestVersion load: #( 'Seaside 3.0' 'Magritte2' 'Pier2' 'Pier2 AddOns' ). There will be some errors and deprecated...just proceed them as this is only to increase the .changes Cheers Mariano Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
thanks for the idea
Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfSeaside'; load.
And then evaluate:
ConfigurationOfSeaside project latestVersion load: #( 'Seaside 3.0' 'Magritte2' 'Pier2' 'Pier2 AddOns' ).
There will be some errors and deprecated...just proceed them as this is only to increase the .changes
Cheers
Mariano
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
mariano i just released a fix could you stress the system? Stef On May 13, 2010, at 2:31 PM, Mariano Martinez Peck wrote:
On Thu, May 13, 2010 at 1:17 PM, David T. Lewis <lewis@mail.msen.com> wrote: On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size.
Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;)
Thanks Dave. In my case, I accidently did something similar: I installed Seaside 3.0 a couple of times:
Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfSeaside'; load.
And then evaluate:
ConfigurationOfSeaside project latestVersion load: #( 'Seaside 3.0' 'Magritte2' 'Pier2' 'Pier2 AddOns' ).
There will be some errors and deprecated...just proceed them as this is only to increase the .changes
Cheers
Mariano
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Thu, May 13, 2010 at 8:26 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
mariano
i just released a fix could you stress the system?
wiiiiiii My .changes is now 36MB. It seems to work ok.
Stef
On May 13, 2010, at 2:31 PM, Mariano Martinez Peck wrote:
On Thu, May 13, 2010 at 1:17 PM, David T. Lewis <lewis@mail.msen.com>
wrote:
On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size.
Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;)
Thanks Dave. In my case, I accidently did something similar: I installed Seaside 3.0 a couple of times:
Gofer new squeaksource: 'MetacelloRepository'; package: 'ConfigurationOfSeaside'; load.
And then evaluate:
ConfigurationOfSeaside project latestVersion load: #( 'Seaside 3.0' 'Magritte2' 'Pier2' 'Pier2 AddOns' ).
There will be some errors and deprecated...just proceed them as this is only to increase the .changes
Cheers
Mariano
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
2010/5/14 Mariano Martinez Peck <marianopeck@gmail.com>:
On Thu, May 13, 2010 at 8:26 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
mariano
i just released a fix could you stress the system?
wiiiiiii
My .changes is now 36MB. It seems to work ok.
Don't climb too high , failing would be painfull :)
Stef
On May 13, 2010, at 2:31 PM, Mariano Martinez Peck wrote:
On Thu, May 13, 2010 at 1:17 PM, David T. Lewis <lewis@mail.msen.com> wrote: On Thu, May 13, 2010 at 10:56:17AM +0300, Igor Stasenko wrote:
On 13 May 2010 10:33, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
oops Igor do you have more information? how do we do that?
just replace CompiledMethod>>checkOKToAdd:at:, or take it from trunk.
As far as i can tell, everything else should work fine after that. This is not my contribution , so i don't know all nuances, sorry.
I just made things which allow source pointers > 32Mb to be stored in method trailers, while others put this in use in various places :)
That is probably all that is needed, yes. But be sure to test it. When I did this for trunk, I tested by loading some big Monticello package endlessly in a loop until I got the changes file up to a couple hundred megabytes. You should be able to do this, save and restart the image, browse all old methods is the sources file and so forth. Then modify some method and make sure your change appears at the end of the huge changes file, and that you can revert your most recent change. And of course you should get no warning dialog about the changes file size.
Somebody with a fast computer should volunteer to test this. I recall that it took a long time on my slow laptop computer with slow disk drive ;)
Thanks Dave. In my case, I accidently did something similar: I installed Seaside 3.0 a couple of times:
Gofer new   squeaksource: 'MetacelloRepository';   package: 'ConfigurationOfSeaside';   load.
And then evaluate:
ConfigurationOfSeaside project latestVersion load: #( 'Seaside 3.0' 'Magritte2' 'Pier2' 'Pier2 AddOns' ).
There will be some errors and deprecated...just proceed them as this is only to increase the .changes
Cheers
Mariano
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
On Fri, May 14, 2010 at 02:33:38AM +0300, Igor Stasenko wrote:
2010/5/14 Mariano Martinez Peck <marianopeck@gmail.com>:
On Thu, May 13, 2010 at 8:26 PM, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
mariano
i just released a fix could you stress the system?
wiiiiiii
My .changes is now 36MB. It seems to work ok.
Don't climb too high , failing would be painfull :)
Actually you should keep climbing! The address mapping needs to do strange things on the 32MB boundaries for backward compatibility with the original 32MB address mapping. So keep loading those Seaside packages until you get to at least 150MB or so, just be to sure it keeps working over 32MB -> 64MB -> 96MB -> 128MB ... Dave
On 14 May 2010 04:27, David T. Lewis <lewis@mail.msen.com> wrote:
On Fri, May 14, 2010 at 02:33:38AM +0300, Igor Stasenko wrote:
2010/5/14 Mariano Martinez Peck <marianopeck@gmail.com>:
On Thu, May 13, 2010 at 8:26 PM, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
mariano
i just released a fix could you stress the system?
wiiiiiii
My .changes is now 36MB. It seems to work ok.
Don't climb too high , failing would be painfull :)
Actually you should keep climbing! The address mapping needs to do strange things on the 32MB boundaries for backward compatibility with the original 32MB address mapping. So keep loading those Seaside packages until you get to at least 150MB or so, just be to sure it keeps working over 32MB -> 64MB -> 96MB -> 128MB ...
Isn't it would be wiser to do a simple numerical tests, instead of manually tossing bunch of code into the .changes?
Dave
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
On Fri, May 14, 2010 at 09:58:57PM +0300, Igor Stasenko wrote:
On 14 May 2010 04:27, David T. Lewis <lewis@mail.msen.com> wrote:
On Fri, May 14, 2010 at 02:33:38AM +0300, Igor Stasenko wrote:
2010/5/14 Mariano Martinez Peck <marianopeck@gmail.com>:
On Thu, May 13, 2010 at 8:26 PM, St??phane Ducasse <stephane.ducasse@inria.fr> wrote:
mariano
i just released a fix could you stress the system?
wiiiiiii
My .changes is now 36MB. It seems to work ok.
Don't climb too high , failing would be painfull :)
Actually you should keep climbing! The address mapping needs to do strange things on the 32MB boundaries for backward compatibility with the original 32MB address mapping. So keep loading those Seaside packages until you get to at least 150MB or so, just be to sure it keeps working over 32MB -> 64MB -> 96MB -> 128MB ...
Isn't it would be wiser to do a simple numerical tests, instead of manually tossing bunch of code into the .changes?
Of course numerical tests are needed, which is why I provided the tests in ExpandedSourceFileArrayTest. I'm sure that Pharo will pass all those tests. But the test that did not pass was a real user adding to a real changes file, which triggered a side effect unrelated to the numerical conversion. So I would have to say that skipping the crude manual test was not wiser in this case. Dave
participants (4)
-
David T. Lewis -
Igor Stasenko -
Mariano Martinez Peck -
Stéphane Ducasse