[Pharo-project] RBParser
Hi guys, As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress. Cheers, Gwenael Casaccio
Hi Gwenaël, Where did you publish your change? PharoInbox does not show anyting on RBPArser. Cheers, Alexandre On 29 Oct 2008, at 10:30, Gwenael Casaccio wrote:
Hi guys,
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Cheers, Gwenael Casaccio
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On 29.10.2008, at 10:34, Alexandre Bergel wrote:
Hi Gwenaël,
Where did you publish your change? PharoInbox does not show anyting on RBPArser.
This is not supposed to be in the inbox, as RBParser is not part of Pharo-Core. Marcus
Cheers, Alexandre
On 29 Oct 2008, at 10:30, Gwenael Casaccio wrote:
Hi guys,
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Cheers, Gwenael Casaccio
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news. I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime. Cheers, Lukas -- Lukas Renggli http://www.lukas-renggli.ch
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
I've also discused with stef and marcus and I would like to have only RBToken. I don't know what do you think ? Cheers, Gwenael
gwenael what lukas is implying is that this is important that you publish your work in a place where other people can read it. Stef On Oct 30, 2008, at 10:49 AM, Gwenael Casaccio wrote:
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
I've also discused with stef and marcus and I would like to have only RBToken. I don't know what do you think ?
Cheers, Gwenael
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 10/30/08 12:58 PM, Stéphane Ducasse wrote:
gwenael what lukas is implying is that this is important that you publish your work in a place where other people can read it.
Off course I'll publish it ! I've just asked him about these modifications with the tokens hierarchy. By the way I've made a stupid benchmark between the Parser and RBParser on the entire image and RBParser is 5 sec slower than Parser (122 sec for the RBParser and 117 sec for the Parser)
Stef
On Oct 30, 2008, at 10:49 AM, Gwenael Casaccio wrote:
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
I've also discused with stef and marcus and I would like to have only RBToken. I don't know what do you think ?
Cheers, Gwenael
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
gwenael what lukas is implying is that this is important that you publish your work in a place where other people can read it.
Off course I'll publish it !
I know. What lukas is implying is that if you publish in the RB repository then he will have less problems to merge
I've just asked him about these modifications with the tokens hierarchy.
By the way I've made a stupid benchmark between the Parser and RBParser on the entire image and RBParser is 5 sec slower than Parser (122 sec for the RBParser and 117 sec for the Parser)
Published :) On 10/30/08 1:20 PM, Stéphane Ducasse wrote:
gwenael what lukas is implying is that this is important that you publish your work in a place where other people can read it.
Off course I'll publish it !
I know. What lukas is implying is that if you publish in the RB repository then he will have less problems to merge
I've just asked him about these modifications with the tokens hierarchy.
By the way I've made a stupid benchmark between the Parser and RBParser on the entire image and RBParser is 5 sec slower than Parser (122 sec for the RBParser and 117 sec for the Parser)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
:) Thanks! Stef On Oct 30, 2008, at 1:40 PM, Gwenael Casaccio wrote:
Published :)
On 10/30/08 1:20 PM, Stéphane Ducasse wrote:
gwenael what lukas is implying is that this is important that you publish your work in a place where other people can read it.
Off course I'll publish it !
I know. What lukas is implying is that if you publish in the RB repository then he will have less problems to merge
I've just asked him about these modifications with the tokens hierarchy.
By the way I've made a stupid benchmark between the Parser and RBParser on the entire image and RBParser is 5 sec slower than Parser (122 sec for the RBParser and 117 sec for the Parser)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I've commit a new version I've removed all the RB*Token On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
On Fri, Oct 31, 2008 at 10:42 AM, Gwenael Casaccio <mrgwen@gmail.com> wrote:
I've commit a new version I've removed all the RB*Token
I've loaded your changes, but it seems to break the refactoring browser. All literals (numbers, symbols, true, false, nil, ...) are printed as strings ('123', '#foo', 'true', 'false', ...). Did I forget to load something, or is this a bug? Cheers, Lukas
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli http://www.lukas-renggli.ch
Hi, In fact I've seen the method patch literal in the parser which transformed the literals as strings so as we've strings in the scanner I've take the decision to remove this method and kept the literals as string. And off course I don't have launch the refactorings tests :s Cheers, Gwenael On 11/1/08 10:21 AM, Lukas Renggli wrote:
On Fri, Oct 31, 2008 at 10:42 AM, Gwenael Casaccio<mrgwen@gmail.com> wrote:
I've commit a new version I've removed all the RB*Token
I've loaded your changes, but it seems to break the refactoring browser. All literals (numbers, symbols, true, false, nil, ...) are printed as strings ('123', '#foo', 'true', 'false', ...). Did I forget to load something, or is this a bug?
Cheers, Lukas
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress. Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Hi, I've corrected the problems in the version : AST-Gwenael_Casaccio.161.mcz Cheers, Gwenael On Tue, Nov 4, 2008 at 2:08 PM, Gwenael Casaccio <mrgwen@gmail.com> wrote:
Hi,
In fact I've seen the method patch literal in the parser which transformed the literals as strings so as we've strings in the scanner I've take the decision to remove this method and kept the literals as string. And off course I don't have launch the refactorings tests :s
Cheers, Gwenael
On 11/1/08 10:21 AM, Lukas Renggli wrote:
On Fri, Oct 31, 2008 at 10:42 AM, Gwenael Casaccio<mrgwen@gmail.com> wrote:
I've commit a new version I've removed all the RB*Token
I've loaded your changes, but it seems to break the refactoring browser. All literals (numbers, symbols, true, false, nil, ...) are printed as strings ('123', '#foo', 'true', 'false', ...). Did I forget to load something, or is this a bug?
Cheers, Lukas
On 10/29/08 6:21 PM, Lukas Renggli wrote:
As I've said to you Marcus, I've worked on the RBParser/RBScanner. I've fixed these classes and now you can parse the entire image. At this moment the refactoring is not yet finished but I've made some good progress.
Good news.
I was not aware that you were working on RBParser. Stef told me that you also improved the refactorings. I think you should commit and work on the public repository to get more attention. I guess there were many other changes going on in RB codebase in the meantime.
Cheers, Lukas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (6)
-
Alexandre Bergel -
Gwenael Casaccio -
Gwenaël Casaccio
-
Lukas Renggli -
Marcus Denker -
Stéphane Ducasse