[Pharo-project] ConfigurationOfXMLSupport...
I've just published ConfigurationOfXMLSupport to the MetacelloRepository. It is used by several Pier addons. It _is_ just one package, but since it can be used in a lot of different projects, I thought it was worth adding as a configuration. It is based upon the code in http://www.squeaksource.com/XMLSupport. The test package appears to be several years old and a number of the tests failed, so I didn't include them in this version of the config. So if someone with a little more knowledge about XMLSupport could comment, that would help (hint, hint, Alexandre:). Thanks, Dale
Hi Dale, Thanks for writing ConfigurationOfXMLSupport, I should have done it, but I could not find the time. I consider the package XML-Testing as obsolete. I haven't been able to run it. I think it was useful when Michael begun to develop XML-Parser. But for now, it is rather irrelevant. I added some tests some times ago to not leave this package untested. Maybe I could separate the test from the core if necessary. Cheers, Alexandre NB: Sorry for my late reply, I was on holidays On 7 Feb 2010, at 16:31, Dale Henrichs wrote:
I've just published ConfigurationOfXMLSupport to the MetacelloRepository. It is used by several Pier addons. It _is_ just one package, but since it can be used in a lot of different projects, I thought it was worth adding as a configuration.
It is based upon the code in http://www.squeaksource.com/XMLSupport. The test package appears to be several years old and a number of the tests failed, so I didn't include them in this version of the config.
So if someone with a little more knowledge about XMLSupport could comment, that would help (hint, hint, Alexandre:).
Thanks,
Dale
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
I would be good to make the test of mike running. On Feb 16, 2010, at 11:27 PM, Alexandre Bergel wrote:
Hi Dale,
Thanks for writing ConfigurationOfXMLSupport, I should have done it, but I could not find the time. I consider the package XML-Testing as obsolete. I haven't been able to run it. I think it was useful when Michael begun to develop XML-Parser. But for now, it is rather irrelevant. I added some tests some times ago to not leave this package untested. Maybe I could separate the test from the core if necessary.
Cheers, Alexandre
NB: Sorry for my late reply, I was on holidays
On 7 Feb 2010, at 16:31, Dale Henrichs wrote:
I've just published ConfigurationOfXMLSupport to the MetacelloRepository. It is used by several Pier addons. It _is_ just one package, but since it can be used in a lot of different projects, I thought it was worth adding as a configuration.
It is based upon the code in http://www.squeaksource.com/XMLSupport. The test package appears to be several years old and a number of the tests failed, so I didn't include them in this version of the config.
So if someone with a little more knowledge about XMLSupport could comment, that would help (hint, hint, Alexandre:).
Thanks,
Dale
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I also used it for several projects without problems. Cheers, Doru On 17 Feb 2010, at 12:09, George Herolyants wrote:
2010/2/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
I would be good to make the test of mike running.
It runs without much problems. I did it. But a lot of the tests fail or execute with errors. I don't know if it's supposed to be so or not.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- www.tudorgirba.com "Speaking louder won't make the point worthier."
I am not sure to understand. Running XML-Testing in my image results in 835 run, 789 errors. These tests rely on external files that I have no clue where to find them. Cheers, Alexandre On 17 Feb 2010, at 08:12, Tudor Girba wrote:
I also used it for several projects without problems.
Cheers, Doru
On 17 Feb 2010, at 12:09, George Herolyants wrote:
2010/2/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
I would be good to make the test of mike running.
It runs without much problems. I did it. But a lot of the tests fail or execute with errors. I don't know if it's supposed to be so or not.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- www.tudorgirba.com
"Speaking louder won't make the point worthier."
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Can you give the names of the files because I should have them on my disc :) Stef On Feb 17, 2010, at 8:40 PM, Alexandre Bergel wrote:
I am not sure to understand. Running XML-Testing in my image results in 835 run, 789 errors. These tests rely on external files that I have no clue where to find them.
Cheers, Alexandre
On 17 Feb 2010, at 08:12, Tudor Girba wrote:
I also used it for several projects without problems.
Cheers, Doru
On 17 Feb 2010, at 12:09, George Herolyants wrote:
2010/2/17 Stéphane Ducasse <stephane.ducasse@inria.fr>:
I would be good to make the test of mike running.
It runs without much problems. I did it. But a lot of the tests fail or execute with errors. I don't know if it's supposed to be so or not.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- www.tudorgirba.com
"Speaking louder won't make the point worthier."
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
2010/2/18 Stéphane Ducasse <stephane.ducasse@inria.fr>:
Can you give the names of the files because I should have them on my disc :)
Of course: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip. Actually this is mentioned in the class comment of the XMLParserTests from the XML-Testing package. There are also instructions on how to configure your environment to use these files. Here's a part of it: "XMLParserTests uses XML tests by James Clark, Sun, and OASIS. These tests are distributed as test suite by OASIS at: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip This link can be found on the page: http://www.oasis-open.org/committees/xmltest/testsuite.htm. To run the test suite you must: Install the OASIS test suite on your hard drive Edit the class method baseTestDirectory to include the full path of the directory containing the OASIS test suite. install Sunit. Run the tests the standard way: TestRunner open" Actually the page mentioned doesn't exist anymore AFAICS, because they have the Second Edition of this test suite now: http://www.oasis-open.org/committees/xml-conformance/xml-test-suite.shtml and the test suite itself: http://www.oasis-open.org/committees/xml-conformance/suite-v1se/xmlconf-2001...
thanks Indded I found xmlconf.zip on my disc now what would be great is to be able to have such files used by the tests. Stef On Feb 18, 2010, at 12:34 PM, George Herolyants wrote:
2010/2/18 Stéphane Ducasse <stephane.ducasse@inria.fr>:
Can you give the names of the files because I should have them on my disc :)
Of course: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip. Actually this is mentioned in the class comment of the XMLParserTests from the XML-Testing package. There are also instructions on how to configure your environment to use these files. Here's a part of it:
"XMLParserTests uses XML tests by James Clark, Sun, and OASIS. These tests are distributed as test suite by OASIS at: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip This link can be found on the page: http://www.oasis-open.org/committees/xmltest/testsuite.htm.
To run the test suite you must: Install the OASIS test suite on your hard drive Edit the class method baseTestDirectory to include the full path of the directory containing the OASIS test suite. install Sunit. Run the tests the standard way: TestRunner open"
Actually the page mentioned doesn't exist anymore AFAICS, because they have the Second Edition of this test suite now: http://www.oasis-open.org/committees/xml-conformance/xml-test-suite.shtml and the test suite itself: http://www.oasis-open.org/committees/xml-conformance/suite-v1se/xmlconf-2001...
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Michael sent me the files yesterday. I will see how to include them in the XML-Testing package. Cheers, Alexandre On 18 Feb 2010, at 08:34, George Herolyants wrote:
2010/2/18 Stéphane Ducasse <stephane.ducasse@inria.fr>:
Can you give the names of the files because I should have them on my disc :)
Of course: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip . Actually this is mentioned in the class comment of the XMLParserTests from the XML-Testing package. There are also instructions on how to configure your environment to use these files. Here's a part of it:
"XMLParserTests uses XML tests by James Clark, Sun, and OASIS. These tests are distributed as test suite by OASIS at: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip This link can be found on the page: http://www.oasis-open.org/committees/xmltest/testsuite.htm.
To run the test suite you must: Install the OASIS test suite on your hard drive Edit the class method baseTestDirectory to include the full path of the directory containing the OASIS test suite. install Sunit. Run the tests the standard way: TestRunner open"
Actually the page mentioned doesn't exist anymore AFAICS, because they have the Second Edition of this test suite now: http://www.oasis-open.org/committees/xml-conformance/xml-test-suite.shtml and the test suite itself: http://www.oasis-open.org/committees/xml-conformance/suite-v1se/xmlconf-2001...
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
cool!!! This is why I got them on my disc :) Stef On Feb 18, 2010, at 1:28 PM, Alexandre Bergel wrote:
Michael sent me the files yesterday. I will see how to include them in the XML-Testing package.
Cheers, Alexandre
On 18 Feb 2010, at 08:34, George Herolyants wrote:
2010/2/18 Stéphane Ducasse <stephane.ducasse@inria.fr>:
Can you give the names of the files because I should have them on my disc :)
Of course: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip . Actually this is mentioned in the class comment of the XMLParserTests from the XML-Testing package. There are also instructions on how to configure your environment to use these files. Here's a part of it:
"XMLParserTests uses XML tests by James Clark, Sun, and OASIS. These tests are distributed as test suite by OASIS at: http://www.oasis-open.org/committees/xmltest/xmlconf-19990712.zip This link can be found on the page: http://www.oasis-open.org/committees/xmltest/testsuite.htm.
To run the test suite you must: Install the OASIS test suite on your hard drive Edit the class method baseTestDirectory to include the full path of the directory containing the OASIS test suite. install Sunit. Run the tests the standard way: TestRunner open"
Actually the page mentioned doesn't exist anymore AFAICS, because they have the Second Edition of this test suite now: http://www.oasis-open.org/committees/xml-conformance/xml-test-suite.shtml and the test suite itself: http://www.oasis-open.org/committees/xml-conformance/suite-v1se/xmlconf-2001...
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
2010/2/17 Alexandre Bergel <alexandre@bergel.eu>:
I am not sure to understand. Running XML-Testing in my image results in 835 run, 789 errors. These tests rely on external files that I have no clue where to find them.
Running these tests with required files gives the following results: 835 run, 303 passes, 0 expected failures, 481 failures, 51 errors, 0 unexpected passes And for the Second Edition of the test suite: 835 run, 300 passes, 0 expected failures, 481 failures, 54 errors, 0 unexpected passes
2010/2/18 George Herolyants <george.herolyants@gmail.com>:
Running these tests with required files gives the following results: 835 run, 303 passes, 0 expected failures, 481 failures, 51 errors, 0 unexpected passes
And for the Second Edition of the test suite: 835 run, 300 passes, 0 expected failures, 481 failures, 54 errors, 0 unexpected passes
Oh, sorry. Running them on the latest version of XML-Parser gives 835 run, 291 passes, 0 expected failures, 493 failures, 51 errors, 0 unexpected passes and 835 run, 288 passes, 0 expected failures, 493 failures, 54 errors, 0 unexpected passes respectively.
Btw, how can I contribute to XML-Support? Is there some process? Because I've created two issues on bugs.squeak.org a month ago and still don't know if they were noticed or not?
Hi George, I will be delighted to incorporate some improvements in XML-Support. Currently, the simplest way to contribute is to send me an email with the location of some improvement. I look at them, and if they come with unit tests and they make sense to me, then I include them. Someone deeply committed will become administrator of the squeaksource repository. I saw your fix (0007441), I will look at them right after sending this email. I haven't checked bugs.squeak.org for a long time, but apparently the last improvements proposed by jaayer@zoho.com (thanks for this!) includes some of the change proposed on bugs.squeak.org (e.g., 0007465). The comments of the new revision are included below. -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= * All searching and enumerating methods have been moved from XMLNode to XMLNodeWithElements. Unless you can think of a scenario where it would make sense to send any of them to a string or PI node, I think this is both a safe and sensible move. * XMLNodeWithElements no longer contains an "elementsAndContents" collection. Instead it has a single "nodes" OrderedCollection that contains all child nodes in the order in which they appeared. The collection returned by #elementsAndContents (and enumerated via #elementsAndContentsDo:) is recreated using #nodes. * #addElement: is now just for elements, and #addNode can be used for everything else (#addElement can still handle non-element nodes, though). #removeNode: and #removeElement: have also been added. Since, for backwards compatibility, the #add* methods don't return the object added, neither will the #remove* method return that which was removed. * Because the costly depth-first traversing #firstTag* and #tagsNamed* methods send #elementsDo: so many times, it makes sense to speed-up #elementsDo: by having it enumerate a separate collection just containing elements; thus, an "elements" collection has been added for that purpose. The repetitive identity checks in the XMLElement versions of those methods have been moved into a single #isNamed: method, which expects a symbol but can also handle strings by sending its argument #asSymbol before making #== comparisons. (#asSymbol is free for symbols, so you only pay if you use strings to specify tag names.) * #tagsNamed:ifReceiverDo:, despite what its name implies (the plural "tags"), does no searching/enumeration. Outside of the implementations of other #tagsNamed:* messages, I doubt anyone uses this, so I have renamed it #ifNamed:do:. * #tagsNamed:ifReceiverOrChildDo: does not work. The XMLElement version evaluates the block if it is so named and then invokes the superclass version of #tagsNamed:ifReceiverDo:, which is an empty method. Since it doesn't work and is ridiculously named, I have removed it. * #tagsNamed:ifReceiverDoAndRecurse: is, oddly enough, exactly equivalent to #tagsNamed:do:. I have removed the XMLElement version and reimplemented the XMLNode(WithElements) version to just send #tagsNamed:do: (although I'd prefer to remove it altogether). * XMLNodeWithElements has a new instance variable: "elementsDictionary," an IndentityDictionay where keys are the qualified and unqualified names of child elements and values are OrderedCollections of so-named elements. This makes #elementAt: have O(1) complexity rather than O(n) and a->b->c traversal have O(n) complexity (where n is the number of nodes counting the root, the target, and all ancestors between) rather than the previous worst-case of O(n^2). This comes at the cost of additional memory and time to add/ remove elements. You can rewrite Pastell accessors in terms of #elementsAt: and #elementAt:. * The #contentsDo: and #elementsAndContentsDo: messages can now only be sent to XMLElements. It makes no sense to send them to documents or other kinds of nodes, as no other kind of node has text content. * I moved #parent and #parent: out of XMLNodeWithElements and put them in XMLNode instead, as every node in the DOM tree save the root has a parent. They actually work now, too, meaning that "((XMLDOMParser parseDocumentFrom: '<p>foo<b>bar</b></p>' readStream) firstTagNamed: #b) parent" will return the "p" element, not nil as it would before. * How often have you sent #parseDocumentFrom: with an XML string as its argument (instead of a stream) and gotten a "message not understood" error? XMLDOMParser's #parseDocumentFrom:useNamespaces: method now sends #readStream to "aStream" if it is not already a stream, so you will no longer receive such errors. * #addEntity:value: has been removed. It has not been touched in ten years and sends a message (#entities) that is not understood. * Confusing "entityName" parameter names in methods expecting element/ tag names were replaced with "aSymbol." * (This package also contains the #=/#hash methods submitted as a feature addition to bugs.squeak.) Lastly, this codebase has had too many hands touching it and looks too inconsistent. I suggest configuring your formatter like so: RBConfigurableFormatter maxLineLength: 80; newLinesAfterMethodPattern: 2; newLinesAfterMethodComment: 2; retainBlankLinesBetweenStatements: true; stringInsideBlocks: ''. And then reformatting XMLNode and its subclasses -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Cheers, Alexandre On 17 Feb 2010, at 08:18, George Herolyants wrote:
Btw, how can I contribute to XML-Support? Is there some process? Because I've created two issues on bugs.squeak.org a month ago and still don't know if they were noticed or not?
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Hi George, I included your change found on http://bugs.squeak.org/view.php? id=7441 in XML-Parser-Alexandre_Bergel.27 The test of CAnalyzer and Adore (which intensively use XMLParser) are ok. Thanks for your improvement. Cheers, Alexandre On 17 Feb 2010, at 08:18, George Herolyants wrote:
Btw, how can I contribute to XML-Support? Is there some process? Because I've created two issues on bugs.squeak.org a month ago and still don't know if they were noticed or not?
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
2010/2/17 Alexandre Bergel <alexandre@bergel.eu>:
Hi George,
I included your change found on http://bugs.squeak.org/view.php? id=7441 in XML-Parser-Alexandre_Bergel.27 The test of CAnalyzer and Adore (which intensively use XMLParser) are ok.
Thanks for your improvement.
Thank you! Glad to help. :) George
participants (5)
-
Alexandre Bergel -
Dale Henrichs -
George Herolyants -
Stéphane Ducasse -
Tudor Girba