Reviewing Association and LookupKey
Three questions that might end up in issues: 1. Is there a reason why Association(class)>>#key:value: looks like key: newKey value: newValue ... ^(super key: newKey) value: newValue instead of key: newKey value: newValue ... ^(self key: newKey) value: newValue in case #key: will be redefined in Association class 2. What is the reason for LookupKey>>#canAssign. Method stamp says ajh from 2002. This message is not sent and I guess we can remove/deprecate it. 3. Similar question for LookupKey>>#isSpecialReadBinding from ar in 2003 This message is not sent and I guess we can remove/deprecate it. Comments welcomed! Thanks T.
On 12 May 2015, at 20:31, Torsten Bergmann <astares@gmx.de> wrote:
Three questions that might end up in issues:
1. Is there a reason why Association(class)>>#key:value: looks like
key: newKey value: newValue ... ^(super key: newKey) value: newValue
instead of
key: newKey value: newValue ... ^(self key: newKey) value: newValue
in case #key: will be redefined in Association class
Maybe someone once thought, counting byte codes, that this was slightly faster, because the super implementation bypasses #initialize doing a #basicNew instead of a #new ?
2. What is the reason for LookupKey>>#canAssign. Method stamp says ajh from 2002. This message is not sent and I guess we can remove/deprecate it.
Probably.
3. Similar question for LookupKey>>#isSpecialReadBinding from ar in 2003 This message is not sent and I guess we can remove/deprecate it.
Probably.
Comments welcomed!
Thanks T.
Le 12/5/15 20:31, Torsten Bergmann a écrit :
Three questions that might end up in issues:
1. Is there a reason why Association(class)>>#key:value: looks like
key: newKey value: newValue ... ^(super key: newKey) value: newValue
instead of
key: newKey value: newValue ... ^(self key: newKey) value: newValue
in case #key: will be redefined in Association class
2. What is the reason for LookupKey>>#canAssign. Method stamp says ajh from 2002. This message is not sent and I guess we can remove/deprecate it.
Could you open a bug entry for point 2 and 3 so that we do not forget to clean. These methods are left over an experience to have read-only bindings.
3. Similar question for LookupKey>>#isSpecialReadBinding from ar in 2003 This message is not sent and I guess we can remove/deprecate it.
Comments welcomed!
Thanks T.
participants (3)
-
stepharo -
Sven Van Caekenberghe -
Torsten Bergmann