[Pharo-project] Load OB in Pharo 1.2
Hi Lukas. Trying to evaluate: (ConfigurationOfOmniBrowser project version: '1.1-baseline') load: 'Core RB' I am trying to load OB and RB in Pharo 1.2 I found still refernces to Preferences and some other problems. I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :) Thanks Mariano
Sorry...found another one. In MenuMorph >> add: label target: anObject selector: aSelector enabled: aBoolean icon: aSymbol you do Preferences menuWithIcons but should be UITheme currentSettings menuWithIcons cheers mariano On Tue, Aug 17, 2010 at 3:53 PM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load: 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Sorry...found another one.
In MenuMorph >> add: label target: anObject selector: aSelector enabled: aBoolean icon: aSymbol
you do Preferences menuWithIcons
but should be UITheme currentSettings menuWithIcons
Looks like I forgot to commit a whole batch of changes: Name: OB-Morphic-lr.132 Author: lr Time: 17 August 2010, 5:38:15 pm UUID: b03368be-fe23-445b-9586-f16372e5fc8b Ancestors: OB-Morphic-lr.131 - removed all references to Preferences Name: OB-Shout-lr.7 Author: lr Time: 17 August 2010, 5:38:45 pm UUID: b14c055a-6430-4772-9c89-f5cc890681fe Ancestors: OB-Shout-lr.6 - removed all references to Preferences Name: ECompletion-lr.135 Author: lr Time: 17 August 2010, 5:39:14 pm UUID: 783fd270-7bd5-43d7-abe6-a750dc6f869b Ancestors: ECompletion-lr.134 - improved the settings placement -- Lukas Renggli www.lukas-renggli.ch
I cannot integrate that change-set because it breaks OB in Pharo 1.1. PluggableButtonMorphPlus was never deprecated and now you say it just disappeared? :-( Lukas 2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load:Â 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
Anyway, don't bother. I fixed it in OB-Morphic-lr.133. This should work in any version: Name: OB-Morphic-lr.133 Author: lr Time: 17 August 2010, 6:04:59 pm UUID: 728befb5-2f47-4d92-a6c3-3f1ca44bc21f Ancestors: OB-Morphic-lr.132 - don't use PluggableButtonMorphPlus, as it doesn't work anymore in upcoming versions On 17 August 2010 17:41, Lukas Renggli <renggli@gmail.com> wrote:
I cannot integrate that change-set because it breaks OB in Pharo 1.1.
PluggableButtonMorphPlus was never deprecated and now you say it just disappeared? :-(
Lukas
2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load:Â 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
-- Lukas Renggli www.lukas-renggli.ch
Yes lukas we cleaned and merged all the *Plus classes are now in their superclass. and for classes we do not really have a nice deprecate mechanism. Stef
I cannot integrate that change-set because it breaks OB in Pharo 1.1.
PluggableButtonMorphPlus was never deprecated and now you say it just disappeared? :-(
Lukas
2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load: 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 17 August 2010 18:43, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Yes lukas we cleaned and merged all the *Plus classes are now in their superclass. and for classes we do not really have a nice deprecate mechanism.
Why can't you put a deprecated warning into basicNew? That would be really helpful, because otherwise this will always cause troubles like this. Lukas -- Lukas Renggli www.lukas-renggli.ch
On Tue, Aug 17, 2010 at 5:41 PM, Lukas Renggli <renggli@gmail.com> wrote:
I cannot integrate that change-set because it breaks OB in Pharo 1.1.
PluggableButtonMorphPlus was never deprecated and now you say it just disappeared? :-(
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released. thanks for your commits
Lukas
2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load: 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ... Lukas
thanks for your commits
Lukas
2010/8/17 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi Lukas. Trying to evaluate:
(ConfigurationOfOmniBrowser project version: '1.1-baseline') load: 'Core RB'
I am trying to load OB and RB in Pharo 1.2
I found still refernces to Preferences and some other problems.
I attach a changeset to fix the ones I found. If you want to check them lukas would be nice :)
Thanks
Mariano
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it. (2 pages of philosophical ramblings deleted... I should start a blog..) Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use. Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
    Marcus
-- Marcus Denker  -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-) Regards, Gary ----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2 On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use. Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name. On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
 Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name.
can it be that this class has a var that we pushed up the hierarchy? At least when I try to load OB in 1.2, I get an error message like that...
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <marcus.denker@inria.fr>wrote:
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name.
can it be that this class has a var that we pushed up the hierarchy? At least when I try to load OB in 1.2, I get an error message like that...
Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'. So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same. Cheers Mariano
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Well, I just call the variable 'enabledPlus' then :-( Lukas On Tuesday, August 17, 2010, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name.
can it be that this class has a var that we pushed up the hierarchy? At least when I try to load OB in 1.2, I get an error message like that...
Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
Cheers
Mariano
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
 Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker  -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo
-- Lukas Renggli www.lukas-renggli.ch
Or you would keep the empty but deprecated class PluggableButtonMorphPlus in the image and make everybody happy :-) On Tuesday, August 17, 2010, Lukas Renggli <renggli@gmail.com> wrote:
Well, I just call the variable 'enabledPlus' then :-(
Lukas
On Tuesday, August 17, 2010, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name.
can it be that this class has a var that we pushed up the hierarchy? At least when I try to load OB in 1.2, I get an error message like that...
Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
Cheers
Mariano
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
 Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________--
Lukas Renggli www.lukas-renggli.ch
-- Lukas Renggli www.lukas-renggli.ch
On Aug 17, 2010, at 11:16 PM, Lukas Renggli wrote:
Or you would keep the empty but deprecated class PluggableButtonMorphPlus in the image and make everybody happy :-)
Yes, let's do that... Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
Has this been resolved? I still get an error saying that PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define homonymous instance variables. Niko On Wed, Aug 18, 2010 at 9:04 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 11:16 PM, Lukas Renggli wrote:
Or you would keep the empty but deprecated class PluggableButtonMorphPlus in the image and make everybody happy :-)
Yes, let's do that...
    Marcus
-- Marcus Denker  -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- http://scg.unibe.ch/staff/Schwarz twitter.com/nes1983 Tel: +41 076 235 8683
On Aug 24, 2010, at 7:49 PM, Niko Schwarz wrote:
Has this been resolved? I still get an error saying that PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define homonymous instance variables.
Works now Gofer new squeaksource: 'rb'; package: 'AST-Core'; package: 'AST-Semantic'; package: 'Refactoring-Core'; package: 'Refactoring-Spelling'; load. Gofer new renggli: 'omnibrowser'; package: 'OmniBrowser'; package: 'OB-Standard'; package: 'OB-Morphic'; package: 'OB-Refactory'; package: 'OB-Regex'; load. -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
Has this been resolved? I still get an error saying that PluggableButtonMorphPlus and OBPluggableButtonMorphPlus define homonymous instance variables.
Works now
Gofer new    squeaksource: 'rb';    package: 'AST-Core';    package: 'AST-Semantic';    package: 'Refactoring-Core';    package: 'Refactoring-Spelling';    load. Gofer new    renggli: 'omnibrowser';    package: 'OmniBrowser';    package: 'OB-Standard';    package: 'OB-Morphic';    package: 'OB-Refactory';    package: 'OB-Regex';    load.
No, it has not been resolved. Just don't load the offending packages Shout and eCompletion and then everything works. Lukas -- Lukas Renggli www.lukas-renggli.ch
On Tue, Aug 17, 2010 at 11:12 PM, Lukas Renggli <renggli@gmail.com> wrote:
Well, I just call the variable 'enabledPlus' then :-(
I don't understand....did you do it or not? I don't see the commit... thanks anyway
Lukas
On Tuesday, August 17, 2010, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
On Tue, Aug 17, 2010 at 8:50 PM, Marcus Denker <marcus.denker@inria.fr>
wrote:
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. Now I had to duplicate the whole class in OB with a uniue name.
can it be that this class has a var that we pushed up the hierarchy? At
least
when I try to load OB in 1.2, I get an error message like that...
Yes, now OB doesn't load in 1.2 because OBPluggableButtonMorph extends from PluggableButtonMorph it seems that now both of them has an instVar called 'enable'.
So...the same problem as Shout loading in 1.2......the simplest solution seems to rename one of the isntVar and once they migrate to 1.2 use the same.
Cheers
Mariano
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated.
But how? We could let the subclass empty in this case (is it what you mean) but when we are doing refactoring like changing iv it may not work. We could not really let the classes in the system. I have the impression that having branch at the tool level is something that we cannot avoid.
Now I had to duplicate the whole class in OB with a uniue name.
??
On Tuesday, August 17, 2010, Gary Chambers <gazzaguru2@btinternet.com> wrote:
Sorry, that was Stef and I at Camp Smalltalk. Did feel good to be rid of XYZPlus classes though ;-)
Regards, Gary
----- Original Message ----- From: "Lukas Renggli" <renggli@gmail.com> To: <Pharo-project@lists.gforge.inria.fr> Sent: Tuesday, August 17, 2010 7:07 PM Subject: Re: [Pharo-project] Load OB in Pharo 1.2
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
Lukas
(2 pages of philosophical ramblings deleted... I should start a blog..)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 17.08.2010 21:14, Stéphane Ducasse wrote:
On Aug 17, 2010, at 8:28 PM, Lukas Renggli wrote:
Removing them is cool, but there should be a grace period where they are deprecated. But how? We could let the subclass empty in this case (is it what you mean) but when we are doing refactoring like changing iv it may not work. We could not really let the classes in the system.
I have the impression that having branch at the tool level is something that we cannot avoid. You can do the same as for CrLFFileStream, keep the empty class, but reroute any instantiations to super which now contains its functionality. Like Lukas said, deprecate Pluggable*Plus class >> basicNew in 1.2. Then remove them in 1.3.
Cheers, Henry
On Aug 17, 2010, at 8:07 PM, Lukas Renggli wrote:
On Tuesday, August 17, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
Yeah that make sense, but I cannot maintain code that I can't use.
So I guess I should maintain a branch for 1.2... I really want to use it. And we need at some point to think about what to do for the browser. do we really maintain two? Even if OB is not "the browser to end all browsers", isn't it good enough to replace the old one for now? Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
On Aug 17, 2010, at 7:55 PM, Marcus Denker wrote:
On Aug 17, 2010, at 7:31 PM, Lukas Renggli wrote:
Thanks Lukas. I wasn't who remove that class neither who didn't deprecated. I am just trying to start building Dev images from now...otherwise, we will have to wait a lot of time once the core is released.
I think there must be a delay between the release of the core and the non-core images. I don't see how that can otherwise work. Of course it makes sense to have some incremental adaption already upfront ...
Hmm... one thing is clear: I want to use Refactoring and especially the Code Critique tool on 1.2. So I need to somehow load it.
(2 pages of philosophical ramblings deleted... I should start a blog..)
No rambling blog are boring :)
Marcus
-- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Aug 17, 2010, at 8:08 PM, Stéphane Ducasse wrote:
(2 pages of philosophical ramblings deleted... I should start a blog..)
No rambling blog are boring :)
No need to read it... maybe I could just write them and then delete them? Would help, too. Marcus -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.
(2 pages of philosophical ramblings deleted... I should start a blog..)
No rambling blog are boring :)
No need to read it... maybe I could just write them and then delete them? Would help, too.
Yes people call that catharsis :) It is good to express stuff. I delete also mails I would like to send :) Stef
participants (7)
-
Gary Chambers -
Henrik Sperre Johansen -
Lukas Renggli -
Marcus Denker -
Mariano Martinez Peck -
Niko Schwarz -
Stéphane Ducasse