[Pharo-project] Renaming instance variable
Renaming an instance variable using the refactoring command raises an error. The method "RBScanner class>>isVariable:" triggers the error. ISSUE #472 Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Renaming an instance variable using the refactoring command raises an error. The method "RBScanner class>>isVariable:" triggers the error.
What kind of error? When exactly does it happen? Is this with OB-Refactory? Lukas -- Lukas Renggli http://www.lukas-renggli.ch
In a 10204, using OBAlpha (I did not try with OB). I created a class FooBar with a variable 'abc'. Right click on the class, 'Refactor instance variable / rename'. What ever the new name, I get an error. Alexandre On 3 Feb 2009, at 08:31, Lukas Renggli wrote:
Renaming an instance variable using the refactoring command raises an error. The method "RBScanner class>>isVariable:" triggers the error.
What kind of error? When exactly does it happen? Is this with OB- Refactory?
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
In a 10204, using OBAlpha (I did not try with OB).
What is OBAlpha? What is the difference to OB?
I created a class FooBar with a variable 'abc'. Right click on the class, 'Refactor instance variable / rename'. What ever the new name, I get an error.
What kind of Error? Can you provide a stack-trace? I cannot reproduce. Lukas -- Lukas Renggli http://www.lukas-renggli.ch
It looks like the load scripts in Pharo load a very old and incompatible version of the Refactoring Engine. The package RefactoringEngine is deprecated for a long time and shouldn't be used anymore. Load Refactoring-Core instead. Also I would load AST-lr.160, newer versions of that package do not work in my images. Lukas On Tue, Feb 3, 2009 at 9:16 AM, Lukas Renggli <renggli@gmail.com> wrote:
In a 10204, using OBAlpha (I did not try with OB).
What is OBAlpha? What is the difference to OB?
I created a class FooBar with a variable 'abc'. Right click on the class, 'Refactor instance variable / rename'. What ever the new name, I get an error.
What kind of Error? Can you provide a stack-trace? I cannot reproduce.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
-- Lukas Renggli http://www.lukas-renggli.ch
On Tue, Feb 3, 2009 at 9:35 AM, Lukas Renggli <renggli@gmail.com> wrote:
It looks like the load scripts in Pharo load a very old and incompatible version of the Refactoring Engine.
I already told them to avoid using their own scripts because I keep the universe up-to-date... I don't understand. -- Damien Cassou http://damiencassou.seasidehosting.st
Ok I was not aware of that. The problem is that when you code in the core then you should not have the other packages loaded or they should saved in the pharo repository. Damien could you modify the scriptloader to use the universe to load RB? Stef On Feb 3, 2009, at 9:54 AM, Damien Cassou wrote:
On Tue, Feb 3, 2009 at 9:35 AM, Lukas Renggli <renggli@gmail.com> wrote:
It looks like the load scripts in Pharo load a very old and incompatible version of the Refactoring Engine.
I already told them to avoid using their own scripts because I keep the universe up-to-date... I don't understand.
-- Damien Cassou http://damiencassou.seasidehosting.st
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Feb 3, 2009, at 9:35 AM, Lukas Renggli wrote:
It looks like the load scripts in Pharo load a very old and incompatible version of the Refactoring Engine. The package RefactoringEngine is deprecated for a long time and shouldn't be used anymore. Load Refactoring-Core instead.
Ok we should remove the script from script loader and use the universe instead.
Also I would load AST-lr.160, newer versions of that package do not work in my images.
What are the problems? It is related to the changes made by gwenael? Stef
Lukas
On Tue, Feb 3, 2009 at 9:16 AM, Lukas Renggli <renggli@gmail.com> wrote:
In a 10204, using OBAlpha (I did not try with OB).
What is OBAlpha? What is the difference to OB?
I created a class FooBar with a variable 'abc'. Right click on the class, 'Refactor instance variable / rename'. What ever the new name, I get an error.
What kind of Error? Can you provide a stack-trace? I cannot reproduce.
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Also I would load AST-lr.160, newer versions of that package do not work in my images.
What are the problems?
It is related to the changes made by gwenael?
I don't exactly know, I only noticed when Alexandre was reporting about the Refactoring Brwoser issues. The AST package seem to have changed a lot and it seems to subtly break the refactoring browser in several ways. I will have a look again. Lukas -- Lukas Renggli http://www.lukas-renggli.ch
The problem is that when you code in the core then you should not have the other packages loaded or they should saved in the pharo repository.
Damien could you modify the scriptloader to use the universe to load RB?
I modified it. The reason why this method exists is that people can use it to test latest experimental features committed to OB (that's why it's named 'Alpha') that are not (yet) available in Universe. I changed the script to load everything from Universe except all OB packages. I think that should be fair enough. The adapted ScriptLoader is in PharoInbox. (I also adapted #loadSuperOB ...). David
Thanks! Stef On Feb 4, 2009, at 9:24 PM, David Röthlisberger wrote:
The problem is that when you code in the core then you should not have the other packages loaded or they should saved in the pharo repository.
Damien could you modify the scriptloader to use the universe to load RB?
I modified it.
The reason why this method exists is that people can use it to test latest experimental features committed to OB (that's why it's named 'Alpha') that are not (yet) available in Universe. I changed the script to load everything from Universe except all OB packages. I think that should be fair enough.
The adapted ScriptLoader is in PharoInbox. (I also adapted #loadSuperOB ...).
David
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (5)
-
Alexandre Bergel -
Damien Cassou -
David Röthlisberger -
Lukas Renggli -
Stéphane Ducasse