Re: [Pharo-project] what happened with Shout colors in Pharo 1.1?
On 15 oct. 2010, at 17:31, Mariano Martinez Peck wrote:
They've changed a lot from 1.0. For example, self, super, etc, are not in "orange" or that color of 1.0. Instances variables, are blue (instead of black), the same as parameters,etc...
is there a way to recover the original colors? do we wanted this change or it is accidental ?
I think the colors in 1.0 were inherited from the dev images build by Damien Cassou. In 1.1, the colors comes from the settings of Lukas, who maintains Shout? Am I wrong? I liked the colors in 1.0, but now I am accustomed to the current theme, which is very keen to the eye, except for two things that I change: - distinguish instance vars/class vars from other variables: I use a brownish color for that, as I want to see at once methods accessing the state of the object - distinguish class references: I use bold black as in the previous style, as I want to quickly catch hard dependencies in the code To customize colors, two solutions: 1) hack SHTextStylerST80>>defaultStyleTable 2) load latest Shout and use Settings (then you should be able to save/load your style), since there is now a Settings interface -- Simon
On 10/15/2010 9:40 AM, Simon Denier wrote:
On 15 oct. 2010, at 17:31, Mariano Martinez Peck wrote:
They've changed a lot from 1.0. For example, self, super, etc, are not in "orange" or that color of 1.0. Instances variables, are blue (instead of black), the same as parameters,etc...
is there a way to recover the original colors? do we wanted this change or it is accidental ?
I think the colors in 1.0 were inherited from the dev images build by Damien Cassou. In 1.1, the colors comes from the settings of Lukas, who maintains Shout? Am I wrong?
I preferred the old colors as well and switched them back. The new ones are just too weak, not enough color, not enough bold, can't tell things apart. -- Ramon Leon http://onsmalltalk.com
On Fri, Oct 15, 2010 at 9:21 PM, Ramon Leon <ramon.leon@allresnet.com>wrote:
On 10/15/2010 9:40 AM, Simon Denier wrote:
On 15 oct. 2010, at 17:31, Mariano Martinez Peck wrote:
They've changed a lot from 1.0. For example, self, super, etc, are not in
"orange" or that color of 1.0. Instances variables, are blue (instead of black), the same as parameters,etc...
is there a way to recover the original colors? do we wanted this change or it is accidental ?
I think the colors in 1.0 were inherited from the dev images build by Damien Cassou. In 1.1, the colors comes from the settings of Lukas, who maintains Shout? Am I wrong?
I preferred the old colors as well and switched them back. The new ones are just too weak, not enough color, not enough bold, can't tell things apart.
Exactly. Can you or Simon provide a script to set back the original colors?? So that we can apply this for next PharoDev images? (or at least for my own images) Thanks Mariano
-- Ramon Leon http://onsmalltalk.com
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On 10/23/2010 10:11 AM, Mariano Martinez Peck wrote:
Exactly.
Can you or Simon provide a script to set back the original colors?? So that we can apply this for next PharoDev images? (or at least for my own images)
Thanks
Mariano
I just went back in the package history and found the point where Damien changed the colors and grabbed the previous version. I have a ConfigurationOfDevelopment class that loads all my local packages, so I just added a method to it to reload the old colors. Here it is... setColors SHTextStylerST80 styleTable: #( "(symbol color [emphasisSymbolOrArray [textStyleName [pixelHeight]]])" (default black ) (invalid red ) (excessCode red ) (comment (green muchDarker) italic) (unfinishedComment (red muchDarker) italic) (#'$' (red muchDarker) ) (character (red muchDarker) ) (integer (red muchDarker) ) (number (red muchDarker) ) (#- (red muchDarker) ) (symbol (blue muchDarker) bold) (stringSymbol (blue muchDarker) bold) (literalArray (blue muchDarker) bold) (string (magenta muchDarker) normal) (unfinishedString red normal ) (assignment nil bold ) (ansiAssignment nil bold) (literal nil italic) (keyword (blue muchDarker) ) (binary (blue muchDarker) ) (unary (blue muchDarker) ) (incompleteKeyword (gray muchDarker) underlined) (incompleteBinary (gray muchDarker) underlined) (incompleteUnary (gray muchDarker) underlined) (undefinedKeyword red ) (undefinedBinary red ) (undefinedUnary red ) (patternKeyword nil bold) (patternBinary nil bold) (patternUnary nil bold) (#self (red muchDarker) bold) (#super (red muchDarker) bold) (#true (red muchDarker) bold) (#false (red muchDarker) bold) (#nil (red muchDarker) bold) (#thisContext (red muchDarker) bold) (#return (red muchDarker) bold) (patternArg (blue muchDarker) italic) (methodArg (blue muchDarker) italic) (blockPatternArg (blue muchDarker) italic) (blockArg (blue muchDarker) italic) (argument (blue muchDarker) italic) (blockArgColon black ) (leftParenthesis black ) (rightParenthesis black ) (leftParenthesis1 (green muchDarker) ) (rightParenthesis1 (green muchDarker) ) (leftParenthesis2 (magenta muchDarker) ) (rightParenthesis2 (magenta muchDarker) ) (leftParenthesis3 (red muchDarker) ) (rightParenthesis3 (red muchDarker) ) (leftParenthesis4 (green darker) ) (rightParenthesis4 (green darker) ) (leftParenthesis5 (orange darker) ) (rightParenthesis5 (orange darker) ) (leftParenthesis6 (magenta darker) ) (rightParenthesis6 (magenta darker) ) (leftParenthesis7 blue ) (rightParenthesis7 blue ) (blockStart black ) (blockEnd black ) (blockStart1 (green muchDarker) ) (blockEnd1 (green muchDarker) ) (blockStart2 (magenta muchDarker) ) (blockEnd2 (magenta muchDarker) ) (blockStart3 (red muchDarker) ) (blockEnd3 (red muchDarker) ) (blockStart4 (green darker) ) (blockEnd4 (green darker) ) (blockStart5 (orange darker) ) (blockEnd5 (orange darker) ) (blockStart6 (magenta darker) ) (blockEnd6 (magenta darker) ) (blockStart7 blue ) (blockEnd7 blue ) (arrayStart black ) (arrayEnd black ) (arrayStart1 black ) (arrayEnd1 black ) (leftBrace black ) (rightBrace black ) (cascadeSeparator black ) (statementSeparator black ) (externalCallType black ) (externalCallTypePointerIndicator black ) (primitiveOrExternalCallStart black bold ) (primitiveOrExternalCallEnd black bold ) (methodTempBar gray ) (blockTempBar gray ) (blockArgsBar gray ) (primitive (green muchDarker) bold) (pragmaKeyword (green muchDarker) bold) (pragmaUnary (green muchDarker) bold) (pragmaBinary (green muchDarker) bold) (externalFunctionCallingConvention (green muchDarker) bold) (module (green muchDarker) bold) (blockTempVar gray italic) (blockPatternTempVar gray italic) (instVar black bold) (workspaceVar black bold) (undefinedIdentifier red bold) (incompleteIdentifier (gray darker) (italic underlined)) (tempVar (gray darker) italic) (patternTempVar (gray darker) italic) (poolConstant (gray darker) italic) (classVar (gray darker) bold) (globalVar black bold) ) -- Ramon Leon http://onsmalltalk.com
Thanks Ramon. So, we have to options. 1) We commit this change to Shout repository 2) We add this method in ConfigurationOfPharo and we call it while building the dev image. opinions? cheers mariano On Mon, Oct 25, 2010 at 7:12 PM, Ramon Leon <ramon.leon@allresnet.com>wrote:
On 10/23/2010 10:11 AM, Mariano Martinez Peck wrote:
Exactly.
Can you or Simon provide a script to set back the original colors?? So that we can apply this for next PharoDev images? (or at least for my own images)
Thanks
Mariano
I just went back in the package history and found the point where Damien changed the colors and grabbed the previous version. I have a ConfigurationOfDevelopment class that loads all my local packages, so I just added a method to it to reload the old colors. Here it is...
setColors SHTextStylerST80 styleTable: #( "(symbol color [emphasisSymbolOrArray [textStyleName [pixelHeight]]])" (default black ) (invalid red ) (excessCode red ) (comment (green muchDarker) italic) (unfinishedComment (red muchDarker) italic) (#'$' (red muchDarker) ) (character (red muchDarker) ) (integer (red muchDarker) ) (number (red muchDarker) ) (#- (red muchDarker) ) (symbol (blue muchDarker) bold) (stringSymbol (blue muchDarker) bold) (literalArray (blue muchDarker) bold) (string (magenta muchDarker) normal) (unfinishedString red normal ) (assignment nil bold ) (ansiAssignment nil bold) (literal nil italic) (keyword (blue muchDarker) ) (binary (blue muchDarker) ) (unary (blue muchDarker) ) (incompleteKeyword (gray muchDarker) underlined) (incompleteBinary (gray muchDarker) underlined) (incompleteUnary (gray muchDarker) underlined) (undefinedKeyword red ) (undefinedBinary red ) (undefinedUnary red )
(patternKeyword nil bold) (patternBinary nil bold) (patternUnary nil bold) (#self (red muchDarker) bold) (#super (red muchDarker) bold) (#true (red muchDarker) bold) (#false (red muchDarker) bold) (#nil (red muchDarker) bold) (#thisContext (red muchDarker) bold) (#return (red muchDarker) bold) (patternArg (blue muchDarker) italic) (methodArg (blue muchDarker) italic) (blockPatternArg (blue muchDarker) italic) (blockArg (blue muchDarker) italic) (argument (blue muchDarker) italic) (blockArgColon black ) (leftParenthesis black ) (rightParenthesis black ) (leftParenthesis1 (green muchDarker) ) (rightParenthesis1 (green muchDarker) ) (leftParenthesis2 (magenta muchDarker) ) (rightParenthesis2 (magenta muchDarker) ) (leftParenthesis3 (red muchDarker) ) (rightParenthesis3 (red muchDarker) ) (leftParenthesis4 (green darker) ) (rightParenthesis4 (green darker) ) (leftParenthesis5 (orange darker) ) (rightParenthesis5 (orange darker) ) (leftParenthesis6 (magenta darker) ) (rightParenthesis6 (magenta darker) ) (leftParenthesis7 blue ) (rightParenthesis7 blue ) (blockStart black ) (blockEnd black ) (blockStart1 (green muchDarker) ) (blockEnd1 (green muchDarker) ) (blockStart2 (magenta muchDarker) ) (blockEnd2 (magenta muchDarker) ) (blockStart3 (red muchDarker) ) (blockEnd3 (red muchDarker) ) (blockStart4 (green darker) ) (blockEnd4 (green darker) ) (blockStart5 (orange darker) ) (blockEnd5 (orange darker) ) (blockStart6 (magenta darker) ) (blockEnd6 (magenta darker) ) (blockStart7 blue ) (blockEnd7 blue )
(arrayStart black ) (arrayEnd black ) (arrayStart1 black ) (arrayEnd1 black ) (leftBrace black ) (rightBrace black ) (cascadeSeparator black ) (statementSeparator black ) (externalCallType black ) (externalCallTypePointerIndicator black ) (primitiveOrExternalCallStart black bold ) (primitiveOrExternalCallEnd black bold ) (methodTempBar gray ) (blockTempBar gray ) (blockArgsBar gray ) (primitive (green muchDarker) bold) (pragmaKeyword (green muchDarker) bold) (pragmaUnary (green muchDarker) bold) (pragmaBinary (green muchDarker) bold)
(externalFunctionCallingConvention (green muchDarker) bold) (module (green muchDarker) bold) (blockTempVar gray italic) (blockPatternTempVar gray italic) (instVar black bold) (workspaceVar black bold) (undefinedIdentifier red bold) (incompleteIdentifier (gray darker) (italic underlined)) (tempVar (gray darker) italic) (patternTempVar (gray darker) italic) (poolConstant (gray darker) italic) (classVar (gray darker) bold) (globalVar black bold) )
-- Ramon Leon http://onsmalltalk.com
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Fri, Oct 15, 2010 at 6:40 PM, Simon Denier <Simon.Denier@inria.fr> wrote:
On 15 oct. 2010, at 17:31, Mariano Martinez Peck wrote:
They've changed a lot from 1.0. For example, self, super, etc, are not in "orange" or that color of 1.0. Instances variables, are blue (instead of black), the same as parameters,etc...
is there a way to recover the original colors? do we wanted this change or it is accidental ?
I think the colors in 1.0 were inherited from the dev images build by Damien Cassou. In 1.1, the colors comes from the settings of Lukas, who maintains Shout? Am I wrong?
I liked the colors in 1.0, but now I am accustomed to the current theme, which is very keen to the eye, except for two things that I change: - distinguish instance vars/class vars from other variables: I use a brownish color for that, as I want to see at once methods accessing the state of the object - distinguish class references: I use bold black as in the previous style, as I want to quickly catch hard dependencies in the code
EXACTLY!!! this is exacrtly the same that bothers me.
To customize colors, two solutions: 1) hack SHTextStylerST80>>defaultStyleTable
did you do this? can you share?
2) load latest Shout and use Settings (then you should be able to save/load your style), since there is now a Settings interface
The problem is that I have my own style also....and when you save an style I think you save it completly...I guess you cannot merge, so I will loose my own changes. Anyway, can you export and share the style so that I can take a look? Thanks! Mariano
-- Simon
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (3)
-
Mariano Martinez Peck -
Ramon Leon -
Simon Denier