[Pharo-project] EncryptedMultiDisplayScanner, are you serious?
An EncryptedMultiDisplayScanner is a MultiDisplayScanner displaying stars instead of characters (for password by example) Wow... this is soooo overkill! Look at the amount of extra code we have just to simply displaying stupid stars ... ************ See the: EncryptedTextMorphForFieldView>>drawOn: ... aCanvas encryptedParagraph: self paragraph bounds: fauxBounds color: color. ehh?.. Since when canvas (a tool for drawing graphic primitives and text) needs to know anything like that? I'm not sure if there could be better/simpler solution (considering that we don't have a simple line editor and need to go over overcomplicated text->composer->scanner->displayscanner chain to be able to edit even single string.. but that's really, really stupid to penetrate multiple layers of responsibility just to display stars instead of characters... What if i would like to display '%' instead of chars, should i also go and repeat same way?? We should get rid of this thing.. -- Best regards, Igor Stasenko.
On Oct 14, 2012, at 1:22 AM, Igor Stasenko wrote:
An EncryptedMultiDisplayScanner is a MultiDisplayScanner displaying stars instead of characters (for password by example)
Wow... this is soooo overkill!
Indeed I was not aware of that system.
Look at the amount of extra code we have just to simply displaying stupid stars ... ************
See the: EncryptedTextMorphForFieldView>>drawOn: ... aCanvas encryptedParagraph: self paragraph bounds: fauxBounds color: color.
ehh?.. Since when canvas (a tool for drawing graphic primitives and text) needs to know anything like that?
I'm not sure if there could be better/simpler solution (considering that we don't have a simple line editor and need to go over overcomplicated text->composer->scanner->displayscanner chain to be able to edit even single string.. but that's really, really stupid to penetrate multiple layers of responsibility just to display stars instead of characters...
What if i would like to display '%' instead of chars, should i also go and repeat same way??
We should get rid of this thing..
Yes.
-- Best regards, Igor Stasenko.
I am always feeling like an archaelogist when looking at these things... Phil 2012/10/14 Stéphane Ducasse <stephane.ducasse@inria.fr>
On Oct 14, 2012, at 1:22 AM, Igor Stasenko wrote:
An EncryptedMultiDisplayScanner is a MultiDisplayScanner displaying stars instead of characters (for password by example)
Wow... this is soooo overkill!
Indeed I was not aware of that system.
Look at the amount of extra code we have just to simply displaying stupid stars ... ************
See the: EncryptedTextMorphForFieldView>>drawOn: ... aCanvas encryptedParagraph: self paragraph bounds: fauxBounds color:
color.
ehh?.. Since when canvas (a tool for drawing graphic primitives and text) needs to know anything like that?
I'm not sure if there could be better/simpler solution (considering that we don't have a simple line editor and need to go over overcomplicated text->composer->scanner->displayscanner chain to be able to edit even single string.. but that's really, really stupid to penetrate multiple layers of responsibility just to display stars instead of characters...
What if i would like to display '%' instead of chars, should i also go and repeat same way??
We should get rid of this thing..
Yes.
-- Best regards, Igor Stasenko.
Me too but less and less :) On Oct 14, 2012, at 10:52 AM, phil@highoctane.be wrote:
I am always feeling like an archaelogist when looking at these things...
Phil
2012/10/14 Stéphane Ducasse <stephane.ducasse@inria.fr>
On Oct 14, 2012, at 1:22 AM, Igor Stasenko wrote:
An EncryptedMultiDisplayScanner is a MultiDisplayScanner displaying stars instead of characters (for password by example)
Wow... this is soooo overkill!
Indeed I was not aware of that system.
Look at the amount of extra code we have just to simply displaying stupid stars ... ************
See the: EncryptedTextMorphForFieldView>>drawOn: ... aCanvas encryptedParagraph: self paragraph bounds: fauxBounds color: color.
ehh?.. Since when canvas (a tool for drawing graphic primitives and text) needs to know anything like that?
I'm not sure if there could be better/simpler solution (considering that we don't have a simple line editor and need to go over overcomplicated text->composer->scanner->displayscanner chain to be able to edit even single string.. but that's really, really stupid to penetrate multiple layers of responsibility just to display stars instead of characters...
What if i would like to display '%' instead of chars, should i also go and repeat same way??
We should get rid of this thing..
Yes.
-- Best regards, Igor Stasenko.
On Oct 14, 2012, at 10:15 PM, Henrik Sperre Johansen <henrik.s.johansen@veloxit.no> wrote:
On 14.10.2012 10:52, phil@highoctane.be wrote:
I am always feeling like an archaelogist when looking at these things...
Phil Funnily enough, that class in particular was added just half a year ago :)
Yes, and as always, I am guilty of having integrated that change :-) Marcus -- Marcus Denker -- http://marcusdenker.de
On 14 October 2012 22:21, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 14, 2012, at 10:15 PM, Henrik Sperre Johansen <henrik.s.johansen@veloxit.no> wrote:
On 14.10.2012 10:52, phil@highoctane.be wrote:
I am always feeling like an archaelogist when looking at these things...
Phil Funnily enough, that class in particular was added just half a year ago :)
Yes, and as always, I am guilty of having integrated that change :-)
Quality control needs more manpower than we currently have. Aside of tools which can help with it. Why we can't use monkey to generate diffs? It should be straightforward.
Marcus
-- Marcus Denker -- http://marcusdenker.de
-- Best regards, Igor Stasenko.
Yes it means that we can also fix our own error. This is also why I would like to see the diff when the code is committed. I checked today ss3 but I could only see the rss and not the diff. Setf
On 14.10.2012 10:52, phil@highoctane.be wrote:
I am always feeling like an archaelogist when looking at these things...
Phil Funnily enough, that class in particular was added just half a year ago :)
Cheers, Henry
http://code.google.com/p/pharo/issues/detail?id=6808 :) On Oct 14, 2012, at 1:22 AM, Igor Stasenko wrote:
EncryptedMultiDisplayScanner
participants (5)
-
Henrik Sperre Johansen -
Igor Stasenko -
Marcus Denker -
phil＠highoctane.be -
Stéphane Ducasse