[pharo-project/pharo-core] 1953a9: 30829
Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 1953a92ba18a036b8f469a69840f0597468abf32 https://github.com/pharo-project/pharo-core/commit/1953a92ba18a036b8f469a698... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-04-23 (Wed, 23 Apr 2014) Changed paths: M Komitter.package/KomitterUI.class/class/specs/defaultSpec.st M Morphic-Base.package/HaloMorph.class/instance/private/addNameBeneath_string_.st A Morphic-Base.package/NameStringInHalo.class/README.md A Morphic-Base.package/NameStringInHalo.class/definition.st A Morphic-Base.package/NameStringInHalo.class/instance/drawing/drawOn_.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script482.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30829.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 30829 12978 Komitter hide Check Lint Rules https://pharo.fogbugz.com/f/cases/12978 13204 Hard to see Morph halo label https://pharo.fogbugz.com/f/cases/13204 http://files.pharo.org/image/30/30829.zip
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted. On 23 Apr 2014, at 17:55, GitHub <noreply@github.com> wrote:
Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: 1953a92ba18a036b8f469a69840f0597468abf32 https://github.com/pharo-project/pharo-core/commit/1953a92ba18a036b8f469a698... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-04-23 (Wed, 23 Apr 2014)
Changed paths: M Komitter.package/KomitterUI.class/class/specs/defaultSpec.st M Morphic-Base.package/HaloMorph.class/instance/private/addNameBeneath_string_.st A Morphic-Base.package/NameStringInHalo.class/README.md A Morphic-Base.package/NameStringInHalo.class/definition.st A Morphic-Base.package/NameStringInHalo.class/instance/drawing/drawOn_.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script482.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30829.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
Log Message: ----------- 30829 12978 Komitter hide Check Lint Rules https://pharo.fogbugz.com/f/cases/12978
13204 Hard to see Morph halo label https://pharo.fogbugz.com/f/cases/13204
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes! there are just two issues that are for pharo3 with fixes: https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class... https://pharo.fogbugz.com/f/cases/11934/Last-Modified-Classed-group-in-Nauti... I am looking at them now. Marcus
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*. (the build did not get done, so no problem, other than a red build) I will revert tomorrow... Marcus
On 23 avr. 2014, at 19:00, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*.
(the build did not get done, so no problem, other than a red build)
I will revert tomorrow...
Arg, I'm sick of that issue. So do we try to integrate it in two passes?
Marcus
On 23 Apr 2014, at 19:21, Camille Teruel <camille.teruel@gmail.com> wrote:
On 23 avr. 2014, at 19:00, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*.
(the build did not get done, so no problem, other than a red build)
I will revert tomorrow...
Arg, I'm sick of that issue. So do we try to integrate it in two passes?
I have no idea what goes wrong⦠it seems that it works fine when I merge the slice. But then the update process (which just saved the packagesâ¦) does something wrong. Mayeb we could try to have a version without the method that sends #explicitRequirement Marcus
On 23 Apr 2014, at 19:30, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 19:21, Camille Teruel <camille.teruel@gmail.com> wrote:
On 23 avr. 2014, at 19:00, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*.
(the build did not get done, so no problem, other than a red build)
I will revert tomorrow...
Arg, I'm sick of that issue. So do we try to integrate it in two passes?
I have no idea what goes wrong⦠it seems that it works fine when I merge the slice. But then the update process (which just saved the packagesâ¦) does something wrong.
Mayeb we could try to have a version without the method that sends #explicitRequirement
I integrated the issue as a change set (so there is some load order bug related to Traits with MCâ¦). This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a âshould not happenâ error. https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2.3-MetacelloValidation/... (it would have been nice to have integrated this issue 2 weeks agoâ¦) Fetched -> Metacello-TestsPlatform.squeakCommon-dkh.11 --- github://dalehenrich/metacello-work:master/repository --- github://dalehenrich/metacello-work:master/repository[31mError: Should not happen [0mLayoutEmptyScope(Object)>>error: LayoutEmptyScope(LayoutAbstractScope)>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: FixedLayout(ObjectLayout)>>reshapeFrom:to: ClassModificationPropagation>>propagate:to: ClassModificationPropagation class>>propagate:to: ClassModification(AbstractClassModification)>>propagate in Block: [ :subclass | propagations add: (ClassModification...etc... Metaclass>>subclassesDo: in Block: [ :aSubclass | ... Array(SequenceableCollection)>>do: MCFileTreeFileUtils class(Class)>>subclassesDo: Metaclass>>subclassesDo: ClassModification(AbstractClassModification)>>propagate SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: in Block: [ :old :new | ... SlotClassBuilder>>track:during: SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: SlotClassBuilder>>applySharedVariableOrPoolChange: SlotClassBuilder>>apply: SlotClassBuilder>>build PharoClassInstaller class(AbstractClassInstaller class)>>make: OldClassBuilderAdapter>>name:inEnvironment:subclassOf:type:instanceVariableNames:classVariableNames:poolDictionaries:category: MCClassDefinition>>createClass in Block: [ ... BlockClosure>>on:do:
On 24 avr. 2014, at 09:59, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 19:30, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 19:21, Camille Teruel <camille.teruel@gmail.com> wrote:
On 23 avr. 2014, at 19:00, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*.
(the build did not get done, so no problem, other than a red build)
I will revert tomorrow...
Arg, I'm sick of that issue. So do we try to integrate it in two passes?
I have no idea what goes wrong⦠it seems that it works fine when I merge the slice. But then the update process (which just saved the packagesâ¦) does something wrong.
Mayeb we could try to have a version without the method that sends #explicitRequirement
I integrated the issue as a change set (so there is some load order bug related to Traits with MCâ¦).
This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a âshould not happenâ error.
Did you run the postscript? Smalltalk allClassesDo: [ :c | c superclass addSubclass: c ]
https://ci.inria.fr/pharo/job/Pharo-3.0-Update-Step-2.3-MetacelloValidation/...
(it would have been nice to have integrated this issue 2 weeks agoâ¦)
Indeed
Fetched -> Metacello-TestsPlatform.squeakCommon-dkh.11 --- github://dalehenrich/metacello-work:master/repository --- github://dalehenrich/metacello-work:master/repository[31mError: Should not happen [0mLayoutEmptyScope(Object)>>error: LayoutEmptyScope(LayoutAbstractScope)>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: LayoutClassScope>>rebase:to: FixedLayout(ObjectLayout)>>reshapeFrom:to: ClassModificationPropagation>>propagate:to: ClassModificationPropagation class>>propagate:to: ClassModification(AbstractClassModification)>>propagate in Block: [ :subclass | propagations add: (ClassModification...etc... Metaclass>>subclassesDo: in Block: [ :aSubclass | ... Array(SequenceableCollection)>>do: MCFileTreeFileUtils class(Class)>>subclassesDo: Metaclass>>subclassesDo: ClassModification(AbstractClassModification)>>propagate SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: in Block: [ :old :new | ... SlotClassBuilder>>track:during: SlotClassBuilder>>applyAndUpdateSharedVariableOrSharedPool: SlotClassBuilder>>applySharedVariableOrPoolChange: SlotClassBuilder>>apply: SlotClassBuilder>>build PharoClassInstaller class(AbstractClassInstaller class)>>make: OldClassBuilderAdapter>>name:inEnvironment:subclassOf:type:instanceVariableNames:classVariableNames:poolDictionaries:category: MCClassDefinition>>createClass in Block: [ ... BlockClosure>>on:do:
On 24 Apr 2014, at 13:46, Camille Teruel <camille.teruel@gmail.com> wrote:
On 24 avr. 2014, at 09:59, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 19:30, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 19:21, Camille Teruel <camille.teruel@gmail.com> wrote:
On 23 avr. 2014, at 19:00, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:34, Marcus Denker <marcus.denker@inria.fr> wrote:
On 23 Apr 2014, at 18:18, Sven Van Caekenberghe <sven@stfx.eu> wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Yes!
there are just two issues that are for pharo3 with fixes:
https://pharo.fogbugz.com/f/cases/13028/Adding-ClassVariables-corrupts-class...
Ok, so loading that one brakes *everything*.
(the build did not get done, so no problem, other than a red build)
I will revert tomorrow...
Arg, I'm sick of that issue. So do we try to integrate it in two passes?
I have no idea what goes wrong⦠it seems that it works fine when I merge the slice. But then the update process (which just saved the packagesâ¦) does something wrong.
Mayeb we could try to have a version without the method that sends #explicitRequirement
I integrated the issue as a change set (so there is some load order bug related to Traits with MCâ¦).
This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a âshould not happenâ error.
Did you run the postscript? Smalltalk allClassesDo: [ :c | c superclass addSubclass: c ]
No, but if that would be inconsistent, there is a test that fails⦠But I can do it the next update. Marcus
This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a âshould not happenâ error.
Did you run the postscript? Smalltalk allClassesDo: [ :c | c superclass addSubclass: c ]
No, but if that would be inconsistent, there is a test that failsâ¦
But I can do it the next update.
I did one update 30 832 with this. But I guess it will not change anything⦠after that I will revert to 3.0 829. Marcus
On 24 avr. 2014, at 14:18, Marcus Denker <marcus.denker@inria.fr> wrote:
This seems to have worked: all image tests are green. BUT: the Metacello Platformtests fail with a âshould not happenâ error.
Did you run the postscript? Smalltalk allClassesDo: [ :c | c superclass addSubclass: c ]
No, but if that would be inconsistent, there is a test that failsâ¦
But I can do it the next update.
I did one update 30 832 with this. But I guess it will not change anything⦠after that I will revert to 3.0 829.
My bad I confuses issues... In fact this is not related to this issue but to issue 11596, I never noticed but it has never been integrated!!! By running the script I gave back then, you can see that a lot of classes have still a wrong layout!! That is the scope of the layout of their superclass is not the parent scope of their layout, which give this #shouldNotHappen error Namely: DialogWindowModel class MBAbstractInfoList class MBLabelInfo class MBSpecInfo class MCClassDefinition MCClassDefinition class MCClassTraitDefinition MCClassTraitDefinition class MCFileTreeFileSystemUtils class MCMethodDefinition MCMethodDefinition class MCMockDefinition MCMockDefinition class MCOrganizationDefinition MCOrganizationDefinition class MCScriptDefinition MCScriptDefinition class ProfStef class SpecDebugActionButton class TTLCache TTLCache class TextInputFieldModel class UIThemeVistary class UIThemeWatery class WorldModel class Please run this script we cannot release Pharo with all these corrupted classes!!!
Marcus
Sven Van Caekenberghe wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Thats great news. However while the CI monkey is great, there are still a few tests (at least in Windows) that fail in a fresh image since: * they are bypassed by the CI * they are not run on a Windows CI slave I fixed a few similar failures but ran out of time to finish this. It might be worthwhile some others doing a pass the old fashioned way via the TestRunner GUI. Thats what users will end up seeing. It would be "real nice" if TestRunner showed users ALL GREEN for the Released image. I've just started a run with the latest image while I head off to bed. I'll report more on the issue tracker tomorrow. cheer -ben
On 23 Apr 2014, at 19:55, Ben Coman <btc@openInWorld.com> wrote:
Sven Van Caekenberghe wrote:
And we're all GREEN, great work ! Let's keep it that way until release. Everything that breaks a test should now be reverted.
Thats great news. However while the CI monkey is great, there are still a few tests (at least in Windows) that fail in a fresh image since: * they are bypassed by the CI * they are not run on a Windows CI slave
I fixed a few similar failures but ran out of time to finish this. It might be worthwhile some others doing a pass the old fashioned way via the TestRunner GUI. Thats what users will end up seeing. It would be "real nice" if TestRunner showed users ALL GREEN for the Released image. I've just started a run with the latest image while I head off to bed. I'll report more on the issue tracker tomorrow.
Agreed, but we know from experience that running the tests in a very controlled environment is the only way to have a common frame of reference. Yes, there are always a couple of guys that will download the release, run all tests and complain about a couple of failures. It would be super if we could avoid that, but I am pretty sure that will not happen (i.e. they will not succeed 100% for everyone). More eyes (especially on, the many different variants of, Windows) will always help, but the community is what it is. Sven
On 23 Apr 2014, at 23:27, Ben Coman <btc@openInWorld.com> wrote:
Agreed, but can you confirm that TestRunner GUI shows all-green for yourself.
No, it is not all green, as to be expected: 11850 run, 11797 passes, 15 skipped, 43 expected failures, 6 failures, 4 errors, 0 unexpected passes Failures: ReleaseTest>>#testUnknownProcesses MetacelloDevelopmentCycleTutorialTests>>#testCreateNewDevelopment MetacelloDevelopmentCycleTutorialTests>>#testValidateAndSave JobTest>>#testCurrent ReleaseTest>>#testObsoleteClasses MetacelloDevelopmentCycleTutorialTests>>#testCreateDevelopment Errors: MetacelloDevelopmentCycleTutorialTests>>#testCreateNewBaseline MetacelloDevelopmentCycleTutorialTests>>#testCreateNewDevelopment MetacelloDevelopmentCycleTutorialTests>>#testReleaseDevelopment MetacelloDevelopmentCycleTutorialTests>>#testValidateAndSave And my system details are: Image ----- /Users/sven/Develop/git/IntegrationScripts/current/Pharo.image Pharo3.0 Latest update: #30830 Unnamed Virtual Machine --------------- /Users/sven/Develop/Smalltalk/Pharo3.0.app/Contents/MacOS/Pharo NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 NBCogit NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 git://gitorious.org/cogvm/blessed.git Commit: 412abef33cbed05cf1d75329e451d71c0c6aa5a7 Date: 2013-03-13 17:48:50 +0100 By: Esteban Lorenzano <estebanlm@gmail.com> Jenkins build #14535 Mac Cocoa Cog 5.8b12 21-Sep-10 >1B0534FA-246C-47C5-AB29-7A76C81CCDCB< VMMaker versionString git://gitorious.org/cogvm/blessed.git Commit: 412abef33cbed05cf1d75329e451d71c0c6aa5a7 Date: 2013-03-13 17:48:50 +0100 By: Esteban Lorenzano <estebanlm@gmail.com> Jenkins build #14535 NBCoInterpreter NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013 NBCogit NativeBoost-CogPlugin-EstebanLorenzano.18 uuid: a53445f9-c0c0-4015-97a3-be7db8d9ed6b Mar 13 2013
participants (5)
-
Ben Coman -
Camille Teruel -
GitHub -
Marcus Denker -
Sven Van Caekenberghe