Hi, This method in DeepCopier has no senders (in Pharo 3) and it's the only who references the class variable NextVariableCheckTime. The time stamp says 1999... Unused code to remove? isItTimeToCheckVariables | now isIt | NextVariableCheckTime ifNil: [ NextVariableCheckTime := Time totalSeconds. ^ true]. now := Time totalSeconds. isIt := NextVariableCheckTime < now. isIt ifTrue: ["update time for next check" NextVariableCheckTime := now + self intervalForChecks]. ^isIt Cheers, MartÃn
Yes, this can be cleanup up. On 25 Oct 2013 at 11:10:34, Martin Dias (tinchodias@gmail.com) wrote: Hi, This method in DeepCopier has no senders (in Pharo 3) and it's the only who references the class variable NextVariableCheckTime. The time stamp says 1999... Unused code to remove? isItTimeToCheckVariables | now isIt | NextVariableCheckTime ifNil: [ NextVariableCheckTime := Time totalSeconds. ^ true]. now := Time totalSeconds. isIt := NextVariableCheckTime < now. isIt ifTrue: ["update time for next check" NextVariableCheckTime := now + self intervalForChecks]. ^isIt Cheers, MartÃn
Reported: https://pharo.fogbugz.com/f/cases/12002/DeepCopier-isItTimeToCheckVariables-... On Fri, Oct 25, 2013 at 12:57 PM, Marcus Denker <marcus.denker@inria.fr>wrote:
Yes, this can be cleanup up.
On 25 Oct 2013 at 11:10:34, Martin Dias (tinchodias@gmail.com<//tinchodias@gmail.com>) wrote:
Hi,
This method in DeepCopier has no senders (in Pharo 3) and it's the only who references the class variable NextVariableCheckTime.
The time stamp says 1999... Unused code to remove?
isItTimeToCheckVariables
| now isIt | NextVariableCheckTime ifNil: [ NextVariableCheckTime := Time totalSeconds. ^ true]. now := Time totalSeconds. isIt := NextVariableCheckTime < now. isIt ifTrue: ["update time for next check" NextVariableCheckTime := now + self intervalForChecks]. ^isIt
Cheers, MartÃn
Martin watching the DeepCopier??? mmmm I am afraid to ask why ;) On Fri, Oct 25, 2013 at 6:10 AM, Martin Dias <tinchodias@gmail.com> wrote:
Hi,
This method in DeepCopier has no senders (in Pharo 3) and it's the only who references the class variable NextVariableCheckTime.
The time stamp says 1999... Unused code to remove?
isItTimeToCheckVariables
| now isIt | NextVariableCheckTime ifNil: [ NextVariableCheckTime := Time totalSeconds. ^ true]. now := Time totalSeconds. isIt := NextVariableCheckTime < now. isIt ifTrue: ["update time for next check" NextVariableCheckTime := now + self intervalForChecks]. ^isIt
Cheers, MartÃn
-- Mariano http://marianopeck.wordpress.com
xD yes, DeepCopier, our old friend! mmmm but it's not about replacing by Fuel or something like that. It was just a random pick for "fix a triviality a day", what Marcus proposed some weeks ago. On Fri, Oct 25, 2013 at 3:56 PM, Mariano Martinez Peck < marianopeck@gmail.com> wrote:
Martin watching the DeepCopier??? mmmm I am afraid to ask why ;)
On Fri, Oct 25, 2013 at 6:10 AM, Martin Dias <tinchodias@gmail.com> wrote:
Hi,
This method in DeepCopier has no senders (in Pharo 3) and it's the only who references the class variable NextVariableCheckTime.
The time stamp says 1999... Unused code to remove?
isItTimeToCheckVariables
| now isIt | NextVariableCheckTime ifNil: [ NextVariableCheckTime := Time totalSeconds. ^ true]. now := Time totalSeconds. isIt := NextVariableCheckTime < now. isIt ifTrue: ["update time for next check" NextVariableCheckTime := now + self intervalForChecks]. ^isIt
Cheers, MartÃn
-- Mariano http://marianopeck.wordpress.com
participants (3)
-
Marcus Denker -
Mariano Martinez Peck -
Martin Dias