Hi guys can you rename this method? on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ] Please do not use on:do: for something that is not about exception (and announcements). It is too confusing and refactor after. Stef
Yeah, no problem. I'll get on it right away. Max On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
Done. Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206 * created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix) On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
impressive :) Tx guys. We are fighting with memory leaks like mad :) Stef On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
Hi Thanks Stef for fighting with the leak and thanks Max for the fast response. I think was me who added the method #on:do:, and my reasoning was: - FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream So, I created #on:do:. It looked consistent. MartÃn On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong? On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote:
Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
false polymorphism with exception handling? 2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com>
Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote:
Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
On 5 August 2013 16:18, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:
false polymorphism with exception handling?
innndeeeed :)
2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com>
Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote:
Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
-- Best regards, Igor Stasenko.
On Aug 5, 2013, at 4:18 PM, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:
false polymorphism with exception handling?
indeed. When I read code and I see on:do: there is a big sign that shows up in my mind: exception. In addition when I look inside the senders I get false sense of use. This is the case for example with on:do: for announcement which I really do not like. I think that we will rename on:do: into onAnnouncement:do: because I did not see one case where suddenly I would like to mix exception with announcement. Stef
2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com> Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote: Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
I'd prefer #when:do: rather than #onAnnouncement:do: - Francisco On 5 Aug 2013, at 18:01, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Aug 5, 2013, at 4:18 PM, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:
false polymorphism with exception handling?
indeed.
When I read code and I see on:do: there is a big sign that shows up in my mind: exception.
In addition when I look inside the senders I get false sense of use.
This is the case for example with on:do: for announcement which I really do not like. I think that we will rename on:do: into onAnnouncement:do: because I did not see one case where suddenly I would like to mix exception with announcement.
Stef
2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com> Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote: Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
Hi francisco thanks for the suggestion. Indeed me too :) Now I will check. Stef On Aug 5, 2013, at 8:17 PM, Francisco Garau <francisco.garau@gmail.com> wrote:
I'd prefer #when:do: rather than #onAnnouncement:do:
- Francisco
On 5 Aug 2013, at 18:01, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Aug 5, 2013, at 4:18 PM, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:
false polymorphism with exception handling?
indeed.
When I read code and I see on:do: there is a big sign that shows up in my mind: exception.
In addition when I look inside the senders I get false sense of use.
This is the case for example with on:do: for announcement which I really do not like. I think that we will rename on:do: into onAnnouncement:do: because I did not see one case where suddenly I would like to mix exception with announcement.
Stef
2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com> Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com> wrote: Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
On Aug 5, 2013, at 9:15 , Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi francisco
thanks for the suggestion. Indeed me too :) Now I will check.
Stef
#when:do: is there already ;) #when:send:to: and #when:do:for: should be added though. Cheers, Henry
On Aug 6, 2013, at 4:47 PM, Stéphane Ducasse <Stephane.Ducasse@inria.fr> wrote:
#when:do: is there already ;)
even better then :)
#when:send:to: and #when:do:for: should be added though.
what would be when:do:for: ?
sounds good.
Cheers, Henry
On Aug 7, 2013, at 8:55 , Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Aug 6, 2013, at 4:47 PM, Stéphane Ducasse <Stephane.Ducasse@inria.fr> wrote:
#when:do: is there already ;)
even better then :)
#when:send:to: and #when:do:for: should be added though.
what would be when:do:for: ?
Its use is to specify a non-standard subscriber. In VW it is pretty much mandatory when using weak subscription, as VW subscribes the block. In Pharo it's much less useful, both because the at the moment weak when:do: doesn't work, but also since Pharo subscribes the block's receiver by default, which is what you want in 95% of cases. Still nice to have around in the edge cases one might still need it though. Cheers, Henry
hi henrik do you have an implementation for when:do:for: because I do not see it? https://pharo.fogbugz.com/default.asp?11316 Stef
#when:do: is there already ;)
even better then :)
#when:send:to: and #when:do:for: should be added though.
what would be when:do:for: ?
Its use is to specify a non-standard subscriber. In VW it is pretty much mandatory when using weak subscription, as VW subscribes the block. In Pharo it's much less useful, both because the at the moment weak when:do: doesn't work, but also since Pharo subscribes the block's receiver by default, which is what you want in 95% of cases. Still nice to have around in the edge cases one might still need it though.
Cheers, Henry
2013/8/5 Francisco Garau <francisco.garau@gmail.com>
I'd prefer #when:do: rather than #onAnnouncement:do:
Yes. And it was original API from VisualWorks. And maybe it stay in VW now
- Francisco
On 5 Aug 2013, at 18:01, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Aug 5, 2013, at 4:18 PM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
false polymorphism with exception handling?
indeed.
When I read code and I see on:do: there is a big sign that shows up in my mind: exception.
In addition when I look inside the senders I get false sense of use.
This is the case for example with on:do: for announcement which I really do not like. I think that we will rename on:do: into onAnnouncement:do: because I did not see one case where suddenly I would like to mix exception with announcement.
Stef
2013/8/5 Mariano Martinez Peck <marianopeck@gmail.com>
Indeed, I thought the same. Stef, could you tell us why implementing on:do: is wrong?
On Mon, Aug 5, 2013 at 10:30 AM, Martin Dias <tinchodias@gmail.com>wrote:
Hi
Thanks Stef for fighting with the leak and thanks Max for the fast response.
I think was me who added the method #on:do:, and my reasoning was:
- FileStream has #fileNamed: and #fileNamed:do: - PositionableStream has #on: - I needed the analog to FileStream>>fileNamed:do: in PositionableStream
So, I created #on:do:. It looked consistent.
MartÃn
On Sun, Aug 4, 2013 at 5:02 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
impressive :) Tx guys. We are fighting with memory leaks like mad :)
Stef
On Aug 4, 2013, at 4:49 PM, Max Leske <maxleske@gmail.com> wrote:
Done.
Name: ConfigurationOfFuel-MaxLeske.207 Author: MaxLeske Time: 4 August 2013, 4:49:17.037 pm UUID: 5cc59075-e365-4a58-a20b-22e40b2b70c9 Ancestors: ConfigurationOfFuel-MartinDias.206
* created new version 1.9.2 for development * pointed development to 1.9.2 * includes changes Camillo wanted to introduce into 1.9.1 (DateAndTime fix)
On 04.08.2013, at 16:35, Max Leske <maxleske@gmail.com> wrote:
Yeah, no problem. I'll get on it right away.
Max
On 04.08.2013, at 16:10, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
Hi guys
can you rename this method?
on: aCollectionOrStream do: aBlock "Evaluates a block with a new stream based on the collection or stream. Answers the result of the block evaluation. Follows the style of FileStream>>fileNamed:do:." | aStream | aStream := self on: aCollectionOrStream. [ ^ aBlock value: aStream ] ensure: [ aStream close ]
Please do not use on:do: for something that is not about exception (and announcements).
It is too confusing and refactor after.
Stef
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
_______________________________________________ Pharo-fuel mailing list Pharo-fuel@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-fuel
-- Mariano http://marianopeck.wordpress.com
participants (10)
-
Denis Kudriashov -
Esteban A. Maringolo -
Francisco Garau -
Henrik Johansen -
Igor Stasenko -
Mariano Martinez Peck -
Martin Dias -
Max Leske -
Nicolas Cellier -
Stéphane Ducasse