Re: [Pharo-dev] [Pharo-users] [Pharo7.0a] Next batch of enhancements
On Sun, Nov 5, 2017 at 7:00 PM, PBKResearch <peter@pbkresearch.co.uk> wrote:
I managed to find the fogbugz entry - not easy, because it has been closed,
so clicking on the link gives 404 btw, I don't think the 404 has anything to do with the case being closed. The url is simply incorrect. Compare the last slash in this correct url... https://pharo.fogbugz.com/f/cases/20587/remove-UIThemeWatery
* 20587-remove-UIThemeWatery >> https://pharo.fogbugz.com/f/cases/20587-remove-UIThemeWatery
this issue url works fine...
Issue URL: https://pharo.fogbugz.com/f/cases/20587
PR URL: https://github.com/pharo-project/pharo/pull/395 Diff URL: https://github.com/pharo-project/pharo/pull/395/files
cheers -ben
Just a side note, all text preceded by >> in the mail is the original pull request comment. So it was the PR comment that was wrong. We decided with Stef to let the comment untouched and not parse it, because we cannot depend on what people put as a comment... On Sun, Nov 5, 2017 at 12:32 PM, Ben Coman <btc@openinworld.com> wrote:
On Sun, Nov 5, 2017 at 7:00 PM, PBKResearch <peter@pbkresearch.co.uk> wrote:
I managed to find the fogbugz entry - not easy, because it has been closed,
so clicking on the link gives 404
btw, I don't think the 404 has anything to do with the case being closed. The url is simply incorrect. Compare the last slash in this correct url... https://pharo.fogbugz.com/f/cases/20587/remove-UIThemeWatery
* 20587-remove-UIThemeWatery >> https://pharo.fogbugz.com/f/cases/20587-remove-UIThemeWatery
this issue url works fine...
Issue URL: https://pharo.fogbugz.com/f/cases/20587
PR URL: https://github.com/pharo-project/pharo/pull/395 Diff URL: https://github.com/pharo-project/pharo/pull/395/files
cheers -ben
-- Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>* *Web:* *http://guillep.github.io* <http://guillep.github.io> *Phone: *+33 06 52 70 66 13
Ups, my fault. -- Pavel 2017-11-05 12:58 GMT+01:00 Guillermo Polito <guillermopolito@gmail.com>:
Just a side note, all text preceded by >> in the mail is the original pull request comment. So it was the PR comment that was wrong. We decided with Stef to let the comment untouched and not parse it, because we cannot depend on what people put as a comment...
On Sun, Nov 5, 2017 at 12:32 PM, Ben Coman <btc@openinworld.com> wrote:
On Sun, Nov 5, 2017 at 7:00 PM, PBKResearch <peter@pbkresearch.co.uk> wrote:
I managed to find the fogbugz entry - not easy, because it has been closed,
so clicking on the link gives 404
btw, I don't think the 404 has anything to do with the case being closed. The url is simply incorrect. Compare the last slash in this correct url... https://pharo.fogbugz.com/f/cases/20587/remove-UIThemeWatery
* 20587-remove-UIThemeWatery >> https://pharo.fogbugz.com/f/cases/20587-remove-UIThemeWatery
this issue url works fine...
Issue URL: https://pharo.fogbugz.com/f/cases/20587
PR URL: https://github.com/pharo-project/pharo/pull/395 Diff URL: https://github.com/pharo-project/pharo/pull/395/files
cheers -ben
--
Guille Polito
Research Engineer
Centre de Recherche en Informatique, Signal et Automatique de Lille
CRIStAL - UMR 9189
French National Center for Scientific Research - *http://www.cnrs.fr <http://www.cnrs.fr>*
*Web:* *http://guillep.github.io* <http://guillep.github.io>
*Phone: *+33 06 52 70 66 13 <+33%206%2052%2070%2066%2013>
participants (3)
-
Ben Coman -
Guillermo Polito -
Pavel Krivanek