[pharo-project/pharo-core] ea9df7: 40138
Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: ea9df753838798807e3da21846076dd7442a6cb5 https://github.com/pharo-project/pharo-core/commit/ea9df753838798807e3da2184... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-07-30 (Wed, 30 Jul 2014) Changed paths: R Nautilus.package/AbstractNautilusUI.class/instance/menus behavior/createInstVarAccessors.st R Nautilus.package/AbstractNautilusUI.class/instance/private/buildGetterFor_.st R Nautilus.package/AbstractNautilusUI.class/instance/private/buildSetterFor_.st M Nautilus.package/extension/ClassDescription/instance/buildAnalyzeSubMenu_.st R NautilusRefactoring.package/NautilusRefactoring.class/instance/inst var/accessorsInstVarFrom_.st R NautilusRefactoring.package/NautilusRefactoring.class/instance/private-inst var/privateAccessorsInstVarFrom_.st M NautilusRefactoring.package/extension/ClassDescription/instance/instVarRefactoring_.st M OpalDecompiler.package/OCDecompiler.class/instance/instruction decoding/popIntoTemporaryVariable_.st M OpalDecompiler.package/OCDecompiler.class/instance/private/convertToDoLoop.st M OpalDecompiler.package/OCDecompilerConstructor.class/instance/constructor/codeArguments_temps_block_.st M OpalDecompiler.package/OCDecompilerConstructor.class/instance/constructor/codeMethod_block_tempVars_primitive_class_.st A OpalDecompiler.package/extension/RBAssignmentNode/instance/toDoIncrement_.st M OpalDecompiler.package/extension/RBMessageNode/instance/toDoFromWhileWithInit_.st A OpalDecompiler.package/extension/RBMessageNode/instance/toDoIncrement_.st A OpalDecompiler.package/extension/RBMessageNode/instance/toDoLimit_.st A OpalDecompiler.package/extension/RBProgramNode/instance/toDoIncrement_.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/classClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/classInstanceVariableClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/classVariableClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/commentClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/globalVariableClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/instanceVariableClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/metaclassClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/metatraitClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/methodClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/poolVariableClass.st R Ring-Core-Kernel.package/RGFactory.class/instance/class factory/traitClass.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createClassInstanceVariableNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createClassVariableNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createGlobalVariableNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createInstanceVariableNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createInstanceVariableNamed_parent_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createPoolVariableNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory-variable/createSharedPoolNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createClassNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createComment.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createMetaclassOf_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createMetatraitNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createMetatraitOf_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createMethodNamed_.st M Ring-Core-Kernel.package/RGFactory.class/instance/factory/createTraitNamed_.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script138.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40138.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40138 13728 Decompiler and OCDecompiler cannot decompile returning loops https://pharo.fogbugz.com/f/cases/13728 13731 RGFactory cleanup: Ring definition class method in RGFactory can be inlined https://pharo.fogbugz.com/f/cases/13731 13729 3 menu item to generate inst var accessors https://pharo.fogbugz.com/f/cases/13729 http://files.pharo.org/image/40/40138.zip
GitHub wrote
13729 3 menu item to generate inst var accessors https://pharo.fogbugz.com/f/cases/13729
I left a comment in the issue, but maybe no one is checking there since it's closed...
From the original comment: There is currently 3 menu items to generate iv accessors: Analyse > Create inst var accessors Refactoring > Class Refactoring > Generate accessors Refactoring > Inst Var Refactoring > Accessors
Each one has it's own underlying logic. I keep the second that has a shortcut associated and remove the two others. Please put back #3. It is a different use case. #2 is a batch operation adding accessors for all inst vars. #3 adds accessors for one inst var. When many inst vars are involved, it is tedious to deselect all the other accessors... The main problem was not that there was multiple options, but that they were poorly organized (see http://forum.world.st/Nautilus-accessor-over-generation-td4679480.html) ----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-ea9df7-40138-tp4770903p477172... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
sean add an entry and assign to camille. We got confused with igor and it took us a while to find. I think that the implementation in Analyse was not necessary. (so probably having 2 and 3 is ok) even if I never saw the difference. Stef On 4/8/14 15:08, Sean P. DeNigris wrote:
GitHub wrote
13729 3 menu item to generate inst var accessors https://pharo.fogbugz.com/f/cases/13729 I left a comment in the issue, but maybe no one is checking there since it's closed...
From the original comment: There is currently 3 menu items to generate iv accessors: Analyse > Create inst var accessors Refactoring > Class Refactoring > Generate accessors Refactoring > Inst Var Refactoring > Accessors
Each one has it's own underlying logic. I keep the second that has a shortcut associated and remove the two others.
Please put back #3. It is a different use case. #2 is a batch operation adding accessors for all inst vars. #3 adds accessors for one inst var. When many inst vars are involved, it is tedious to deselect all the other accessors...
The main problem was not that there was multiple options, but that they were poorly organized (see http://forum.world.st/Nautilus-accessor-over-generation-td4679480.html)
----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-ea9df7-40138-tp4770903p477172... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
stepharo wrote
add an entry and assign to camille.
Done https://pharo.fogbugz.com/default.asp?13770 ----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-ea9df7-40138-tp4770903p477177... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Thanks you could also provide code :) Stef On 4/8/14 23:04, Sean P. DeNigris wrote:
stepharo wrote
add an entry and assign to camille. Done https://pharo.fogbugz.com/default.asp?13770
----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-ea9df7-40138-tp4770903p477177... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
stepharo wrote
you could also provide code :)
Nicolai beat me to it :) https://pharo.fogbugz.com/default.asp?13770#BugEvent.106854 ----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-ea9df7-40138-tp4770903p477180... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (3)
-
GitHub -
Sean P. DeNigris -
stepharo