SLICE-Issue-12179-Nautilus-Add-package-filter-input-box
Hi! I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1 I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive. Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On 24 Nov 2013, at 15:17, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
The issue was closed by the author: https://pharo.fogbugz.com/f/cases/12179 Therefore I guess he has reasons not to want it in Pharo in the current state. Marcus
I guess Juraj closed the issue because he though he has to since he provided a slice. Juraj, can you reopen the issue? Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. On Nov 24, 2013, at 11:21 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On 24 Nov 2013, at 15:17, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
The issue was closed by the author:
https://pharo.fogbugz.com/f/cases/12179
Therefore I guess he has reasons not to want it in Pharo in the current state.
Marcus
On 24 Nov 2013, at 15:35, Alexandre Bergel <alexandre.bergel@me.com> wrote:
I guess Juraj closed the issue because he though he has to since he provided a slice.
An issue that is closed is done and will never be looked at again. Closed means âthis is done, thanks, no work needed anymoreâ. Marcus
On 2013-11-24, at 15:43, Marcus Denker <marcus.denker@inria.fr> wrote:
On 24 Nov 2013, at 15:35, Alexandre Bergel <alexandre.bergel@me.com> wrote:
I guess Juraj closed the issue because he though he has to since he provided a slice.
An issue that is closed is done and will never be looked at again. Closed means âthis is done, thanks, no work needed anymoreâ.
as described here: https://pharo.fogbugz.com/default.asp?W46
Thank you for the link. Jura El 24-11-2013, a las 11:56, Camillo Bruni <camillobruni@gmail.com> escribió:
On 2013-11-24, at 15:43, Marcus Denker <marcus.denker@inria.fr> wrote:
On 24 Nov 2013, at 15:35, Alexandre Bergel <alexandre.bergel@me.com> wrote:
I guess Juraj closed the issue because he though he has to since he provided a slice.
An issue that is closed is done and will never be looked at again. Closed means âthis is done, thanks, no work needed anymoreâ.
as described here: https://pharo.fogbugz.com/default.asp?W46
I will have a look at it :) I want that too. Stef On Nov 24, 2013, at 3:16 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Thank you Stéphane! :-) Jura El 24-11-2013, a las 13:56, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
I will have a look at it :) I want that too.
Stef
On Nov 24, 2013, at 3:16 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Hi Alexandre! Stéphane have just integrated it. You can download latest version and use it :-) Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test Basically if someone writes regular expression which is not valid, it displays all packages. Cheers, Jura El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Cool. Juraj could you fix the layout because it is not aligned and a bit too high, it should be probably based on the default font. Stef On Nov 24, 2013, at 9:15 PM, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
Hi Alexandre!
Stéphane have just integrated it. You can download latest version and use it :-)
Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test
Basically if someone writes regular expression which is not valid, it displays all packages.
Cheers, Jura
El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
I would like, but I have not found out how. I will take care of it and ask in mailing list. Anyway, I am not sure if it was well integrated. I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line ^ firstColumn := PanelMorph new it should be without instance variable: ^ PanelMorph new Thanks, Jura El 24-11-2013, a las 17:21, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
Cool. Juraj could you fix the layout because it is not aligned and a bit too high, it should be probably based on the default font.
Stef On Nov 24, 2013, at 9:15 PM, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
Hi Alexandre!
Stéphane have just integrated it. You can download latest version and use it :-)
Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test
Basically if someone writes regular expression which is not valid, it displays all packages.
Cheers, Jura
El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On 24 Nov 2013, at 21:29, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated. I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
^ firstColumn := PanelMorph new
it should be without instance variable:
^ PanelMorph new
If you would have put the status on âFix review neededâ the monkey would have found this⦠The reason is that there was a code critic clean done of Nautilus where the critic tools found that firstColumn was just assigned and never read. Therefore it was possible to just remove it (and secondColumn). This change was done after you did your Slice⦠therefore your code was right when it was done but out-dated in the meantime. (itâs easy to fix *and* it was catcher by the tests⦠so nothing bad happened) Marcus
Ok, thank you Marcus. Jura El 24-11-2013, a las 17:36, Marcus Denker <marcus.denker@inria.fr> escribió:
On 24 Nov 2013, at 21:29, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated. I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
^ firstColumn := PanelMorph new
it should be without instance variable:
^ PanelMorph new
If you would have put the status on âFix review neededâ the monkey would have found thisâ¦
The reason is that there was a code critic clean done of Nautilus where the critic tools found that firstColumn was just assigned and never read. Therefore it was possible to just remove it (and secondColumn).
This change was done after you did your Slice⦠therefore your code was right when it was done but out-dated in the meantime.
(itâs easy to fix *and* it was catcher by the tests⦠so nothing bad happened)
Marcus
submit a fix.
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated.
There was a conflict and I fully loaded your code. So I do not see how it could be different. But with computer science everything is possible.
I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
^ firstColumn := PanelMorph new
it should be without instance variable:
^ PanelMorph new
Thanks, Jura
El 24-11-2013, a las 17:21, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
Cool. Juraj could you fix the layout because it is not aligned and a bit too high, it should be probably based on the default font.
Stef On Nov 24, 2013, at 9:15 PM, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
Hi Alexandre!
Stéphane have just integrated it. You can download latest version and use it :-)
Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test
Basically if someone writes regular expression which is not valid, it displays all packages.
Cheers, Jura
El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
The slice SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.3 already contains the fix. But whenever I try to merge with the image 30593, it says merge conflict. The solution is to say "Use incoming versionâ. I do not know how to do it better. Cheers, Jura El 24-11-2013, a las 17:38, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
submit a fix.
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated.
There was a conflict and I fully loaded your code. So I do not see how it could be different. But with computer science everything is possible.
I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
^ firstColumn := PanelMorph new
it should be without instance variable:
^ PanelMorph new
Thanks, Jura
El 24-11-2013, a las 17:21, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
Cool. Juraj could you fix the layout because it is not aligned and a bit too high, it should be probably based on the default font.
Stef On Nov 24, 2013, at 9:15 PM, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
Hi Alexandre!
Stéphane have just integrated it. You can download latest version and use it :-)
Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test
Basically if someone writes regular expression which is not valid, it displays all packages.
Cheers, Jura
El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On 24 Nov 2013, at 21:46, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
The slice SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.3 already contains the fix. But whenever I try to merge with the image 30593, it says merge conflict. The solution is to say "Use incoming versionâ. I do not know how to do it better.
As soon as an issue is integrated, it is better to submit a new change (new issue) based on the new image. Much easier to handle. Marcus
OK. I will. Jura El 24-11-2013, a las 17:47, Marcus Denker <marcus.denker@inria.fr> escribió:
On 24 Nov 2013, at 21:46, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
The slice SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.3 already contains the fix. But whenever I try to merge with the image 30593, it says merge conflict. The solution is to say "Use incoming versionâ. I do not know how to do it better.
As soon as an issue is integrated, it is better to submit a new change (new issue) based on the new image. Much easier to handle.
Marcus
On 24 Nov 2013, at 21:38, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
submit a fix.
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated.
There was a conflict and I fully loaded your code. So I do not see how it could be different. But with computer science everything is possible.
Why loading it if there was a conflict ? Ben
I have just downloaded image 30593 and I can see in PackageTreeNautilusUI>>buildFirstColumn: line
^ firstColumn := PanelMorph new
it should be without instance variable:
^ PanelMorph new
Thanks, Jura
El 24-11-2013, a las 17:21, Stéphane Ducasse <stephane.ducasse@inria.fr> escribió:
Cool. Juraj could you fix the layout because it is not aligned and a bit too high, it should be probably based on the default font.
Stef On Nov 24, 2013, at 9:15 PM, Juraj Kubelka <juraj.kubelka@gmail.com> wrote:
Hi Alexandre!
Stéphane have just integrated it. You can download latest version and use it :-)
Just to let you know. You can write regular expressions in the input field. An useful example can be (everything is case insensitive): ^Roassal ⦠packages which start by name Roassal ^Roassal|Mondrian ⦠packages which start by name Roassal or contains name Mondrian (there is pipe | between the words) ^(Roassal|Mondrian) ^Roassal|^Mondrian ⦠packages which start by name Roassal or by name Mondrian ^Ro.*Test ⦠any package which start by name Ro and contains word Test
Basically if someone writes regular expression which is not valid, it displays all packages.
Cheers, Jura
El 24-11-2013, a las 11:16, Alexandre Bergel <alexandre.bergel@me.com> escribió:
Hi!
I think the following should be part of Pharo: SLICE-Issue-12179-Nautilus-Add-package-filter-input-box-JurajKubelka.1
I have been using for some times already and it works pretty well. I have also reviewed the code. This slice makes me much much more productive.
Cheers, Alexandre
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated.
There was a conflict and I fully loaded your code. So I do not see how it could be different. But with computer science everything is possible.
Why loading it if there was a conflict ?
Do you really think that as an integrator we never chose which method to integrate and that we never handle conflicts? The version I selected is correct and working this is just an unused variable. Now if you want I can also stop looking at any bug entry and stop to integrate fix and focus on my own project. You will see if will take more time to get things integrated and do not believe that automatically validated means something when we are talking about certain aspects of the system. No need to rant that nobody take cares of integrating bugs. Living is taking action. Stef
I would have been more efficient to wait till a new slice is proposed. If you want to focus on you project instead of loosing time resolving conflicts about thing you do not have knowledge about I think a good way to save time is to let people knowing resolving merge conflict, aka the guy who proposed a fix. Otherwise, you (and any integrator) will have to know everything about the whole system, and this will never happen. The monkey is here to show the contributors that what they propose is not working properly. Loading slices with conflicts can only lead to reverting code. And doing the same things again and again when you think it is in the system is far worse that proposing a new version up to date of a slice, since usually the feedback provided by the infrastructure takes a couple of minute while chasing accidentally rollback fixes may take much longer. Ben On 24 Nov 2013, at 22:02, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I would like, but I have not found out how. I will take care of it and ask in mailing list.
Anyway, I am not sure if it was well integrated.
There was a conflict and I fully loaded your code. So I do not see how it could be different. But with computer science everything is possible.
Why loading it if there was a conflict ?
Do you really think that as an integrator we never chose which method to integrate and that we never handle conflicts? The version I selected is correct and working this is just an unused variable.
Now if you want I can also stop looking at any bug entry and stop to integrate fix and focus on my own project. You will see if will take more time to get things integrated and do not believe that automatically validated means something when we are talking about certain aspects of the system. No need to rant that nobody take cares of integrating bugs.
Living is taking action.
Stef
participants (6)
-
Alexandre Bergel -
Benjamin -
Camillo Bruni -
Juraj Kubelka -
Marcus Denker -
Stéphane Ducasse