Hi guys I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha. So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL. Cheers, -- Mariano http://marianopeck.wordpress.com
On Jul 10, 2013, at 10:04 PM, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi guys
I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha.
So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL.
Hi mariano I think that this is important that you allocate a certain percentage of your dev time to improve the tools you use else there is no possibility of progress. I would not wait for a student to fix code that nobody in our team (except esteban probably) ever used. Stef
Cheers,
-- Mariano http://marianopeck.wordpress.com
I do agree. But notice that it took me like 2 days to adapt the pool to the native driver, find the problems, fix the bugs, commit fixed, update the confs, etc. So that was already something :) On Thu, Jul 11, 2013 at 4:14 AM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
On Jul 10, 2013, at 10:04 PM, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi guys
I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha.
So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL.
Hi mariano
I think that this is important that you allocate a certain percentage of your dev time to improve the tools you use else there is no possibility of progress. I would not wait for a student to fix code that nobody in our team (except esteban probably) ever used.
Stef
Cheers,
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
On Jul 11, 2013, at 3:52 PM, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
I do agree. But notice that it took me like 2 days to adapt the pool to the native driver, find the problems, fix the bugs, commit fixed, update the confs, etc. So that was already something :)
Indeed :) Stef
On Thu, Jul 11, 2013 at 4:14 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Jul 10, 2013, at 10:04 PM, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi guys
I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha.
So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL.
Hi mariano
I think that this is important that you allocate a certain percentage of your dev time to improve the tools you use else there is no possibility of progress. I would not wait for a student to fix code that nobody in our team (except esteban probably) ever used.
Stef
Cheers,
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
What is the configuration I should load to get the latest Glorp + PostgreSQL? Esteban A. Maringolo 2013/7/10 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi guys
I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha.
So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL.
Cheers,
-- Mariano http://marianopeck.wordpress.com
If by PostgresSQL you mean the native driver (not OpenDBXDriver), then in my conf I load from ' http://www.smalltalkhub.com/mc/DBXTalk/Configurations/main' (ConfigurationOfGlorpDBX project version: '2.8') load: #('GlorpPostgresV2NativeWithTests' ). That should work. On Thu, Jul 11, 2013 at 9:27 AM, Esteban A. Maringolo <emaringolo@gmail.com>wrote:
What is the configuration I should load to get the latest Glorp + PostgreSQL? Esteban A. Maringolo
2013/7/10 Mariano Martinez Peck <marianopeck@gmail.com>:
Hi guys
I did a couple of things related to Glorp. I commited 2 fixes related to the connection pool. Also, for the native postgres driver, I adapted the pool we have for OpenDBXDriver. It's quite ugly because we are duplicating quite a lot of code, but the hierarchy make things complicated here and I don't have more time to improve it (at least not right now). If someone wants to give it a shoot :) You can give it as an exercise to a student hahaha.
So...to sum up, some fixes in GlorpOpenDBXDriver and the new connection pool to GlorpDriverPostgreSQL.
Cheers,
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
participants (3)
-
Esteban A. Maringolo -
Mariano Martinez Peck -
Stéphane Ducasse