[Pharo-project] cleaning/completing ConfigurationOfPetitParser
Hi, I'm looking at ConfigurationOfPetitParser and wondering if #minimal: and #default: are really needed. Shouldn't those be groups in the baseline, or symbolicVersions loading subsets of packages ? Also, there are dependencies missing. For instance PetitSmalltalk depends on AST-Core, and IMHO this is the responsibility of ConfigurationOfPetitParser to declare that, even if PetitSmalltalk is not loaded by a ConfigurationOfPetitParser load. Also, why are there less class methods than on other ConfigurationOf... ? -- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
Shouldn't those be groups in the baseline, or symbolicVersions loading subsets of packages ?
Don't know :-)
Also, there are dependencies missing. For instance PetitSmalltalk depends on AST-Core, and IMHO this is the responsibility of ConfigurationOfPetitParser to declare that, even if PetitSmalltalk is not loaded by a ConfigurationOfPetitParser load.
Indeed, AST-Core is a dependency of PetitSmalltalk. Also Glamour is a dependency of PetitGUI. Both packages probably shouldn't be loaded by default.
Also, why are there less class methods than on other ConfigurationOf... ?
Don't know, probably nobody bothered to update the configurations. Feel free to fix them :-) Lukas -- Lukas Renggli www.lukas-renggli.ch
On 7 August 2011 18:14, Lukas Renggli <renggli@gmail.com> wrote:
Indeed, AST-Core is a dependency of PetitSmalltalk. Also Glamour is a dependency of PetitGUI. Both packages probably shouldn't be loaded by default.
The Glamour sep is already described. I added PetitSmalltalk and committed. I'll do others on demand.
Also, why are there less class methods than on other ConfigurationOf... ?
Don't know, probably nobody bothered to update the configurations. Feel free to fix them :-)
I need to read the Metacello chapter first :) -- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
On Aug 7, 2011, at 8:03 PM, Damien Pollet wrote:
On 7 August 2011 18:14, Lukas Renggli <renggli@gmail.com> wrote:
Indeed, AST-Core is a dependency of PetitSmalltalk. Also Glamour is a dependency of PetitGUI. Both packages probably shouldn't be loaded by default.
The Glamour sep is already described. I added PetitSmalltalk and committed. I'll do others on demand.
Also, why are there less class methods than on other ConfigurationOf... ?
Don't know, probably nobody bothered to update the configurations. Feel free to fix them :-)
I need to read the Metacello chapter first :)
please directly add your remarks on the git file. My gut feeling is that we should get an executive summary of this large chapter.
-- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
participants (3)
-
Damien Pollet -
Lukas Renggli -
Stéphane Ducasse