ClassCommented announcement missing
Someone knows why ClassCommented-announcements aren't announced during a mc package load ? see: 15190 <https://pharo.fogbugz.com/default.asp?15190> Nautilus incorrectly flags Error classes as "missing class comments" and SlotClassBuilder>>#build .... SystemAnnouncer uniqueInstance suspendAllWhile: [ comment ifNotNil: [result classComment: comment stamp: commentStamp]]. .... nicolai
Hi nicolai I do not know. this looks strange to me. Stef Le 21/3/15 15:01, Nicolai Hess a écrit :
Someone knows why ClassCommented-announcements aren't announced during a mc package load ?
see: 15190 <https://pharo.fogbugz.com/default.asp?15190> Nautilus incorrectly flags Error classes as "missing class comments"
and SlotClassBuilder>>#build
.... SystemAnnouncer uniqueInstance suspendAllWhile: [ comment ifNotNil: [result classComment: comment stamp: commentStamp]]. ....
nicolai
Copying a class in Nautilus also isn't copying the class comment in 3.0 Phil Le 21 mars 2015 15:46, "stepharo" <stepharo@free.fr> a écrit :
Hi nicolai
I do not know. this looks strange to me.
Stef
Le 21/3/15 15:01, Nicolai Hess a écrit :
Someone knows why ClassCommented-announcements aren't announced during a mc package load ?
see: 15190 <https://pharo.fogbugz.com/default.asp?15190> Nautilus incorrectly flags Error classes as "missing class comments"
and SlotClassBuilder>>#build
.... SystemAnnouncer uniqueInstance suspendAllWhile: [ comment ifNotNil: [result classComment: comment stamp: commentStamp]]. ....
nicolai
I know why! The old class builder did not have an API to set the comment when building or changing a class. So Monticello actually created the class and *then* it explicitly set a comment. When I did the change to support Slot definitions, I moved MC over to the new API and set the comment directly when creating the class. (Interesting how simple the code gotâ¦). So this means that in the past MC never used the class builder to set the comment⦠or maybe in some cases, the comment change was even announced double? I think we an just remove the #suspendAllWhile: guard.
On 21 Mar 2015, at 15:01, Nicolai Hess <nicolaihess@web.de> wrote:
Someone knows why ClassCommented-announcements aren't announced during a mc package load ?
see: 15190 <https://pharo.fogbugz.com/default.asp?15190> Nautilus incorrectly flags Error classes as "missing class comments"
and SlotClassBuilder>>#build
.... SystemAnnouncer uniqueInstance suspendAllWhile: [ comment ifNotNil: [result classComment: comment stamp: commentStamp]].
participants (4)
-
Marcus Denker -
Nicolai Hess -
phil@highoctane.be -
stepharo