Re: [Pharo-project] Issue 3179 in pharo: Failing Tests for Monticello
Comment #1 on issue 3179 by marcus.denker: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 Current state:
Tests.Monticello.MCChangeNotificationTest.testExtMethodModified 0.0050 50 Tests.Monticello.MCPackageTest.testUnload 0.636 50
The Tests.Monticello.MCPackageTest.testUnload only fails on Hudson.
Comment #2 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 see Issue 2294
Updates: Labels: Milestone-1.3 Comment #3 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 (No comment was entered for this change.)
Comment #4 on issue 3179 by cy.delau...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 I join a changeSet that make all monticello test green. For that, I made the fix provided by stephane in issue 2294 (see above), and fix the remaining test: MCChangeNotificationTest >> testExtMethodModified. That's the method I modified to solve the problem: mockClassExtension "I change the protocol of this method (to be '*monticellomocks' instead of 'mocks') to resolve the failing test: MCChangeNotificationTest >> testExtMethodModified. This test basically test that when we modified an extension method, the extended package is marked as 'modified'. The problem is that Monticello treat differently a classic method from an extension method, and this only by checking if the protocol name start with a star. Therefore, if the protocol does not match the extending package name, the extending package name will never be notified, and the test will fail. " Attachments: issue3179.1.cs 3.1 KB
Updates: Status: Fixed Comment #5 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 12317 TODO: 1.3
Updates: Status: Closed Comment #6 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 13008
Comment #7 on issue 3179 by cy.delau...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 I join a change set to fix the failing test in hudson Tests.Monticello.MCPackageTest.testUnload. To solve the problem, I added the following setUp method in MCPackageTest: setUp "here we have to make sure that there is no packae named Monticellomock left, so that no old package interfer with the test." MCWorkingCopy registry removeKey: (MCPackage new name: 'Monticellomocks') ifAbsent:[]. PackageOrganizer default unregisterPackageNamed: 'Monticellomocks'. Attachments: FixingMonticelloTestFailingInHudson.1.cs 1.5 KB
Updates: Status: Fixed Labels: -Milestone-1.2 Comment #8 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 I added it to 1.2... TODO: add FixingMonticelloTestFailingInHudson.1.cs to 1.3 (and on close tag this report 1.2 again)
Updates: Status: Closed Labels: Milestone-1.2 Comment #9 on issue 3179 by marcus.d...@gmail.com: Failing Tests for Monticello http://code.google.com/p/pharo/issues/detail?id=3179 13015
participants (1)
-
pharo@googlecode.com