[Review]: Case 12737 Morph sends mouseUp twice to handlers
https://pharo.fogbugz.com/default.asp?12737 DoIt: Morph new on: #mouseUp send: #inspect to: 1; openInWorld. Two inspectors will appear. Fix in inbox: SLICE-Issue-12737-Morph-sends-mouseUp-twice-to-handlers-SeanDeNigris.1 Please review. It definitely fixes the problem, but it fiddles around inside Morphic so... Test included - fails before, passes after ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Thanks It reminds a really strange bug I got showing that there were hidden useless calls. but I cannot find if I entered an entry. Any idea how I can find the entries that I added to fogbogz Setf On 29 Jan 2014, at 02:47, Sean P. DeNigris <sean@clipperadams.com> wrote:
https://pharo.fogbugz.com/default.asp?12737
DoIt: Morph new on: #mouseUp send: #inspect to: 1; openInWorld. Two inspectors will appear.
Fix in inbox: SLICE-Issue-12737-Morph-sends-mouseUp-twice-to-handlers-SeanDeNigris.1 Please review. It definitely fixes the problem, but it fiddles around inside Morphic so... Test included - fails before, passes after
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Filters > My case s(2nd item) Ben On 29 Jan 2014, at 18:05, Pharo4Stef <pharo4Stef@free.fr> wrote:
Thanks It reminds a really strange bug I got showing that there were hidden useless calls. but I cannot find if I entered an entry. Any idea how I can find the entries that I added to fogbogz
Setf On 29 Jan 2014, at 02:47, Sean P. DeNigris <sean@clipperadams.com> wrote:
https://pharo.fogbugz.com/default.asp?12737
DoIt: Morph new on: #mouseUp send: #inspect to: 1; openInWorld. Two inspectors will appear.
Fix in inbox: SLICE-Issue-12737-Morph-sends-mouseUp-twice-to-handlers-SeanDeNigris.1 Please review. It definitely fixes the problem, but it fiddles around inside Morphic so... Test included - fails before, passes after
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On 29 Jan 2014, at 22:12, Benjamin <Benjamin.VanRyseghem.Pharo@gmail.com> wrote:
Filters > My case s(2nd item)
Thanks! I found using the customize and I started to review my bug entries and close some of them. I will check the list because I remember that I totally puzzled by the behavior I got.
Ben
On 29 Jan 2014, at 18:05, Pharo4Stef <pharo4Stef@free.fr> wrote:
Thanks It reminds a really strange bug I got showing that there were hidden useless calls. but I cannot find if I entered an entry. Any idea how I can find the entries that I added to fogbogz
Setf On 29 Jan 2014, at 02:47, Sean P. DeNigris <sean@clipperadams.com> wrote:
https://pharo.fogbugz.com/default.asp?12737
DoIt: Morph new on: #mouseUp send: #inspect to: 1; openInWorld. Two inspectors will appear.
Fix in inbox: SLICE-Issue-12737-Morph-sends-mouseUp-twice-to-handlers-SeanDeNigris.1 Please review. It definitely fixes the problem, but it fiddles around inside Morphic so... Test included - fails before, passes after
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
thanks this is indeed nice to be able to spot the one we viewed too. On 30 Jan 2014, at 13:25, btc@openinworld.com wrote:
Stef, A little different than you asked for, but I find the following combination useful when I'm trying to find a case that I recently viewed that was opened by someone else: * Viewed by me - Show only cases I have viewed before * Sort By - Last viewed by me (Reverse)
cheers -ben
Benjamin wrote:
Sean P. DeNigris wrote
I did a safer fix which is much less likely to break other things and still fixes the problem. Two people looked at it and the monkey validated it. Should I "Fix to include" or would a core dev like to have a quick look first. I'm being extra cautious because it is inside Morphic... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Do we put in in 3.0? Because changing Morphic now sounds a bit shaky to me :) Ben On 01 Feb 2014, at 22:55, Sean P. DeNigris <sean@clipperadams.com> wrote:
Sean P. DeNigris wrote
I did a safer fix which is much less likely to break other things and still fixes the problem. Two people looked at it and the monkey validated it. Should I "Fix to include" or would a core dev like to have a quick look first. I'm being extra cautious because it is inside Morphic...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Feb 1, 2014, at 5:04 PM, "Benjamin Van Ryseghem-2 [via Smalltalk]" <ml-node+s1294792n4740926h94@n4.nabble.com> wrote:
Do we put in in 3.0?
Because changing Morphic now sounds a bit shaky to me :) That's why I'm asking for a lot of input. But it is a bug. And I think this slice version is very unlikely to break anything - 2 lines changed. I'd at least appreciate someone taking a look. If you agree that it's a straight-forward change, I will take responsibility for getting it right or reverting.
----- Cheers, Sean -- View this message in context: http://forum.world.st/Review-Case-12737-Morph-sends-mouseUp-twice-to-handler... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
I will have a look tomorrow :) (right now, with the jet lag and the very long flight, I do not trust my brain :) ) Ben On 01 Feb 2014, at 23:07, Sean P. DeNigris <sean@clipperadams.com> wrote:
On Feb 1, 2014, at 5:04 PM, "Benjamin Van Ryseghem-2 [via Smalltalk]" <[hidden email]> wrote:
Do we put in in 3.0?
Because changing Morphic now sounds a bit shaky to me :) That's why I'm asking for a lot of input. But it is a bug. And I think this slice version is very unlikely to break anything - 2 lines changed. I'd at least appreciate someone taking a look. If you agree that it's a straight-forward change, I will take responsibility for getting it right or reverting.
Cheers, Sean
View this message in context: Re: [Review]: Case 12737 Morph sends mouseUp twice to handlers Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Well did we lived perfectly with it over last year? yes -> 40 no -> 30
Because changing Morphic now sounds a bit shaky to me :)
That's why I'm asking for a lot of input. But it is a bug. And I think this slice version is very unlikely to break anything - 2 lines changed. I'd at least appreciate someone taking a look. If you agree that it's a straight-forward change, I will take responsibility for getting it right or reverting.
Cheers, Sean
View this message in context: Re: [Review]: Case 12737 Morph sends mouseUp twice to handlers Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Benjamin -
btc＠openinworld.com -
Pharo4Stef -
Sean P. DeNigris