[Pharo-project] Tests are back to dark red :(
I run all the tests in #10231: 2910 run, 23 failures, 33 errors Many of the errors and failures are from PCCByLiteralsTest. Was this introduced recently? Are these tests supposed to run green? Please help to improve the test results. Some time ago we managed to get down to only 5 or so failures, now we are back at 56 errors and failures! Cheers, Adrian PS: there are also Undeclared references and the tests don't run through because a method was deprecated that is still called. ___________________ http://www.adrian-lienhard.ch/
Many of the errors and failures are from PCCByLiteralsTest. Was this introduced recently? Are these tests supposed to run green?
I already thought that this was because of my ByteArray patch ;-) However, if you individually run the PCC tests in a clean image they all pass. It is the side-effect of another test, presumably TestObjectsAsMethods that fails and does not clean-up after itself. Now why does TestObjectsAsMethods fail? It looks like this is related to a change in TestCase>>#methodChanged: that hooks into the change notification system. Looks like you did that change yourself ;-) Lukas -- Lukas Renggli http://www.lukas-renggli.ch
Thanks for looking into this. There were two problems. First the TestMethodsAsObjects did not clean up correctly as you noted. Second, TestCase>>#methodChanged: did not expect an object as a method---neither did the PCC tests. I committed the following two changes to the Inbox to fix this: Name: Tests-al.40 Clean up TestObjectsAsMethods (do a proper tearDown) Name: SUnit-al.59 Make edge case where method is an object work. ---- Now we are back to 13 failures and 4 errors. That's already much better. An interesting test failure is [Wide]StringTest>>#testAsInteger '-94' asInteger --> 94. I could trace this back to a change in PositionableStream>>#back by Damien Cassous. Damien, could you have a look? Cheers, Adrian BTW: I'm just the author of #methodChanged: because I had fixed another problem in this method ;) On Feb 9, 2009, at 19:33 , Lukas Renggli wrote:
Many of the errors and failures are from PCCByLiteralsTest. Was this introduced recently? Are these tests supposed to run green?
I already thought that this was because of my ByteArray patch ;-)
However, if you individually run the PCC tests in a clean image they all pass. It is the side-effect of another test, presumably TestObjectsAsMethods that fails and does not clean-up after itself.
Now why does TestObjectsAsMethods fail? It looks like this is related to a change in TestCase>>#methodChanged: that hooks into the change notification system. Looks like you did that change yourself ;-)
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I could help a bit to get all the test green But I'm buzzy. Stef On Feb 9, 2009, at 9:03 PM, Adrian Lienhard wrote:
Thanks for looking into this.
There were two problems. First the TestMethodsAsObjects did not clean up correctly as you noted. Second, TestCase>>#methodChanged: did not expect an object as a method---neither did the PCC tests.
I committed the following two changes to the Inbox to fix this:
Name: Tests-al.40 Clean up TestObjectsAsMethods (do a proper tearDown)
Name: SUnit-al.59 Make edge case where method is an object work.
----
Now we are back to 13 failures and 4 errors. That's already much better.
An interesting test failure is [Wide]StringTest>>#testAsInteger '-94' asInteger --> 94. I could trace this back to a change in PositionableStream>>#back by Damien Cassous. Damien, could you have a look?
Cheers, Adrian
BTW: I'm just the author of #methodChanged: because I had fixed another problem in this method ;)
On Feb 9, 2009, at 19:33 , Lukas Renggli wrote:
Many of the errors and failures are from PCCByLiteralsTest. Was this introduced recently? Are these tests supposed to run green?
I already thought that this was because of my ByteArray patch ;-)
However, if you individually run the PCC tests in a clean image they all pass. It is the side-effect of another test, presumably TestObjectsAsMethods that fails and does not clean-up after itself.
Now why does TestObjectsAsMethods fail? It looks like this is related to a change in TestCase>>#methodChanged: that hooks into the change notification system. Looks like you did that change yourself ;-)
Lukas
-- Lukas Renggli http://www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Mon, Feb 9, 2009 at 9:03 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
An interesting test failure is [Wide]StringTest>>#testAsInteger '-94' asInteger --> 94. I could trace this back to a change in PositionableStream>>#back by Damien Cassous. Damien, could you have a look?
Fixed, see: http://code.google.com/p/pharo/issues/detail?id=518 -- Damien Cassou http://damiencassou.seasidehosting.st
On Tue, Feb 10, 2009 at 9:17 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
On Mon, Feb 9, 2009 at 9:03 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
An interesting test failure is [Wide]StringTest>>#testAsInteger '-94' asInteger --> 94. I could trace this back to a change in PositionableStream>>#back by Damien Cassous. Damien, could you have a look?
Fixed, see: http://code.google.com/p/pharo/issues/detail?id=518
what is bad with the google bug-tracker is that "verified" issues are not shown anymore. One needs to explicitly search for them, wich in turn means they are overlooked very quickly (I always forget to search for them). Marcus -- Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
yes me too :) Stef On Feb 10, 2009, at 9:24 AM, Marcus Denker wrote:
On Tue, Feb 10, 2009 at 9:17 AM, Damien Cassou <damien.cassou@gmail.com
wrote: On Mon, Feb 9, 2009 at 9:03 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
An interesting test failure is [Wide]StringTest>>#testAsInteger '-94' asInteger --> 94. I could trace this back to a change in PositionableStream>>#back by Damien Cassous. Damien, could you have a look?
Fixed, see: http://code.google.com/p/pharo/issues/detail?id=518
what is bad with the google bug-tracker is that "verified" issues are not shown anymore. One needs to explicitly search for them, wich in turn means they are overlooked very quickly (I always forget to search for them).
Marcus
--
Marcus Denker -- denker@iam.unibe.ch http://www.iam.unibe.ch/~denker
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
what is bad with the google bug-tracker is that "verified" issues are not shown anymore. One needs to explicitly search for them, wich in turn means they are overlooked very quickly (I always forget to search for them).
You can change this in "Administer", "Issue Tracking" by moving the "Closed Issue Status Values" up to "Open Issue Status Values". Lukas -- Lukas Renggli http://www.lukas-renggli.ch
On Tue, Feb 10, 2009 at 9:39 AM, Lukas Renggli <renggli@gmail.com> wrote:
You can change this in "Administer", "Issue Tracking" by moving the "Closed Issue Status Values" up to "Open Issue Status Values".
Done, thank you Lukas -- Damien Cassou http://damiencassou.seasidehosting.st
participants (5)
-
Adrian Lienhard -
Damien Cassou -
Lukas Renggli -
Marcus Denker -
Stéphane Ducasse