30304 ----- 11234 LargeNegativeInteger inherits from LargePositiveInteger (part 2) https://pharo.fogbugz.com/f/cases/11234 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1539.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Fuel-MarcusDenker.772.diff
+1 for the spirit of this change, such inheritance was a nest of potential bugs I'll try to review the diffs when I can... 2013/7/26 Marcus Denker <marcus.denker@inria.fr>
30304 -----
11234 LargeNegativeInteger inherits from LargePositiveInteger (part 2) https://pharo.fogbugz.com/f/cases/11234
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1539.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Fuel-MarcusDenker.772.diff
On Jul 26, 2013, at 2:57 PM, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:
+1 for the spirit of this change, such inheritance was a nest of potential bugs I'll try to review the diffs when I can...
There is still now lots of duplicated methods in the hierarchy⦠we need to remove them in a final step.
2013/7/26 Marcus Denker <marcus.denker@inria.fr> 30304 -----
11234 LargeNegativeInteger inherits from LargePositiveInteger (part 2) https://pharo.fogbugz.com/f/cases/11234
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1539.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Fuel-MarcusDenker.772.diff
I have commited a rule (and a test) that checks for duplicated code in a hierarchy, it could be useful. 2013/7/26 Marcus Denker <marcus.denker@inria.fr>
On Jul 26, 2013, at 2:57 PM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
+1 for the spirit of this change, such inheritance was a nest of potential bugs I'll try to review the diffs when I can...
There is still now lots of duplicated methods in the hierarchy⦠we need to remove them in a final step.
2013/7/26 Marcus Denker <marcus.denker@inria.fr>
30304 -----
11234 LargeNegativeInteger inherits from LargePositiveInteger (part 2) https://pharo.fogbugz.com/f/cases/11234
Diff information:
http://smalltalkhub.com/mc/Pharo/Pharo30/main/Kernel-MarcusDenker.1539.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Fuel-MarcusDenker.772.diff
participants (3)
-
Marcus Denker -
Nicolas Cellier -
Sebastian Tleye