First attempt at submitting a simple contribution
Hi guys - Iâve tried to submit a very simple contribution for Pharo. I followed the steps in the video about submitting on Fogbugz - although I wonder if I missed a step by not asking for commit rights to the Pharo40Inbox? As I already had a smalltalk hub account - it asked for that name and password and it didnât complain when I entered them and pressed accept in Pharo. The issue is: 13653 Its a very simple contribution, just a class with some wiki help and the wiki method pragma to get it to appear in the System help. As I didnât know if there was already a class that might better hold this text, I created a new one - but happy to move it onto something else if there is somewhere obvious (or maybe its cleaner that it lives in its own place?). Tim
2014-07-22 17:48 GMT+02:00 Tim Mackinnon <tamackinnon@gmail.com>:
Hi guys - Iâve tried to submit a very simple contribution for Pharo. I followed the steps in the video about submitting on Fogbugz - although I wonder if I missed a step by not asking for commit rights to the Pharo40Inbox? As I already had a smalltalk hub account - it asked for that name and password and it didnât complain when I entered them and pressed accept in Pharo.
I think Marcus changed the access rights. pharo inbox is now publicy writeable.
The issue is: 13653
Its a very simple contribution, just a class with some wiki help and the wiki method pragma to get it to appear in the System help.
As I didnât know if there was already a class that might better hold this text, I created a new one - but happy to move it onto something else if there is somewhere obvious (or maybe its cleaner that it lives in its own place?).
Tim
Looks good. Some notes: I would change the title to "Pharo environment" or "Pharo Tools" or "First steps" or something like that. The shortcut list is not available in most browsers. Only in the default system browser. MessageBrowser, Finder, Monticello Browser ... don't have this. Topic "Searchlight": should be Spotlight There are some subtopics under "Workspace" that belong to the System browser. Changing the title and color of the system browser is an artefact of older (other) browsers. It doesn't work anymore. (the changes don't persist) A good collection of topics for newcomers. I like the descriptions of the icons and code pane color. As far as I know this was not documented elsewhere. nicolai
Thanks for the feedback, I will look at making those corrections/suggestions and resubmit. Tim -- View this message in context: http://forum.world.st/First-attempt-at-submitting-a-simple-contribution-tp47... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Thanks tim. Usually the monkey will tag your entry to ready to integrate and we harvest them. After this is also nice to write a comment saying that your change is ok in the latest image and we will integrate. We would like to change the integration process but we are not yet there. Git is needed first. We are getting more integrator: clement (on the compiler domain), nicolai and this is good. Sven is integrating changes related to the network Stef On 22/7/14 17:48, Tim Mackinnon wrote:
Hi guys - Iâve tried to submit a very simple contribution for Pharo. I followed the steps in the video about submitting on Fogbugz - although I wonder if I missed a step by not asking for commit rights to the Pharo40Inbox? As I already had a smalltalk hub account - it asked for that name and password and it didnât complain when I entered them and pressed accept in Pharo.
The issue is: 13653
Its a very simple contribution, just a class with some wiki help and the wiki method pragma to get it to appear in the System help.
As I didnât know if there was already a class that might better hold this text, I created a new one - but happy to move it onto something else if there is somewhere obvious (or maybe its cleaner that it lives in its own place?).
Tim
participants (3)
-
Nicolai Hess -
stepharo -
Tim Mackinnon