[Pharo-project] Henrik should we include Settings-Sound ?
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf cheers -- Mariano http://marianopeck.wordpress.com
it is not? Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
no On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
btw can you provide more context? You mean that it is not manage as a configuration but is referenced in pharo-dev conifguration ? On Apr 24, 2011, at 4:42 PM, Mariano Martinez Peck wrote:
no
On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
There is the repository http://www.squeaksource.com/PharoSound In that repo you will see a package "Settings-Sound" which is not included in ConfigurationOfPharoSound nor in any other place. Hence, it is not included in PharoDev. I am just wondering if we need to include such package or not. Henrik is the commiter of such packages so I asked. Cheers Mariano On Sun, Apr 24, 2011 at 4:53 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
btw can you provide more context? You mean that it is not manage as a configuration but is referenced in pharo-dev conifguration ?
On Apr 24, 2011, at 4:42 PM, Mariano Martinez Peck wrote:
no
On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote: it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
I do not remember the situation with the sound. I think that we should clean the soundService and the rest. But right now I'm trying to move on the package but this is a huge pain. Stef
There is the repository http://www.squeaksource.com/PharoSound In that repo you will see a package "Settings-Sound" which is not included in ConfigurationOfPharoSound nor in any other place. Hence, it is not included in PharoDev. I am just wondering if we need to include such package or not. Henrik is the commiter of such packages so I asked.
Cheers
Mariano
On Sun, Apr 24, 2011 at 4:53 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: btw can you provide more context? You mean that it is not manage as a configuration but is referenced in pharo-dev conifguration ?
On Apr 24, 2011, at 4:42 PM, Mariano Martinez Peck wrote:
no
On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
yes, but this package Setttings is only the integration with the Settings browser...that's why I think we should include it. cheers On Sun, Apr 24, 2011 at 5:42 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
I do not remember the situation with the sound. I think that we should clean the soundService and the rest. But right now I'm trying to move on the package but this is a huge pain.
Stef
There is the repository http://www.squeaksource.com/PharoSound In that repo you will see a package "Settings-Sound" which is not included in ConfigurationOfPharoSound nor in any other place. Hence, it is not included in PharoDev. I am just wondering if we need to include such package or not. Henrik is the commiter of such packages so I asked.
Cheers
Mariano
On Sun, Apr 24, 2011 at 4:53 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote: btw can you provide more context? You mean that it is not manage as a configuration but is referenced in pharo-dev conifguration ?
On Apr 24, 2011, at 4:42 PM, Mariano Martinez Peck wrote:
no
On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote: it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
ok go for it and we will see :) On Apr 24, 2011, at 5:44 PM, Mariano Martinez Peck wrote:
yes, but this package Setttings is only the integration with the Settings browser...that's why I think we should include it.
cheers
On Sun, Apr 24, 2011 at 5:42 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: I do not remember the situation with the sound. I think that we should clean the soundService and the rest. But right now I'm trying to move on the package but this is a huge pain.
Stef
There is the repository http://www.squeaksource.com/PharoSound In that repo you will see a package "Settings-Sound" which is not included in ConfigurationOfPharoSound nor in any other place. Hence, it is not included in PharoDev. I am just wondering if we need to include such package or not. Henrik is the commiter of such packages so I asked.
Cheers
Mariano
On Sun, Apr 24, 2011 at 4:53 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: btw can you provide more context? You mean that it is not manage as a configuration but is referenced in pharo-dev conifguration ?
On Apr 24, 2011, at 4:42 PM, Mariano Martinez Peck wrote:
no
On Sun, Apr 24, 2011 at 4:36 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: it is not?
Stef On Apr 24, 2011, at 3:57 PM, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
On 24.04.2011 15:57, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
Yes, in a version 4.0 for 1.1 and 1.3 together with Sound-MarianoMartinezPeck.65 , as soon as we revert some stuff that was done in base which broke it. IE. change registration back to working with instances, and soundEnabled to use a class var of SoundService rather than that of it's registered class. It will not work with the code based on branch from PharoTaskForces (Sound-MarianoMartinezPeck.64), as that one just deleted all preferences rather than preserve them in a functionally correct way. Cheers, Henry
but henrik I would not rever the change. If I remember correctly I change them because they were incorrect. Stef
On 24.04.2011 15:57, Mariano Martinez Peck wrote:
I saw that package in PharoSound and I wonder if it should be added to the Metacello conf
cheers
-- Mariano http://marianopeck.wordpress.com
Yes, in a version 4.0 for 1.1 and 1.3 together with Sound-MarianoMartinezPeck.65 , as soon as we revert some stuff that was done in base which broke it. IE. change registration back to working with instances, and soundEnabled to use a class var of SoundService rather than that of it's registered class.
It will not work with the code based on branch from PharoTaskForces (Sound-MarianoMartinezPeck.64), as that one just deleted all preferences rather than preserve them in a functionally correct way.
Cheers, Henry
On 26.04.2011 15:27, Stéphane Ducasse wrote: > but henrik I would not rever the change. > If I remember correctly I change them because they were incorrect. > > Stef No, they were not incorrect, you tried to sort out a dependency, which I tried to point out was just as well solved by changing the package structure. For example, now: - Changing "sound enabled" in the Settings Browser is now broken. - Backwards compatability with 1.0 and 1.1 for new packages based on the changes in core was broken, due to moving API from instance to class side. Cheers, Henry
On Apr 26, 2011, at 3:32 PM, Henrik Sperre Johansen wrote:
On 26.04.2011 15:27, Stéphane Ducasse wrote:
but henrik I would not rever the change. If I remember correctly I change them because they were incorrect.
Stef No, they were not incorrect, you tried to sort out a dependency, which I tried to point out was just as well solved by changing the package structure.
I'm not convinced and I do not have the time now to work on it. But I'm sure that this was not only the problem of the package structure. There was something fondamentally wrong in the way it was done.
For example, now: - Changing "sound enabled" in the Settings Browser is now broken. - Backwards compatability with 1.0 and 1.1 for new packages based on the changes in core was broken, due to moving API from instance to class side.
Cheers, Henry
participants (3)
-
Henrik Sperre Johansen -
Mariano Martinez Peck -
Stéphane Ducasse