[Pharo-project] Issue 3718 in pharo: Color class>>wheel: should be (back) on class side
Status: New Owner: ---- New issue 3718 by jbth...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 Color class>>wheel: has been erroneously moved to the instance side. It has no function on instances, but rather constructs and returns an Array of Color instances -- clearly a class-side method. It does not pass its own self-test in the comment now. Please put it back on class-side. (Indeed, half the current senders are still messaging the class. The other 5 or 6 senders send #red or #new for no reason, and should message the class).
Comment #1 on issue 3718 by jbth...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 UPDATE: Actually, it looks like there were *3* versions of wheel:, across both class and instance side: Color>>wheel: thisMany Color class>>wheel: thisMany Color class>>wheel: thisMany saturation: s brightness: v In 1.2rc2, only the first one is present, which returns a wheel starting from that color. The class versions return a wheel starting from hue 0. I consider the class-side versions conceptually distinct (ie. the Canonical Color Wheel) and valuable in themselves, but since they all go through the instance-side method, I can also see the argument for keeping only that method (in the interest of minimalism?). Squeak 4.1 still has all 3 methods. The Pharo code that is doing (Color new wheel:), looks like a "canonical" usage. In any case, if collapsing to 1 method, all the senders need to be cleaned up to consistently message the instance, and the test comment at the bottom fixed. For documentation, I note here the canonical Color class>>wheel: was effectively (Color h:0.0 s:0.9 v:0.7) wheel:
Updates: Status: accepted Labels: Milestone-1.3 Comment #2 on issue 3718 by stephane...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 This may be just a bug due to MC packaging. We something lost methods in the past after a recategorization
Comment #3 on issue 3718 by stephane...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 Please add a changeset or slice so that we can integrate it
Comment #4 on issue 3718 by jbth...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 Attached are 2 files with the 2 wheel: methods missing from the Color class side. Extracted from Squeak 4.1 Attachments: Color class-wheel.st 323 bytes Color class-wheelsaturationbrightness.st 485 bytes
Updates: Status: FixProposed Comment #5 on issue 3718 by marcus.d...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 (No comment was entered for this change.)
Updates: Status: Closed Comment #6 on issue 3718 by stephane...@gmail.com: Color class>>wheel: should be (back) on class side http://code.google.com/p/pharo/issues/detail?id=3718 in 13111
participants (1)
-
pharo＠googlecode.com