[Pharo-project] [update 2.0] #20446
20446 ----- Issue 7157: part two of LayoutFrame users rewriting http://code.google.com/p/pharo/issues/detail?id=7157 Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-StephaneDucasse.1005.diff http://ss3.gemstone.com/ss/Pharo20/System-Settings-StephaneDucasse.268.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Widgets-StephaneDucasse.75.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Examples-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Shout-StephaneDucasse.158.diff http://ss3.gemstone.com/ss/Pharo20/SUnit-UI-StephaneDucasse.52.diff http://ss3.gemstone.com/ss/Pharo20/Polymorph-Widgets-StephaneDucasse.747.dif... http://ss3.gemstone.com/ss/Pharo20/NewList-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Nautilus-StephaneDucasse.382.diff http://ss3.gemstone.com/ss/Pharo20/MorphicTests-StephaneDucasse.60.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-StephaneDucasse.1310.diff http://ss3.gemstone.com/ss/Pharo20/KeyChain-StephaneDucasse.22.diff http://ss3.gemstone.com/ss/Pharo20/FreeType-StephaneDucasse.607.diff
Ahh, I love the smell of massive refactorings ;-) Great work ! -- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill On 20 Dec 2012, at 15:36, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
20446 -----
Issue 7157: part two of LayoutFrame users rewriting http://code.google.com/p/pharo/issues/detail?id=7157
Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-StephaneDucasse.1005.diff http://ss3.gemstone.com/ss/Pharo20/System-Settings-StephaneDucasse.268.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Widgets-StephaneDucasse.75.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Examples-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Shout-StephaneDucasse.158.diff http://ss3.gemstone.com/ss/Pharo20/SUnit-UI-StephaneDucasse.52.diff http://ss3.gemstone.com/ss/Pharo20/Polymorph-Widgets-StephaneDucasse.747.dif... http://ss3.gemstone.com/ss/Pharo20/NewList-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Nautilus-StephaneDucasse.382.diff http://ss3.gemstone.com/ss/Pharo20/MorphicTests-StephaneDucasse.60.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-StephaneDucasse.1310.diff http://ss3.gemstone.com/ss/Pharo20/KeyChain-StephaneDucasse.22.diff http://ss3.gemstone.com/ss/Pharo20/FreeType-StephaneDucasse.607.diff
On Dec 20, 2012, at 4:21 PM, Sven Van Caekenberghe wrote:
Ahh, I love the smell of massive refactorings ;-)
;-) We did that and laugh a lot with igor yesterday and damienP. today. Now I understand the difference between addMorph: frame: which of course expect a rectangle and addMorph: fullFrame: which expects a layoutFrameâ¦. :( Stef
Great work !
-- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill
On 20 Dec 2012, at 15:36, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
20446 -----
Issue 7157: part two of LayoutFrame users rewriting http://code.google.com/p/pharo/issues/detail?id=7157
Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-StephaneDucasse.1005.diff http://ss3.gemstone.com/ss/Pharo20/System-Settings-StephaneDucasse.268.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Widgets-StephaneDucasse.75.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Examples-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Shout-StephaneDucasse.158.diff http://ss3.gemstone.com/ss/Pharo20/SUnit-UI-StephaneDucasse.52.diff http://ss3.gemstone.com/ss/Pharo20/Polymorph-Widgets-StephaneDucasse.747.dif... http://ss3.gemstone.com/ss/Pharo20/NewList-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Nautilus-StephaneDucasse.382.diff http://ss3.gemstone.com/ss/Pharo20/MorphicTests-StephaneDucasse.60.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-StephaneDucasse.1310.diff http://ss3.gemstone.com/ss/Pharo20/KeyChain-StephaneDucasse.22.diff http://ss3.gemstone.com/ss/Pharo20/FreeType-StephaneDucasse.607.diff
Okay, the next stage is to go over all senders of #intersect: and replace them with #intersect: ifNone: and then we will be ready to introduce change in Rectangle (if i don't forgot anything) On 20 December 2012 17:29, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Dec 20, 2012, at 4:21 PM, Sven Van Caekenberghe wrote:
Ahh, I love the smell of massive refactorings ;-)
;-) We did that and laugh a lot with igor yesterday and damienP. today.
Now I understand the difference between addMorph: frame: which of course expect a rectangle and addMorph: fullFrame: which expects a layoutFrameâ¦. :(
Stef
Great work !
-- Sven Van Caekenberghe http://stfx.eu Smalltalk is the Red Pill
On 20 Dec 2012, at 15:36, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
20446 -----
Issue 7157: part two of LayoutFrame users rewriting http://code.google.com/p/pharo/issues/detail?id=7157
Diff information: http://ss3.gemstone.com/ss/Pharo20/Tools-StephaneDucasse.1005.diff http://ss3.gemstone.com/ss/Pharo20/System-Settings-StephaneDucasse.268.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Widgets-StephaneDucasse.75.diff http://ss3.gemstone.com/ss/Pharo20/Spec-Examples-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Shout-StephaneDucasse.158.diff http://ss3.gemstone.com/ss/Pharo20/SUnit-UI-StephaneDucasse.52.diff http://ss3.gemstone.com/ss/Pharo20/Polymorph-Widgets-StephaneDucasse.747.dif... http://ss3.gemstone.com/ss/Pharo20/NewList-StephaneDucasse.12.diff http://ss3.gemstone.com/ss/Pharo20/Nautilus-StephaneDucasse.382.diff http://ss3.gemstone.com/ss/Pharo20/MorphicTests-StephaneDucasse.60.diff http://ss3.gemstone.com/ss/Pharo20/Morphic-StephaneDucasse.1310.diff http://ss3.gemstone.com/ss/Pharo20/KeyChain-StephaneDucasse.22.diff http://ss3.gemstone.com/ss/Pharo20/FreeType-StephaneDucasse.607.diff
-- Best regards, Igor Stasenko.
participants (3)
-
Igor Stasenko -
Stéphane Ducasse -
Sven Van Caekenberghe