bug: [4993] Typing cmd+L cancel all typing and we can't undo it [Terminated]
This is my first pharo bug fix so be gentle :D https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...> As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build. -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
kilon wrote:
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...>
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ?
On Oct 13, 2013, at 4:10 PM, btc@openinworld.com wrote:
kilon wrote:
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...> As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ?
Normally the first step is "fix review needed". Then someone else needs to check if this is ok (not any small mistake, problem really solved), "fix to include" should be the state when it is guaranteed that is can be included without check and thinking. Marcus
On Oct 13, 2013, at 7:11 PM, btc@openinworld.com wrote:
Normally the first step is "fix review needed". Then someone else needs to check if this is ok (not any small mistake, problem really solved), "fix to include" should be the state when it is guaranteed that is can be included without check and thinking.
Marcus
After loading the slice, as well as some functional testing, would you typically run all tests in TestRunner, or just those associated with the modified package ?
running tests is slow, so in the end people (hum, that is, me ;-) forget to even run the tests of the package.
Also at which point does the monkey do its checking?
Sadly the monkey is sick right now⦠we need to fix it. Marcus
As I reviewed the Slice <Changes> related to Case 4993, I notice the relevant part was only a single method, but also included were several more unrelated modifications with zero-sum refactorings. eg, from... position: aPoint super position: aPoint. self viewBox ifNotNil: [self viewBox: (aPoint extent: self viewBox extent)]. to... position: aPoint super position: aPoint. self viewBox ifNotNil: [:viewBox | self viewBox: (aPoint extent: viewBox extent)]. which itself is cool, but my first thought was that these shouldn't have been included in the Case 4993 Slice, but in a separate Slice for a different Case that dealt just with those refactorings. But thinking further in general the image I use for testing could have moved on from the image used to generate that Slice. So maybe its not not such a problem anyhow? Also, if the zero-sum refactoring modifications were put in their own separate Slice, then probably the specific modifications related to the Case would build upon that, so ultimately you end up with the same situation. So in short my question is, how much do you typically separate out Case-specific modifications from incidental zero-sum refactoring made along the way. cheers -ben --------Original Message----------- btc@openinworld.com wrote:
kilon wrote:
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...
<https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...>
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
It looks fine. Simple enough even for me to understand ;). So I've changed the status to 'Resolved - fix to include.' Actually my first, so just checking this is the correct next step in the workflow ?
how you do that ? I try to find in the slice the method I have changed and I see it has the whole morphic inside it. Very confusing. I went to changes and again it does not show the method. Just a class declaration. No idea how to use it to find out the changed method. I changed only a single method PluggableTextMorph>>cancel . cancel (self confirm: 'This action will cancel your changes. Is it OK to cancel changes?' translated) ifTrue: [self setText: self getText. self setSelection: self getSelection.] -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Oct 13, 2013, at 7:00 PM, kilon <thekilon@yahoo.co.uk> wrote:
how you do that ? I try to find in the slice the method I have changed and I see it has the whole morphic inside it. Very confusing.
Monticello always snapshots the whole package even for a one-character change. Marcus
On Oct 13, 2013, at 6:36 PM, btc@openinworld.com wrote:
As I reviewed the Slice <Changes> related to Case 4993, I notice the relevant part was only a single method, but also included were several more unrelated modifications with zero-sum refactorings. eg, from... position: aPoint super position: aPoint. self viewBox ifNotNil: [self viewBox: (aPoint extent: self viewBox extent)].
to... position: aPoint super position: aPoint. self viewBox ifNotNil: [:viewBox | self viewBox: (aPoint extent: viewBox extent)].
which itself is cool, but my first thought was that these shouldn't have been included in the Case 4993 Slice, but in a separate Slice for a different Case that dealt just with those refactorings. But thinking further in general the image I use for testing could have moved on from the image used to generate that Slice. So maybe its not not such a problem anyhow? Also, if the zero-sum refactoring modifications were put in their own separate Slice, then probably the specific modifications related to the Case would build upon that, so ultimately you end up with the same situation.
So in short my question is, how much do you typically separate out Case-specific modifications from incidental zero-sum refactoring made along the way.
In theory: yes. In practice: just too much work. I often slip in small refactorings with other changes (and code deletions⦠nothing works less than asking "There is this obscure feature that nobody used in 20 years, can I remove it?" The answer always will be "Wow, this is cool, over my dead body!". If people would know what I removed over the years⦠;-) Marcus
On Oct 13, 2013, at 1:08 PM, kilon <thekilon@yahoo.co.uk> wrote:
This is my first pharo bug fix so be gentle :D
Great! We love contributions. Stef
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...>
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Hi! Thanks Kilon for working on the Contr-l key binding. I use this control key binding a lot, and actually, it is really rare when I do a mistake. Having to press OK whenever I do this sounds like a regression to me. Why not always inserting the text in the undo queue before replacing the text? Alexandre
Le 13-10-2013 à 8:08, kilon <thekilon@yahoo.co.uk> a écrit :
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...>
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Oct 14, 2013, at 2:05 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi!
Thanks Kilon for working on the Contr-l key binding. I use this control key binding a lot, and actually, it is really rare when I do a mistake.
I did not even know that it exist, but I wondered often when the code I wrote disappeared with just no way of getting it back.
Having to press OK whenever I do this sounds like a regression to me. Why not always inserting the text in the undo queue before replacing the text?
This would be bestâ¦
Definetly not a regression. If you make a mistake your work is gone, bye bye, hasta la vista baby. Personally I dont use, or see myself using CMD+L on a daily basis. Its highly unlikely that I will code in several lines of code and will want to discard them completely. In 99/100 cases I just slightly change, edit the code. So we definitely have a different workflow on this one. You are much better coders than me, so I understand you may use that feature heavily. Undo was my first goal too, but trying to understand how undo is implemented felt like hammering my face on a wall. The amount of spaggetication in the code is beyond understanding for me, on the 1 hour I invested of finding a bug fix. So I spent like 50 minutes trying to understand undo, failed miserably, spent rest 10 implementing the dialog box. And yes I am not very smart or good coder. I will try to take another look at undo today and have another go at this, but If I found no solution I will leave the fix as it is. Chances are I wont figure this out, so don't hold your breath. Bottom line is that in case of proper software the user should not allowed to do things that are unrecoverable without a prompt. So not implementing a fix at all, at least for me is considered very bad. But this is just my personal opinion. -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Oct 14, 2013, at 3:06 PM, kilon <thekilon@yahoo.co.uk> wrote:
Definetly not a regression. If you make a mistake your work is gone, bye bye, hasta la vista baby. Personally I dont use, or see myself using CMD+L on a daily basis. Its highly unlikely that I will code in several lines of code and will want to discard them completely. In 99/100 cases I just slightly change, edit the code. So we definitely have a different workflow on this one.
You are much better coders than me, so I understand you may use that feature heavily.
Undo was my first goal too, but trying to understand how undo is implemented felt like hammering my face on a wall. The amount of spaggetication in the code is beyond understanding for me, on the 1 hour I invested of finding a bug fix. So I spent like 50 minutes trying to understand undo, failed miserably, spent rest 10 implementing the dialog box. And yes I am not very smart or good coder.
I will try to take another look at undo today and have another go at this, but If I found no solution I will leave the fix as it is. Chances are I wont figure this out, so don't hold your breath.
Bottom line is that in case of proper software the user should not allowed to do things that are unrecoverable without a prompt. So not implementing a fix at all, at least for me is considered very bad. But this is just my personal opinion.
I am 100% with you on this :-) Marcus
Hi Kilon, Sorry for the late reply. The Cmd-L is useful as soon as you evaluate code in your code browser. Consider the following scenario that I am very sure you am facing every single day: 1 - Define a method on a class: -=-=--=-=--=-=--=-=- foo ^ 1 + 2 -=-=--=-=--=-=--=-=- 2 - It often happen that you want to know the value of some expression in the method body. Select "1 + 2" and press Cmd-P. It prints you the value 3, great. 3 - Click on a different method or close the browser. And you get this stupid question "Code has been modified. What do you want to do". Isn't it obvious what I want to do? The browser is asking me whether I may want to accept the method, even if it is not compilable (i.e., the code "^ 1 + 2 3" is not proper smalltalk). So stupid it is. Even worse: if you press backspace to remove the 3, the code browser is still notifying you the source code has changed, even if the content is the same. This is so frustrating. I am sure you are facing this questions many times a day. Cmd-L is here to help (but it poorly helps, I agree). After you have evaluated "1 + 2" and have "3" displayed, you can press Cmd-L to restore the original method content and makes the browser forget that I have modified the method body. No more question is asked when I delete the browser or select a different method. Now, making Cmd-L raises a question would simply makes the bidding not useful at all. Igor showed me this bidding, which makes me suspect he uses it since he knows it. I think Lukas was using it as well. Making the browser ask yet another question such as "your content is about to be deleted, are you sure you want to continue" does not make the environment more intelligent in my opinion, but just more talkative. As your original post suggest, the text editor needs improvement. For example, if Cmd-L is really disturbing you, then remove it, but make sure the browser does not complain when the text content is the same than the original method (or class definition). This would be great actually. On a slightly different front, I have seen that the create temporary method is broken. Last time I've seen this was many years ago... Alexandre On Oct 14, 2013, at 10:05 AM, kilon <thekilon@yahoo.co.uk> wrote:
Definetly not a regression. If you make a mistake your work is gone, bye bye, hasta la vista baby. Personally I dont use, or see myself using CMD+L on a daily basis. Its highly unlikely that I will code in several lines of code and will want to discard them completely. In 99/100 cases I just slightly change, edit the code. So we definitely have a different workflow on this one.
You are much better coders than me, so I understand you may use that feature heavily.
Undo was my first goal too, but trying to understand how undo is implemented felt like hammering my face on a wall. The amount of spaggetication in the code is beyond understanding for me, on the 1 hour I invested of finding a bug fix. So I spent like 50 minutes trying to understand undo, failed miserably, spent rest 10 implementing the dialog box. And yes I am not very smart or good coder.
I will try to take another look at undo today and have another go at this, but If I found no solution I will leave the fix as it is. Chances are I wont figure this out, so don't hold your breath.
Bottom line is that in case of proper software the user should not allowed to do things that are unrecoverable without a prompt. So not implementing a fix at all, at least for me is considered very bad. But this is just my personal opinion.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Ben On Oct 15, 2013, at 1:38 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
Hi Kilon,
Sorry for the late reply. The Cmd-L is useful as soon as you evaluate code in your code browser. Consider the following scenario that I am very sure you am facing every single day:
1 - Define a method on a class: -=-=--=-=--=-=--=-=- foo ^ 1 + 2 -=-=--=-=--=-=--=-=-
2 - It often happen that you want to know the value of some expression in the method body. Select "1 + 2" and press Cmd-P. It prints you the value 3, great.
3 - Click on a different method or close the browser. And you get this stupid question "Code has been modified. What do you want to do". Isn't it obvious what I want to do? The browser is asking me whether I may want to accept the method, even if it is not compilable (i.e., the code "^ 1 + 2 3" is not proper smalltalk). So stupid it is. Even worse: if you press backspace to remove the 3, the code browser is still notifying you the source code has changed, even if the content is the same.
Not in Nautilus :P
This is so frustrating. I am sure you are facing this questions many times a day. Cmd-L is here to help (but it poorly helps, I agree). After you have evaluated "1 + 2" and have "3" displayed, you can press Cmd-L to restore the original method content and makes the browser forget that I have modified the method body. No more question is asked when I delete the browser or select a different method.
Now, making Cmd-L raises a question would simply makes the bidding not useful at all. Igor showed me this bidding, which makes me suspect he uses it since he knows it. I think Lukas was using it as well. Making the browser ask yet another question such as "your content is about to be deleted, are you sure you want to continue" does not make the environment more intelligent in my opinion, but just more talkative.
As your original post suggest, the text editor needs improvement. For example, if Cmd-L is really disturbing you, then remove it, but make sure the browser does not complain when the text content is the same than the original method (or class definition). This would be great actually.
On a slightly different front, I have seen that the create temporary method is broken. Last time I've seen this was many years ago...
Alexandre
On Oct 14, 2013, at 10:05 AM, kilon <thekilon@yahoo.co.uk> wrote:
Definetly not a regression. If you make a mistake your work is gone, bye bye, hasta la vista baby. Personally I dont use, or see myself using CMD+L on a daily basis. Its highly unlikely that I will code in several lines of code and will want to discard them completely. In 99/100 cases I just slightly change, edit the code. So we definitely have a different workflow on this one.
You are much better coders than me, so I understand you may use that feature heavily.
Undo was my first goal too, but trying to understand how undo is implemented felt like hammering my face on a wall. The amount of spaggetication in the code is beyond understanding for me, on the 1 hour I invested of finding a bug fix. So I spent like 50 minutes trying to understand undo, failed miserably, spent rest 10 implementing the dialog box. And yes I am not very smart or good coder.
I will try to take another look at undo today and have another go at this, but If I found no solution I will leave the fix as it is. Chances are I wont figure this out, so don't hold your breath.
Bottom line is that in case of proper software the user should not allowed to do things that are unrecoverable without a prompt. So not implementing a fix at all, at least for me is considered very bad. But this is just my personal opinion.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
the dialog does not force you to use the mouse, you just do ctrl+l and then hit enter to confirm ("yes" is preselected). So essentially it only introduces one more keyboard key, enter. If you want to cancel the cmd+l is when you will need to use the mouse (so you choose "No" option). Apparently arrow keys dont work with the dialog. So you can think of it as ctrl+l+enter . Saying that I will have another go on undo , I really want to understand how undo works not just for this fix but generally. I agree that the fix is not ideal as it is but unfortunately my understanding of Pharo is very limited right now. btc wrote
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
Alexandre Bergel wrote:
Hi!
Thanks Kilon for working on the Contr-l key binding. I use this control key binding a lot, and actually, it is really rare when I do a mistake. Having to press OK whenever I do this sounds like a regression to me. Why not always inserting the text in the undo queue before replacing the text?
Alexandre
I originally had the same opinion, and I had a go getting undo to work but failed. So I tested kilon's slice and it seemed to not adversely affect my workflow. I wonder if a compromise might be the ability to acknowledge the alert dialog with <ctrl-l> - so you don't have to move your fingers from the shortcut, and still provides a guard against accidental reset. -ben
Le 13-10-2013 Ã 8:08, kilon <
thekilon@.co
> a écrit :
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...;
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Oct 14, 2013, at 5:13 PM, kilon <thekilon@yahoo.co.uk> wrote:
the dialog does not force you to use the mouse, you just do ctrl+l and then hit enter to confirm ("yes" is preselected). So essentially it only introduces one more keyboard key, enter. If you want to cancel the cmd+l is when you will need to use the mouse (so you choose "No" option). Apparently arrow keys dont work with the dialog.
So you can think of it as ctrl+l+enter . Saying that I will have another go on undo , I really want to understand how undo works not just for this fix but generally. I agree that the fix is not ideal as it is but unfortunately my understanding of Pharo is very limited right now.
We should add this now and then the people who use ctrl-l a lot can do a fix with putting the content in the undo. Marcus
So you can think of it as ctrl+l+enter . Saying that I will have another go on undo , I really want to understand how undo works not just for this fix but generally. I agree that the fix is not ideal as it is but unfortunately my understanding of Pharo is very limited right now.
No stress. We are here all learning :-) Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
I use Cmd-L almost as often than Cmd-P. Making it asking an obvious question which require a obvious answer is counter productive. If one is really afraid to loose the content, then use the Undo queue for this. So, Cmd-L should use the Undo queue, not asking more questions. Alexandre On Oct 14, 2013, at 10:41 AM, btc@openInWorld.com wrote:
Alexandre Bergel wrote:
Hi!
Thanks Kilon for working on the Contr-l key binding. I use this control key binding a lot, and actually, it is really rare when I do a mistake. Having to press OK whenever I do this sounds like a regression to me. Why not always inserting the text in the undo queue before replacing the text?
Alexandre
I originally had the same opinion, and I had a go getting undo to work but failed. So I tested kilon's slice and it seemed to not adversely affect my workflow. I wonder if a compromise might be the ability to acknowledge the alert dialog with <ctrl-l> - so you don't have to move your fingers from the shortcut, and still provides a guard against accidental reset. -ben
Le 13-10-2013 à 8:08, kilon <thekilon@yahoo.co.uk> a écrit :
This is my first pharo bug fix so be gentle :D
https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we... <https://pharo.fogbugz.com/f/cases/4993/Typing-cmd-L-cancel-all-typing-and-we...>
As I explain in the link and in my commit log , I have added a confirm dialog so the user in case he accidentally pressed CMD+L will click no and his changes will not be lost. I have verified the bug fix with the latest pharo build.
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Oct 15, 2013, at 1:41 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
I use Cmd-L almost as often than Cmd-P
I got to know Cmd-l only because I got so upset of randomly loosing code. It's the most horrible thing I ever saw in the system. I never used it *ever*, but lost code *many* *many* times by accident without even understanding what happened. I hate it. Marcus
On 2013-10-15, at 14:52, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 15, 2013, at 1:41 PM, Alexandre Bergel <alexandre.bergel@me.com> wrote:
I use Cmd-L almost as often than Cmd-P
I got to know Cmd-l only because I got so upset of randomly loosing code. It's the most horrible thing I ever saw in the system. I never used it *ever*, but lost code *many* *many* times by accident without even understanding what happened.
I hate it.
I follow the exact same reasoning :P
i using cmd-l very very very often.. it allows me to type any random text in any random place and then all this stuff is gone with single key stroke. more than that, it marks text back as unmodified, so i do not need to deal with browser entering the "commit or cancel" mode, asking me stupid questions like "do you want to commit or cancel" so , it is regression. It is regression just from a single perspective, that it adds one more modal dialog which blocks your workflow. A proper fix would be is to add the undo command, so if you pressed cmd-l by mistake, you can undo it by pressing cmd-z but one more dialog asking annoying questions.. no go! Btw, i already proposed how we can to avoid putting modal dialog for "code modified submit or cancel" question. P.S. Don't mode me in! http://en.wikipedia.org/wiki/Mode_%28computer_interface%29 On 15 October 2013 14:56, Camillo Bruni <camillobruni@gmail.com> wrote:
On 2013-10-15, at 14:52, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 15, 2013, at 1:41 PM, Alexandre Bergel <alexandre.bergel@me.com>
wrote:
I use Cmd-L almost as often than Cmd-P
I got to know Cmd-l only because I got so upset of randomly loosing code. It's the most horrible thing I ever saw in the system. I never used it *ever*, but lost code *many* *many* times by accident
without
even understanding what happened.
I hate it.
I follow the exact same reasoning :P
-- Best regards, Igor Stasenko.
On Oct 15, 2013, at 3:34 PM, Igor Stasenko <siguctua@gmail.com> wrote:
i using cmd-l very very very often.. it allows me to type any random text in any random place and then all this stuff is gone with single key stroke. more than that, it marks text back as unmodified, so i do not need to deal with browser entering the "commit or cancel" mode, asking me stupid questions like "do you want to commit or cancel"
so , it is regression. It is regression just from a single perspective, that it adds one more modal dialog which blocks your workflow. A proper fix would be is to add the undo command, so if you pressed cmd-l by mistake, you can undo it by pressing cmd-z
Yes, you are welcome to submit a fix that does that. For now we have a backstop that makes sure people don't lose code. Marcus
tried to understand undo , the more I explored the more I don't understand how it works. TextEditor is a big class doing many different things and the code is not made in a way to be read easily. I have vague idea how it works looks like HistoryIterator and EditingState do the work, but still cant figure out exactly how. So time to move to next bug. Marcus Denker-4 wrote
On Oct 15, 2013, at 3:34 PM, Igor Stasenko <
siguctua@
> wrote:
i using cmd-l very very very often.. it allows me to type any random text in any random place and then all this stuff is gone with single key stroke. more than that, it marks text back as unmodified, so i do not need to deal with browser entering the "commit or cancel" mode, asking me stupid questions like "do you want to commit or cancel"
so , it is regression. It is regression just from a single perspective, that it adds one more modal dialog which blocks your workflow. A proper fix would be is to add the undo command, so if you pressed cmd-l by mistake, you can undo it by pressing cmd-z
Yes, you are welcome to submit a fix that does that. For now we have a backstop that makes sure people don't lose code.
Marcus
signature.asc (210 bytes) <http://forum.world.st/attachment/4714539/0/signature.asc>;
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway. Disclaimer: I spent the couple of weeks. Phil
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ? -- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Undo framework? Where to see it? what the package name? 2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr>
please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ? Cheers Alain Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
Hi Alain, thanks for the information. It looks very powerfull, I'll have to look into it. There is also a RB related history system, I'm using it in my browser. It's RBRefactoryChangeManager (is that the one Nautilus is using?). Thierry Le 16/10/2013 11:29, plantec a écrit :
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ? Cheers Alain
Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
thierry the one of alain is a simple do/undo now Epicea is a new changes model developed by martin and you raised a good point, we should look if Epicea could be used for RB undo. Stef On Oct 16, 2013, at 11:45 AM, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Hi Alain,
thanks for the information. It looks very powerfull, I'll have to look into it.
There is also a RB related history system, I'm using it in my browser. It's RBRefactoryChangeManager (is that the one Nautilus is using?).
Thierry
Le 16/10/2013 11:29, plantec a écrit :
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ? Cheers Alain
Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Le 16/10/2013 12:08, Stéphane Ducasse a écrit :
thierry
the one of alain is a simple do/undo now Epicea is a new changes model developed by martin and you raised a good point, we should look if Epicea could be used for RB undo.
My point is: undo/redo is one API (Alain's), EPICEA would specialize that for code changes, and RB is also for code changes (is EPICEA able to represent RB operations?). Also, would EPICEA come with a merge capability? It would beat any versionning system out there by providing better history understanding. Thierry
Stef
On Oct 16, 2013, at 11:45 AM, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Hi Alain,
thanks for the information. It looks very powerfull, I'll have to look into it.
There is also a RB related history system, I'm using it in my browser. It's RBRefactoryChangeManager (is that the one Nautilus is using?).
Thierry
Le 16/10/2013 11:29, plantec a écrit :
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ? Cheers Alain
Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
thierry
the one of alain is a simple do/undo now Epicea is a new changes model developed by martin and you raised a good point, we should look if Epicea could be used for RB undo.
My point is: undo/redo is one API (Alain's), EPICEA would specialize that for code changes, and RB is also for code changes (is EPICEA able to represent RB operations?).
We should check that.
Also, would EPICEA come with a merge capability? It would beat any versionning system out there by providing better history understanding.
This is exactly the goal of the phd of martin. - better supporting merging - I want a way to get the complete history of pharo and even do senders/implementors in the past :) Stef
Thierry
Stef
On Oct 16, 2013, at 11:45 AM, Goubier Thierry <thierry.goubier@cea.fr> wrote:
Hi Alain,
thanks for the information. It looks very powerfull, I'll have to look into it.
There is also a RB related history system, I'm using it in my browser. It's RBRefactoryChangeManager (is that the one Nautilus is using?).
Thierry
Le 16/10/2013 11:29, plantec a écrit :
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ? Cheers Alain
Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Le 16/10/2013 14:00, Stéphane Ducasse a écrit :
thierry
the one of alain is a simple do/undo now Epicea is a new changes model developed by martin and you raised a good point, we should look if Epicea could be used for RB undo.
My point is: undo/redo is one API (Alain's), EPICEA would specialize that for code changes, and RB is also for code changes (is EPICEA able to represent RB operations?).
We should check that.
Also, would EPICEA come with a merge capability? It would beat any versionning system out there by providing better history understanding.
This is exactly the goal of the phd of martin. - better supporting merging
Cool.
- I want a way to get the complete history of pharo and even do senders/implementors in the past :)
This one is easy if you have a git repo below :) Partly implemented already, Stef... Just waiting for the rest of the system to catch up. Thierry -- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
You can have a look at Tests-SystemHistory. afaik, EditingState is the only user in the current system. Nautilus has its own. Will TxTextMorph have its own undo/redo framework too ?
No we will use yours and nautilus should do the same. Reusing and improving vs stacking similar solutions.
Cheers Alain
Le 16 oct. 2013 à 11:14, plantec <alain.plantec@yahoo.com> a écrit :
Le 16 oct. 2013 à 08:07, Denis Kudriashov <dionisiydk@gmail.com> a écrit :
Undo framework? Where to see it? what the package name?
It is System-History Cheers Alain
2013/10/16 Stéphane Ducasse <stephane.ducasse@inria.fr> please note that the re is a little undo frameworks made by alain plantec in the image. I think that phil is refeergin to paragraph and textEditor not undo/redo Stef
On Oct 16, 2013, at 4:02 AM, btc@openInWorld.com wrote:
I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u...
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com .
On 16 October 2013 04:02, <btc@openinworld.com> wrote:
** I guess Phil is referring to the difficulties of the current undo mechanism, which you've already discovered. One of the problems with web interfaces to a mailling-list is sometimes losing context. (I'm using Thunderbird 2.0 and it doesn't do threads.)
btw, What is the plan/schdule for TxText integration into Pharo mainline?
we plan to put it into image. right now i have early version which kind of works :) but i need to do some cleanup and wrapping-up before i will agree to put it into image. just discussed this with Stephane yesterday, and we agreed to have 2 weeks on it. next stage would be to go for deeper integration of it with tools etc.
cheers -ben
kilon wrote:
philippeback wrote
Don't enter that if you aren't ready to invest a couple of weeks. TxText will change it all anyway.
Disclaimer: I spent the couple of weeks.
Phil
Sorry don't understand what you mean . Are you referring to me ? Enter what ?
-- View this message in context: http://forum.world.st/bug-4993-Typing-cmd-L-cancel-all-typing-and-we-can-t-u... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
-- Best regards, Igor Stasenko.
participants (12)
-
Alexandre Bergel -
Benjamin -
btc＠openinworld.com -
Camillo Bruni -
Denis Kudriashov -
Goubier Thierry -
Igor Stasenko -
kilon -
Marcus Denker -
phil＠highoctane.be -
plantec -
Stéphane Ducasse