Re: [Pharo-dev] Let's talk about Themes
Kilon wrote:
Actually my point was the creation of themes, thats what a theme manager does. No its not easy, its not easy to have to go to the System Browser find Dark Theme class, try to guess which method is responsible >for the background color and then go the usual Pharo rabbit hole of senders and implementors so that I dont brake anything. It kills my inner child. Slowly. Painfully.
Well, then please don't. There is no current value in adding more themes. Adding themes on the current code will just add to the mess that needs to be cleaned up. It leads to more fragmentation.
About moving away from static values and replace them with references I agree 100% with you but you also mention the very important that its something we have to agree on and I don't want to go through the pain of asking permission each time I want to do something like that.
No need to ask for permission. Just take small steps and post mails on your decisions. defaultSpec implementations are good candidates, just like defaultBounds, defaultBorderColor, defaultBorderWidth, defaultColor and defaultExtent
Because writing code to create a theme , makes no sense to me whatsoever.
Avoiding duplication tends to be extremely difficult otherwise. Stephan
Thanks Stephan for your honest answer :) On Mon, Nov 10, 2014 at 6:56 PM, Stephan Eggermont <stephan@stack.nl> wrote:
Kilon wrote:
Actually my point was the creation of themes, thats what a theme manager does. No its not easy, its not easy to have to go to the System Browser find Dark Theme class, try to guess which method is responsible >for the background color and then go the usual Pharo rabbit hole of senders and implementors so that I dont brake anything. It kills my inner child. Slowly. Painfully.
Well, then please don't. There is no current value in adding more themes. Adding themes on the current code will just add to the mess that needs to be cleaned up. It leads to more fragmentation.
About moving away from static values and replace them with references I agree 100% with you but you also mention the very important that its something we have to agree on and I don't want to go through the pain of asking permission each time I want to do something like that.
No need to ask for permission. Just take small steps and post mails on your decisions. defaultSpec implementations are good candidates, just like defaultBounds, defaultBorderColor, defaultBorderWidth, defaultColor and defaultExtent
Because writing code to create a theme , makes no sense to me whatsoever.
Avoiding duplication tends to be extremely difficult otherwise.
Stephan
participants (2)
-
kilon alios -
Stephan Eggermont