ChangesBrowser should not roll own dialog (was 13017 Class renaming does not update textual class definition)
Issue 15030: ChangesBrowser should not roll own dialog Since Spec already provides a dialog wrapper, the ChangesBrowser should use it. Fix in inbox: SLICE-Issue-15030-ChangesBrowser-should-not-roll-own-dialog-SeanDeNigris.1 - Replace hand-rolled dialog functionality with Spec's #openDialogWithSpec. The 'Accept' button is now labeled 'Okay'. It could be changed, but I don't see the point of the added complexity. - Fix senders/users ----- Cheers, Sean -- View this message in context: http://forum.world.st/ChangesBrowser-should-not-roll-own-dialog-was-13017-Cl... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Sean P. DeNigris wrote
Fix in inbox: SLICE-Issue-15030-ChangesBrowser-should-not-roll-own-dialog-SeanDeNigris.1
1 validation failure that seems to have nothing to do with the fix. Make #noMonkey to be reviewed manually⦠----- Cheers, Sean -- View this message in context: http://forum.world.st/ChangesBrowser-should-not-roll-own-dialog-was-13017-Cl... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (1)
-
Sean P. DeNigris