Hi, With pull requests, it is relatively easy to see what changed in GitHub. Eg. Marcus' latest fix: https://github.com/pharo-project/pharo/pull/797 shows 6 files/classes changed, reasonably readable diff. How does one review such a PR in an image, to test it out ? Has someone written a guide on how to do this best/most-easily ? How is/can this be related to contributing ? Sven
Hello Sven, the easy way I found to review an image of the change in a PR is to use the image from the CI server. In https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... you can see all the jobs of the PR (every PR is run in the CI as soon as it is created or updated). There you can find the PR by its number, for example: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... And then later you can check the results of the tests or downloading an image with the changes in Last Successful Artifacts: https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... The images are inside the folder "bootstrap-cache" and you should take the Pharo-32bits-****.zip or Pharo-64bits-****.zip. Cheers. On Mon, Feb 5, 2018 at 1:54 PM, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ? Has someone written a guide on how to do this best/most-easily ? How is/can this be related to contributing ?
Sven
-- Pablo Tesone. tesonep@gmail.com
yes, thatâs a way. anther way is to use âPR toolâ : in menu, choose âGitHubâ, then âReview pull requestsâ¦â. You will need your github user/pass since this is using the github api. ⦠and of course, this can be loadable/testable or not, depending on the part of the system you will be loading (it is usually ok). But in general, it should work (I do not think many people has used this tool so it can fail). Esteban
On 5 Feb 2018, at 14:52, tesonep@gmail.com wrote:
Hello Sven, the easy way I found to review an image of the change in a PR is to use the image from the CI server.
In https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20...> you can see all the jobs of the PR (every PR is run in the CI as soon as it is created or updated).
There you can find the PR by its number, for example:
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20...>
And then later you can check the results of the tests or downloading an image with the changes in Last Successful Artifacts:
https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20... <https://ci.inria.fr/pharo-ci-jenkins2/job/Test%20pending%20pull%20request%20...>
The images are inside the folder "bootstrap-cache" and you should take the Pharo-32bits-****.zip or Pharo-64bits-****.zip.
Cheers.
On Mon, Feb 5, 2018 at 1:54 PM, Sven Van Caekenberghe <sven@stfx.eu <mailto:sven@stfx.eu>> wrote: Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797 <https://github.com/pharo-project/pharo/pull/797>
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ? Has someone written a guide on how to do this best/most-easily ? How is/can this be related to contributing ?
Sven
-- Pablo Tesone. tesonep@gmail.com <mailto:tesonep@gmail.com>
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip) Esteban did a Pull request review tool: - register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically. Cheers, -- Pavel
Sven
the PR tool will create a branch for you and will to a pull of the changes. yes, PR tool will work on the remote destination of your PR (which is pharo-project/development for Pharo), but this is reasonable. So, *if* your origin remote is not âpharo-projectâ, you need to go to remotes tab and select âReview pull requestsâ on the appropriate remote. Esteban
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
Ah, Esteban's PR review tool is exactly what I was looking for. It works ! Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost. Docs needed (1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start) Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
As an idea - might someone do a tech talk on this and take us through some scenarios? Every time I think about how to help - I read the pain here and shy away from it (yes the mental barrier is mine, and also alack of time to really get to grips with it) - but I was thinking that it someone walked through it - it might make it all much less scary. Tim
On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Ah, Esteban's PR review tool is exactly what I was looking for. It works !
Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost.
Docs needed
(1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start)
Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
there will be a techtalk next thursday :) Esteban ps: btw, in general is no âpainâ, is people adapting and solving problems. I would like to have also a way to measure when people is happy, but thing is⦠lists works so people with problems can post them :)
On 6 Feb 2018, at 13:42, Tim Mackinnon <tim@testit.works> wrote:
As an idea - might someone do a tech talk on this and take us through some scenarios? Every time I think about how to help - I read the pain here and shy away from it (yes the mental barrier is mine, and also alack of time to really get to grips with it) - but I was thinking that it someone walked through it - it might make it all much less scary.
Tim
On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Ah, Esteban's PR review tool is exactly what I was looking for. It works !
Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost.
Docs needed
(1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start)
Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
another thing I was thinking about is to just do to do âliveâ youtube sessions⦠e.g. if I do a tiny fix, to just stream the whole thing, from start to finish. (but then, I guess the tech talk will be just that)
On 6 Feb 2018, at 13:42, Tim Mackinnon <tim@testit.works> wrote:
As an idea - might someone do a tech talk on this and take us through some scenarios? Every time I think about how to help - I read the pain here and shy away from it (yes the mental barrier is mine, and also alack of time to really get to grips with it) - but I was thinking that it someone walked through it - it might make it all much less scary.
Tim
On 5 Feb 2018, at 15:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Ah, Esteban's PR review tool is exactly what I was looking for. It works !
Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost.
Docs needed
(1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start)
Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
I made notes and will add a page with all the infos later today. (for http://pharo.org/contribute <http://pharo.org/contribute> ) Marcus
On 5 Feb 2018, at 16:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Ah, Esteban's PR review tool is exactly what I was looking for. It works !
Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost.
Docs needed
(1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start)
Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
And please please please use BIG font is you want to show something. Stef On Wed, Feb 7, 2018 at 11:45 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
I made notes and will add a page with all the infos later today. (for http://pharo.org/contribute )
Marcus
On 5 Feb 2018, at 16:57, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Ah, Esteban's PR review tool is exactly what I was looking for. It works !
Still, please, please (Pavel) write down somewhere what you just explained to me, else it will eventually be lost.
Docs needed
(1) contribute to Pharo (we have that) (2) keep in sync once you have done (1) (we have that, but not about image side) (3) review pull requests of others (new, this email to start)
Anyway, thanks for the answers.
On 5 Feb 2018, at 15:10, Pavel Krivanek <pavel.krivanek@gmail.com> wrote:
2018-02-05 13:54 GMT+01:00 Sven Van Caekenberghe <sven@stfx.eu>:
Hi,
With pull requests, it is relatively easy to see what changed in GitHub.
Eg. Marcus' latest fix:
https://github.com/pharo-project/pharo/pull/797
shows 6 files/classes changed, reasonably readable diff.
How does one review such a PR in an image, to test it out ?
The easiest way is to download an image bootstrapped from that PR. Next to the commits you have a validation status (red cross here), click on it, go to "Artifacts" and then download the image (bootstrap-cache/Pharo7.0-32bit-6ccdd62.zip)
Esteban did a Pull request review tool:
- register your local Pharo repository copy to Iceberg - in the "Remotes" open context menu on the pharo-project remote (not origin, which is probably our fork) - GitHub - Review pull requests... - open context menu on an issue and select "Review pull request..." - select the newest commit and check changes - to test it locally, do "Merge into image", answer "Yes"
Has someone written a guide on how to do this best/most-easily ?
No idea, but Esteban presented that several times on ESUG and other places.
How is/can this be related to contributing ?
If you want to use the PR review tool, you should have own fork and local repository - the same for contributing
If you then want to propose a modification fo the PR, you already have a branch from the PR merging. - do your change and synchronize the repository so your branch will be present on your fork. - then go to "Remotes" tab, open context menu on "MarcusDenker" remote (it will be created during merging of the PR into your image) and then do pull request. - in Head select your fork and your issue branch name - in Base select Marcus/Denker/pharo and the issue branch name - click on Create Pull request
It will create a PR on the repository that Marcus has. Like https://github.com/MarcusDenker/pharo/pull/1 When he will merge it, his PR to on Pharo repository will be updated automatically.
Cheers, -- Pavel
Sven
On 7 Feb 2018, at 11:45, Marcus Denker <marcus.denker@inria.fr> wrote:
I made notes and will add a page with all the infos later today. (for http://pharo.org/contribute <http://pharo.org/contribute> )
I added a simple page as a first step: http://pharo.org/review-fix <http://pharo.org/review-fix> Marcus
On 8 Feb 2018, at 13:41, Marcus Denker <marcus.denker@inria.fr> wrote:
On 7 Feb 2018, at 11:45, Marcus Denker <marcus.denker@inria.fr> wrote:
I made notes and will add a page with all the infos later today. (for http://pharo.org/contribute )
I added a simple page as a first step:
Marcus
Already quite good, thank you.
participants (7)
-
Esteban Lorenzano -
Marcus Denker -
Pavel Krivanek -
Stephane Ducasse -
Sven Van Caekenberghe -
tesonep＠gmail.com -
Tim Mackinnon