EventHandler cleanup: test / review needed
Hi, There is still EventHandler, MouseOverEventHandler and MorphicEventHandler. After these two we can remove EventHandler and MouseOverEventHandler: https://pharo.fogbugz.com/f/cases/14403/never-use-EventHandler-but-MorphicEv... https://pharo.fogbugz.com/f/cases/14404/extend-MorphicEventHandler-with-mous... Can someone check if how this was done is Ok? Marcus
On 06 Nov 2014, at 08:32, Marcus Denker <marcus.denker@inria.fr> wrote:
Hi,
There is still EventHandler, MouseOverEventHandler and MorphicEventHandler.
After these two we can remove EventHandler and MouseOverEventHandler:
https://pharo.fogbugz.com/f/cases/14403/never-use-EventHandler-but-MorphicEv...
This one is no in 40359 it just replaces two references to EventHandler with MorphicEventHandler in spec. But as the two are compatible, there should be no problem. There are no instances of EventHandler in a fresh image. next will be to extend MorphicEventHandler to know about #mouseOver and use it instead of MouseOverEventHandler (used to be named EventHandlerPlus), which is only used in PanelMorph.
https://pharo.fogbugz.com/f/cases/14404/extend-MorphicEventHandler-with-mous...
Ah, and even MorphicEventHandler should be replaced... "I'm the class in charge of handling the subscriptions to events such as clicks or key presses. I'm a provisory solution while my clients are fixed and I can be replaced by announcementsâ Sometimes I wonder how simple the system would be if we would just continue to actively clean it⦠Marcus
But we are actively cleaning it. Now many people have other duties (teaching, coding....) Stef On 7/11/14 08:14, Marcus Denker wrote:
On 06 Nov 2014, at 08:32, Marcus Denker <marcus.denker@inria.fr> wrote:
Hi,
There is still EventHandler, MouseOverEventHandler and MorphicEventHandler.
After these two we can remove EventHandler and MouseOverEventHandler:
https://pharo.fogbugz.com/f/cases/14403/never-use-EventHandler-but-MorphicEv... This one is no in 40359
it just replaces two references to EventHandler with MorphicEventHandler in spec. But as the two are compatible, there should be no problem. There are no instances of EventHandler in a fresh image.
next will be to extend MorphicEventHandler to know about #mouseOver and use it instead of MouseOverEventHandler (used to be named EventHandlerPlus), which is only used in PanelMorph.
https://pharo.fogbugz.com/f/cases/14404/extend-MorphicEventHandler-with-mous...
Ah, and even MorphicEventHandler should be replaced...
"I'm the class in charge of handling the subscriptions to events such as clicks or key presses. I'm a provisory solution while my clients are fixed and I can be replaced by announcementsâ
Sometimes I wonder how simple the system would be if we would just continue to actively clean itâ¦
Marcus
If you give us some time we can check that with alain monday. Stef On 6/11/14 08:32, Marcus Denker wrote:
Hi,
There is still EventHandler, MouseOverEventHandler and MorphicEventHandler.
After these two we can remove EventHandler and MouseOverEventHandler:
https://pharo.fogbugz.com/f/cases/14403/never-use-EventHandler-but-MorphicEv... https://pharo.fogbugz.com/f/cases/14404/extend-MorphicEventHandler-with-mous...
Can someone check if how this was done is Ok?
Marcus
participants (2)
-
Marcus Denker -
stepharo