[Pharo-project] Find and replace doesn't accept with Enter key
Hi alain. If I do cmd + f and I type something in the input, the only way to get the cursor in the result is by clickling in the "search" button. I would expected to be able to hit enter in addition. What do you think? Thanks -- Mariano http://marianopeck.wordpress.com
I assume you are referring to the find dialog in OmniBrowser. This has been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository. Lukas On 25 April 2011 16:50, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi alain. If I do cmd + f and I type something in the input, the only way to get the cursor in the result is by clickling in the "search" button. I would expected to be able to hit enter in addition. What do you think?
Thanks
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
On Mon, Apr 25, 2011 at 5:08 PM, Lukas Renggli <renggli@gmail.com> wrote:
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
This has been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository.
yes I know :) Now ConfigurationOfOmnibrowser has you very latest versions and it is all working great :)
Lukas
On 25 April 2011 16:50, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi alain. If I do cmd + f and I type something in the input, the only way to get the cursor in the result is by clickling in the "search" button. I would expected to be able to hit enter in addition. What do you think?
Thanks
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
Maybe the fix is the same? :-)
This has
been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository.
yes I know :) Now ConfigurationOfOmnibrowser has you very latest versions and it is all working great :)
Great. Lukas -- Lukas Renggli www.lukas-renggli.ch
On Mon, Apr 25, 2011 at 5:43 PM, Lukas Renggli <renggli@gmail.com> wrote:
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
Maybe the fix is the same? :-)
maybe. Can you point us the OB version so that we can do a diff with the previous one and see your fix ?
This has
been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository.
yes I know :) Now ConfigurationOfOmnibrowser has you very latest versions and it is all working great :)
Great.
Lukas
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
Maybe the fix is the same? :-)
maybe. Can you point us the OB version so that we can do a diff with the previous one and see your fix ?
Name: OB-Morphic-lr.156 Author: lr Time: 6 March 2011, 3:56:14 pm UUID: bfe6822f-95bb-48ad-a0fc-a9e72a458bc4 Ancestors: OB-Morphic-lr.155 - fixed the highly broken completion dialog Lukas -- Lukas Renggli www.lukas-renggli.ch
On Mon, Apr 25, 2011 at 6:06 PM, Lukas Renggli <renggli@gmail.com> wrote:
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
Maybe the fix is the same? :-)
maybe. Can you point us the OB version so that we can do a diff with the previous one and see your fix ?
Name: OB-Morphic-lr.156 Author: lr Time: 6 March 2011, 3:56:14 pm UUID: bfe6822f-95bb-48ad-a0fc-a9e72a458bc4 Ancestors: OB-Morphic-lr.155
- fixed the highly broken completion dialog
Thanks Lukas. I checked but it seems (from my newbie view) that it is not the same. You use a PluggableTextMorph, which understands #acceptOnCR: and #autoAccept: The dialog of the "Search and Replace" is a PanelMorph so I have no idea what should I do with it. Thanks anyways, maybe Alain can solve it :) cheers -- Mariano http://marianopeck.wordpress.com
On Apr 25, 2011, at 5:15 PM, Mariano Martinez Peck wrote:
On Mon, Apr 25, 2011 at 5:08 PM, Lukas Renggli <renggli@gmail.com> wrote: I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
This has been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository.
yes I know :) Now ConfigurationOfOmnibrowser has you very latest versions and it is all working great :)
is it the version of lukas the one that is now in 1.3? Did you copy its file to the PharoOb Repository? Because we should not rely on external repository. and lukas suggested that approach. Stef
Lukas
On 25 April 2011 16:50, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
Hi alain. If I do cmd + f and I type something in the input, the only way to get the cursor in the result is by clickling in the "search" button. I would expected to be able to hit enter in addition. What do you think?
Thanks
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
On Mon, Apr 25, 2011 at 6:52 PM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
On Apr 25, 2011, at 5:15 PM, Mariano Martinez Peck wrote:
On Mon, Apr 25, 2011 at 5:08 PM, Lukas Renggli <renggli@gmail.com>
wrote:
I assume you are referring to the find dialog in OmniBrowser.
No. I am talking about the Find and Replace of PharoCore. When you are inside a method and you press CMD + F
This has been fixed for Pharo 1.2 a long time ago, you just need to take/merge the code from my repository.
yes I know :) Now ConfigurationOfOmnibrowser has you very latest versions and it is all working great :)
is it the version of lukas the one that is now in 1.3?
yes, but copied to PharoOB
Did you copy its file to the PharoOb Repository?
yes
Because we should not rely on external repository. and lukas suggested that approach.
Stef
Lukas
On 25 April 2011 16:50, Mariano Martinez Peck <marianopeck@gmail.com>
wrote:
Hi alain. If I do cmd + f and I type something in the input, the only way to get the cursor in the result is by clickling in the "search" button. I would expected to be able to hit enter in addition. What do you think?
Thanks
-- Mariano http://marianopeck.wordpress.com
-- Lukas Renggli www.lukas-renggli.ch
-- Mariano http://marianopeck.wordpress.com
-- Mariano http://marianopeck.wordpress.com
participants (3)
-
Lukas Renggli -
Mariano Martinez Peck -
Stéphane Ducasse