[pharo-project/pharo-core] dc5304: 40570
Branch: refs/heads/4.0 Home: https://github.com/pharo-project/pharo-core Commit: dc53040c88d7e23cce1912ebcd27bf76804f2dad https://github.com/pharo-project/pharo-core/commit/dc53040c88d7e23cce1912ebc... Author: Jenkins Build Server <board@pharo-project.org> Date: 2015-03-20 (Fri, 20 Mar 2015) Changed paths: M AST-Core.package/RBMethodNode.class/instance/accessing/compilationContext.st A Kernel.package/DelayNullScheduler.class/README.md A Kernel.package/DelayNullScheduler.class/definition.st A Kernel.package/DelayNullScheduler.class/instance/as yet unclassified/shutDown.st A Kernel.package/DelayNullScheduler.class/instance/low priority processes/schedule_.st A Kernel.package/DelayNullScheduler.class/instance/low priority processes/unschedule_.st A Kernel.package/DelayNullScheduler.class/instance/snapshotting/startUp.st A Kernel.package/DelayNullScheduler.class/instance/timer process/schedulingProcess.st A Kernel.package/DelayNullScheduler.class/instance/timer process/startTimerEventLoop.st A Kernel.package/DelayNullScheduler.class/instance/timer process/stopTimerEventLoop.st M Nautilus-Tests.package/PackageTreeNautilusTest.class/instance/asserting/assertMethodWidget.st M Nautilus-Tests.package/PackageTreeNautilusTest.class/instance/asserting/assertSelectedCompiledMethod.st M Nautilus.package/MethodWidget.class/instance/private/getMethodItem_.st A Nautilus.package/MethodWidget.class/instance/protocol/updateMethodList_.st M Nautilus.package/NautilusUI.class/instance/accessing/selectedClassWithoutChangingSelection_.st M Nautilus.package/NautilusUI.class/instance/initialization/initialize.st M Nautilus.package/NautilusUI.class/instance/private/updateOnClassSelection.st A Nautilus.package/NautilusUI.class/instance/updating/updateCategoryAndMethodList_.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script569.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - scripts/script570.st R ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40569.st A ScriptLoader40.package/ScriptLoader.class/instance/pharo - updates/update40570.st M ScriptLoader40.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st Log Message: ----------- 40570 14890 Browsing a different class should select by default the previously browsed method https://pharo.fogbugz.com/f/cases/14890 15171 MNU: receiver of "getClass" is nil https://pharo.fogbugz.com/f/cases/15171 15168 add DelayNullScheduler https://pharo.fogbugz.com/f/cases/15168 http://files.pharo.org/image/40/40570.zip
GitHub wrote
14890 Browsing a different class should select by default the previously browsed method https://pharo.fogbugz.com/f/cases/14890
Ugh. This breaks my workflow. I often click the "Class-side" checkbox to get to the class template, but now it keeps the method selected. At first, I sat there like a monkey (no offense Ulysses ;)) and kept hitting it repeatedly with a perplexed look on my face. Later I saw this issue and connected the dots. I'm not saying its a bad change (I'm not entirely clear on the use case), but... Policy Suggestion: Tool UI changes /must/ be discussed on the list prior to integration. ----- Cheers, Sean -- View this message in context: http://forum.world.st/pharo-project-pharo-core-dc5304-40570-tp4813535p481362... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
On Fri, Mar 20, 2015 at 11:42 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
GitHub wrote
14890 Browsing a different class should select by default the previously browsed method https://pharo.fogbugz.com/f/cases/14890
Ugh. This breaks my workflow. I often click the "Class-side" checkbox to get to the class template, but now it keeps the method selected. At first, I sat there like a monkey (no offense Ulysses ;)) and kept hitting it repeatedly with a perplexed look on my face. Later I saw this issue and connected the dots. I'm not saying its a bad change (I'm not entirely clear on the use case), but...
Policy Suggestion: Tool UI changes /must/ be discussed on the list prior to integration.
I've actually been wanting this for a long time (thank you). The use case is to make it easier to observe differences between super/subclasses and sibling classes for the same method. For example, click on DelayScheduler>>shutDown, then click on its two subclasses to observe the different implementations. However the current implementation makes it difficult to view class definitions. Continuing the previous example, after selecting #shutDown, try view the class definitions of DelayScheduler and subclasses. Useful additional behaviour would be that clicking on a class that is already selected would change to class-definition-mode . Clicking on the class again would toggle back to previous-method-mode. Ideally modes would hold between change in class selection, however its a bit late to be experimenting with this. It would probably be simplest to just reset the previous-method when a selected class is clicked on again, and also when class-side button is clicked - or otherwise roll back and leave it for Pharo 5. cheers -ben
We should rollback this change. I did it and I will keep it for me. Stef Le 20/3/15 17:40, Ben Coman a écrit :
On Fri, Mar 20, 2015 at 11:42 PM, Sean P. DeNigris <sean@clipperadams.com <mailto:sean@clipperadams.com>> wrote:
GitHub wrote > 14890 Browsing a different class should select by default the previously > browsed method > https://pharo.fogbugz.com/f/cases/14890
Ugh. This breaks my workflow. I often click the "Class-side" checkbox to get to the class template, but now it keeps the method selected. At first, I sat there like a monkey (no offense Ulysses ;)) and kept hitting it repeatedly with a perplexed look on my face. Later I saw this issue and connected the dots. I'm not saying its a bad change (I'm not entirely clear on the use case), but...
Policy Suggestion: Tool UI changes /must/ be discussed on the list prior to integration.
I've actually been wanting this for a long time (thank you). The use case is to make it easier to observe differences between super/subclasses and sibling classes for the same method. For example, click on DelayScheduler>>shutDown, then click on its two subclasses to observe the different implementations.
However the current implementation makes it difficult to view class definitions. Continuing the previous example, after selecting #shutDown, try view the class definitions of DelayScheduler and subclasses.
Useful additional behaviour would be that clicking on a class that is already selected would change to class-definition-mode . Clicking on the class again would toggle back to previous-method-mode. Ideally modes would hold between change in class selection, however its a bit late to be experimenting with this. It would probably be simplest to just reset the previous-method when a selected class is clicked on again, and also when class-side button is clicked - or otherwise roll back and leave it for Pharo 5.
cheers -ben
I'd like to see it in Pharo 5. cheers -ben On Sat, Mar 21, 2015 at 1:23 AM, stepharo <stepharo@free.fr> wrote:
We should rollback this change. I did it and I will keep it for me.
Stef
Le 20/3/15 17:40, Ben Coman a écrit :
On Fri, Mar 20, 2015 at 11:42 PM, Sean P. DeNigris <sean@clipperadams.com> wrote:
GitHub wrote
14890 Browsing a different class should select by default the previously browsed method https://pharo.fogbugz.com/f/cases/14890
Ugh. This breaks my workflow. I often click the "Class-side" checkbox to get to the class template, but now it keeps the method selected. At first, I sat there like a monkey (no offense Ulysses ;)) and kept hitting it repeatedly with a perplexed look on my face. Later I saw this issue and connected the dots. I'm not saying its a bad change (I'm not entirely clear on the use case), but...
Policy Suggestion: Tool UI changes /must/ be discussed on the list prior to integration.
I've actually been wanting this for a long time (thank you). The use case is to make it easier to observe differences between super/subclasses and sibling classes for the same method. For example, click on DelayScheduler>>shutDown, then click on its two subclasses to observe the different implementations.
However the current implementation makes it difficult to view class definitions. Continuing the previous example, after selecting #shutDown, try view the class definitions of DelayScheduler and subclasses.
Useful additional behaviour would be that clicking on a class that is already selected would change to class-definition-mode . Clicking on the class again would toggle back to previous-method-mode. Ideally modes would hold between change in class selection, however its a bit late to be experimenting with this. It would probably be simplest to just reset the previous-method when a selected class is clicked on again, and also when class-side button is clicked - or otherwise roll back and leave it for Pharo 5.
cheers -ben
participants (4)
-
Ben Coman -
GitHub -
Sean P. DeNigris -
stepharo