fogbugz process Check seems to be stuck
Hi All, Would someone mind clarifying the issue process for me. pharo.org states: In success, the state will be "Fix Reviewed by the Monkey". This is where humans come into the picture: your code needs to be reviewed, if possible by 2-3 people. If they accept it, the state moves to "Fix to Include", after which it will be committed to the development branch as soon as possible. After I submitted the slice to issue 18248 the monkey successfully reviewed it and then assigned it back to me. Then a little while later the monkey complained that the "Check seems to be stuck. I will try again". It looks like the second validation also succeeded. Do I need to do something to initiate the human review, or should I be taking some other action? Thanks, Alistair
Hi Alistair, Everything is OK. Once Issue Validation succeeds, your slice is ready to be integrated (a review by another human would help too). Integration itself is a manual process done by an integrator. The reason there was a second check is that every time a new build is done, all open issues are rechecked. It got stuck, but also unstuck automatically. HTH, Sven
On 18 May 2016, at 07:03, Alistair Grant <akgrant0710@gmail.com> wrote:
Hi All,
Would someone mind clarifying the issue process for me.
pharo.org states:
In success, the state will be "Fix Reviewed by the Monkey". This is where humans come into the picture: your code needs to be reviewed, if possible by 2-3 people. If they accept it, the state moves to "Fix to Include", after which it will be committed to the development branch as soon as possible.
After I submitted the slice to issue 18248 the monkey successfully reviewed it and then assigned it back to me.
Then a little while later the monkey complained that the "Check seems to be stuck. I will try again". It looks like the second validation also succeeded.
Do I need to do something to initiate the human review, or should I be taking some other action?
Thanks, Alistair
Hi Sven, On Wed, May 18, 2016 at 07:33:10AM +0200, Sven Van Caekenberghe wrote:
Hi Alistair,
Everything is OK.
Once Issue Validation succeeds, your slice is ready to be integrated (a review by another human would help too). Integration itself is a manual process done by an integrator.
The reason there was a second check is that every time a new build is done, all open issues are rechecked.
It got stuck, but also unstuck automatically.
Thanks for the clarification, so I'll just wait for the issue to make its way through the system. Cheers, Alistair
On 18 May 2016, at 07:03, Alistair Grant <akgrant0710@gmail.com> wrote:
Hi All,
Would someone mind clarifying the issue process for me.
pharo.org states:
In success, the state will be "Fix Reviewed by the Monkey". This is where humans come into the picture: your code needs to be reviewed, if possible by 2-3 people. If they accept it, the state moves to "Fix to Include", after which it will be committed to the development branch as soon as possible.
After I submitted the slice to issue 18248 the monkey successfully reviewed it and then assigned it back to me.
Then a little while later the monkey complained that the "Check seems to be stuck. I will try again". It looks like the second validation also succeeded.
Do I need to do something to initiate the human review, or should I be taking some other action?
Thanks, Alistair
participants (2)
-
Alistair Grant -
Sven Van Caekenberghe