Re: [Pharo-project] Issue 3463 in pharo: [Failing Test] HelpBrowserTest.testOpen
Updates: Summary: [Failing Test] HelpBrowserTest.testOpen Comment #1 on issue 3463 by marcus.denker: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 (No comment was entered for this change.)
Updates: Cc: marianopeck marcus.denker stephane.ducasse Comment #2 on issue 3463 by Torsten....@astares.de: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 In an updated Pharo core 1.2beta #12282 the test is green. I think the reason why it fails in 1.2-dev is that ConfigurationOfHelpSystem is still referenced in ConfigurationOfPharo, but help system is now already included in core images. So it should be easy to fix by removing HelpSystem from the Metacello config used to build the dev-image
Comment #3 on issue 3463 by guillermopolito: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 The config isn't referencing ConfigurationOfPharo.. It's breaking while doing #prepareDebuggerExample with a InMidstOfFileinNotification I don't quite understand why...
Updates: Cc: laurent.laffont Comment #4 on issue 3463 by Torsten....@astares.de: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 OK, to give more context: - the test HelpBrowserTest.testOpen just checks if the help browser can be opened without any problem (by checking if an exception occurs) - unfortunately there is an exception thrown Why: - one of the included help books is Laurents "SmalltalkSyntaxTutorial" - this class is instantiated and during intialization it sends #prepareDebuggerExample - this method compiles some code which ends up in the method CompiledMethod>>putSource:fromParseNode:inFile:withPreamble: - this method signals the exception: InMidstOfFileinNotification signal ifFalse: [file flush]. - this can be reproduced with the following code: [Object compile: 'foo ^3+4' classified: 'test'] on: Exception do: [:ex | ex inspect] This also gives the InMidstOfFileinNotification Dont know why this InMidstOfFileinNotification Possible Solutions: - handle the notification in #prepareDebuggerExample (while compiling the code) - maybe we should also change #testOpen to just check for errors instead of exception while opening: self shouldnt: block raise: Error (this would avoid notifications which are also exceptions)
Updates: Status: Comment #5 on issue 3463 by Torsten....@astares.de: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 #testOpen now checks for Error instead of Exception Fixed with the attached changeset and also included in SLICE-Issue-3463-Failing-Test-HelpBrowserTesttestOpen-tbn.1 in pharo inbox Attachments: HelpBrowserTest-testOpen.st 339 bytes
Updates: Status: Fixed Comment #6 on issue 3463 by Torsten....@astares.de: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 (No comment was entered for this change.)
Updates: Labels: Milestone-1.2 Comment #7 on issue 3463 by marcus.denker: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 (No comment was entered for this change.)
Updates: Status: Closed Comment #8 on issue 3463 by marcus.denker: [Failing Test] HelpBrowserTest.testOpen http://code.google.com/p/pharo/issues/detail?id=3463 12284
participants (1)
-
pharo@googlecode.com