[Pharo-project] Issue # 1498 "Collections should not accept non integer indexes"
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute. However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then. So I'll resort to the alternative plan, which is to send the changeset to this list. On a core image update #11067 the Collection tests are all green. Running all tests show one error and two failures not related to the changed methods. -- Cesar Rabak
On 1 déc. 2009, at 21:07, csrabak@bol.com.br wrote:
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute .
However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.
Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem. So this is a batch of 3 slices for issue 332 and related issues 1489 and 1529, pair programming by me & Cesar during the Pharo sprint in Buenos Aires Issue 332: Arithmetic protocol should be removed from Collections and Strings Issue 1489: Collections shuould not accept non integer as indexes Issue 1529: Date and time classes should not rely on collections arithmetic with CollectionArithmetic now an extra package in squeaksource. http://www.squeaksource.com/CollectionArithmetic.html Tests unchanged, minus tests related to arithmetic which of course have been moved to the extra package.
So I'll resort to the alternative plan, which is to send the changeset to this list. On a core image update #11067 the Collection tests are all green. Running all tests show one error and two failures not related to the changed methods.
-- Cesar Rabak
<Slice-CesarRabak- Issue-1489.cs>_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Simon
Em 02/12/2009 01:41, Simon Denier < Simon.Denier@inria.fr > escreveu:
On 1 déc. 2009, at 21:07, csrabak@bol.com.br wrote:
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute. However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.
Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem.
Nice to know, Simon. Just to understand how I can troubleshoot this: did you empoly a core or dev image to do the Monticello stuff?
On 2 déc. 2009, at 09:56, csrabak@bol.com.br wrote:
Em 02/12/2009 01:41, Simon Denier < Simon.Denier@inria.fr > escreveu:
On 1 déc. 2009, at 21:07, csrabak@bol.com.br wrote:
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute. However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.
Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem.
Nice to know, Simon. Just to understand how I can troubleshoot this: did you empoly a core or dev image to do the Monticello stuff?
A core image. Perhaps you can try to repeat the steps, Monticello can take some times to do its stuff, from time to time. -- Simon
El mié, 02-12-2009 a las 10:56 -0200, csrabak@bol.com.br escribió:
Em 02/12/2009 01:41, Simon Denier < Simon.Denier@inria.fr > escreveu:
On 1 déc. 2009, at 21:07, csrabak@bol.com.br wrote:
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute. However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.
Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem.
Nice to know, Simon. Just to understand how I can troubleshoot this: did you empoly a core or dev image to do the Monticello stuff?
Always use a core image to prepare the SLICES. Cheers
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Miguel Cobá http://miguel.leugim.com.mx
Miguel, I've used the core image and just had it updated as the first bullet of instructions direct. I was just curious :-) Em 02/12/2009 16:42, Miguel Enrique Cobá Martinez < miguel.coba@gmail.com > escreveu: El mié, 02-12-2009 a las 10:56 -0200, csrabak@bol.com.br escribió:
Em 02/12/2009 01:41, Simon Denier < Simon.Denier@inria.fr > escreveu:
On 1 déc. 2009, at 21:07, csrabak@bol.com.br wrote:
I'm trying to follow the directions given at: http://code.google.com/p/pharo/wiki/HowToContribute. However, after the SLICE asks for the first comment, it freezes the image and the small window "Writing definitions" stays at 50% progress and nothing happens then.
Hi Cesar, I took your changeset and prepared a Slice, I did not have any problem.
Nice to know, Simon. Just to understand how I can troubleshoot this: did you empoly a core or dev image to do the Monticello stuff?
Always use a core image to prepare the SLICES. Cheers
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Miguel Cobá http://miguel.leugim.com.mx _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
participants (3)
-
csrabak＠bol.com.br -
Miguel Enrique Cobá Martinez -
Simon Denier