[Pharo-project] OldSocket removal
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes. -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
Thanks!!! Stef On Oct 21, 2008, at 9:14 AM, Damien Cassou wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu) _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
While playing with the OldSocket class>>clientServerTestUDP method I found out that a call to Socket>>discardReceivedData is blocking and this is not what happened with OldSocket>>discardReceivedData. An extra test for available data is missing. I could help with moving the methods from OldSocket class examples to a new SocketTest class. On Tue, Oct 21, 2008 at 10:14 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Tue, Oct 21, 2008 at 3:17 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
While playing with the OldSocket class>>clientServerTestUDP method I found out that a call to Socket>>discardReceivedData is blocking and this is not what happened with OldSocket>>discardReceivedData. An extra test for available data is missing.
I could help with moving the methods from OldSocket class examples to a new SocketTest class.
Pleqse -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
please! On Oct 21, 2008, at 3:17 PM, Dan Corneanu wrote:
While playing with the OldSocket class>>clientServerTestUDP method I found out that a call to Socket>>discardReceivedData is blocking and this is not what happened with OldSocket>>discardReceivedData. An extra test for available data is missing.
I could help with moving the methods from OldSocket class examples to a new SocketTest class.
On Tue, Oct 21, 2008 at 10:14 AM, Damien Cassou <damien.cassou@gmail.com
wrote: I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Among the methods in the examples category of OldSocket class, only clientServerTestUDP and clientServerTestUDP2 can be run without human intervention. So, only these two are candidates for unit tests, though I do not see what would be a valid assert for them. Would it be OK to move the other methods to Socket class and test(by hand) that all of them are still working ? On Tue, Oct 21, 2008 at 10:14 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Actually the tests there are rather primitive, why don't you pickup the tests from http://www.smalltalkconsulting.com/html/OTNotes4.html I also have some changes Rob Withers made if someone wants those files for integration On Oct 21, 2008, at 12:14 AM, Damien Cassou wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu) _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
On Tue, Oct 21, 2008 at 4:17 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
While playing with the OldSocket class>>clientServerTestUDP method I found out that a call to Socket>>discardReceivedData is blocking and this is not what happened with OldSocket>>discardReceivedData. An extra test for available data is missing.
I have a very small fix and test for the error mentioned above. Is it OK to upload new versions of Network and NetworkTests to PharoInbox ?
On Wed, Oct 22, 2008 at 6:43 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
On Tue, Oct 21, 2008 at 4:17 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
While playing with the OldSocket class>>clientServerTestUDP method I found out that a call to Socket>>discardReceivedData is blocking and this is not what happened with OldSocket>>discardReceivedData. An extra test for available data is missing.
I have a very small fix and test for the error mentioned above. Is it OK to upload new versions of Network and NetworkTests to PharoInbox ?
Yes, please. -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
yes please john. Stef On Oct 21, 2008, at 6:55 PM, John M McIntosh wrote:
Actually the tests there are rather primitive, why don't you pickup the tests from http://www.smalltalkconsulting.com/html/OTNotes4.html
I also have some changes Rob Withers made if someone wants those files for integration
On Oct 21, 2008, at 12:14 AM, Damien Cassou wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu) _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- = = = = = ====================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http:// www.smalltalkconsulting.com = = = = = ======================================================================
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to? On Oct 22, 2008, at 1:55 PM, Stéphane Ducasse wrote:
yes please john.
Stef
On Oct 21, 2008, at 6:55 PM, John M McIntosh wrote:
Actually the tests there are rather primitive, why don't you pickup the tests from http://www.smalltalkconsulting.com/html/OTNotes4.html
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
On Wed, Oct 22, 2008 at 11:24 PM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
You should commit them directly to PharoInbox on SqueakSource. As an alternative, you can upload it to http://code.google.com/p/pharo/issues/detail?id=275. Thank you -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
excellent! I like Michael R ":) On Oct 22, 2008, at 11:24 PM, John M McIntosh wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
On Oct 22, 2008, at 1:55 PM, Stéphane Ducasse wrote:
yes please john.
Stef
On Oct 21, 2008, at 6:55 PM, John M McIntosh wrote:
Actually the tests there are rather primitive, why don't you pickup the tests from http://www.smalltalkconsulting.com/html/OTNotes4.html
-- = = = = = ====================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http:// www.smalltalkconsulting.com = = = = = ======================================================================
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I have uploaded Network-DanCorneanu.50.mcz to pharoInbox. It fixes what I think it was a copy-paste error in Socket>>discardReceivedData.
On Tue, Oct 21, 2008 at 10:14 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
I've started working on OldSocket removal: http://code.google.com/p/pharo/issues/detail?id=275. I need someone to review my first changes.
Browsing the NameNetResolver I've seen that NameNetResolver class>>HaveNetwork is not read anywhere. Would it be OK to remove it?
On Thu, Oct 23, 2008 at 12:24 AM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
Yes you can also use PharoTaskForces for that. Now dan could you sign the license agreement and send it to me. Stef On Oct 25, 2008, at 9:36 PM, Dan Corneanu wrote:
On Thu, Oct 23, 2008 at 12:24 AM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I would really that other get a chances to review what you are doing. So I will harvest up to dc 49 and after wait that you get some other eyes to check what you are doing. Ok? Stef On Oct 25, 2008, at 9:36 PM, Dan Corneanu wrote:
On Thu, Oct 23, 2008 at 12:24 AM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
On Sat, Oct 25, 2008 at 10:45 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I would really that other get a chances to review what you are doing. So I will harvest up to dc 49 and after wait that you get some other eyes to check what you are doing. Ok?
Sure. Had I been directed sooner to PharoTaskForces, I would have not messed up the PharoInbox and OB repositories. Regarding the license agreement: I'll send a signed copy. Regarding the socket tests: Maybe it's better to wait for John to upload the code to a monticello repository. After all I have just filled the changesets in my image and fixed some constants.
On Oct 25, 2008, at 10:24 PM, Dan Corneanu wrote:
On Sat, Oct 25, 2008 at 10:45 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
I would really that other get a chances to review what you are doing. So I will harvest up to dc 49 and after wait that you get some other eyes to check what you are doing. Ok?
Sure. Had I been directed sooner to PharoTaskForces, I would have not messed up the PharoInbox and OB repositories.
You did not mess anything. Don't worry!
Regarding the license agreement: I'll send a signed copy.
Regarding the socket tests: Maybe it's better to wait for John to upload the code to a monticello repository.
After all I have just filled the changesets in my image and fixed some constants. No do not wait for other. if you have the code publish it in MC. This is good. I'm not saying that you are doing a bad job. I'm just bad in network so I would like have somebody else looking at what you did.
On Sat, Oct 25, 2008 at 9:24 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
I would have not messed up the PharoInbox and OB repositories.
Everything is fixed now, don't bother about that anymore :-). -- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
Hi John, On Wed, Oct 22, 2008 at 10:24 PM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
Could you please send what you've done? To me for example. -- Damien Cassou http://damiencassou.seasidehosting.st
Well I'm still struggling with it, I spent a few hours last weekend working issues. One is that many of the tests I had depend on open port 7 (echo port) on a linux server somewhere and reflecting data to test send/receive. That fails because usually an arbitrary server on the internet doesn't have port 7 open. Let me bundle it up then and forward you a change set. On Nov 11, 2008, at 11:04 AM, Damien Cassou wrote:
Hi John,
On Wed, Oct 22, 2008 at 10:24 PM, John M McIntosh <johnmci@smalltalkconsulting.com> wrote:
Ok, Michael R suggested I bundle these up, recheck them, so who would I send them to?
Could you please send what you've done? To me for example.
-- Damien Cassou http://damiencassou.seasidehosting.st
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
Hi Dan, On Sat, Oct 25, 2008 at 8:36 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
John released a new changeset: http://code.google.com/p/pharo/issues/detail?id=275. However, unit tests does not run due to missing NetNameResolver class>>initializeNetworkIfFail:. I think you removed that method. Could you please check the changeset, make the necessary changes, verify that all unit tests run and commit to PharoInbox? Also, please update the issue on google code according to what you do. Bye -- Damien Cassou http://damiencassou.seasidehosting.st
Actually this is still a work in progress, you'll find quite a few tests don't work yet because they require some modification. For example on machines 8 years back you could actually see socket state changes when you closed your side of the socket. Now you close it, and bang (usually) the socket gets unconnected, so a test fails that was looking at state changes. Also some of the tests required use of port ECHO to reflect data back to check for send/receive, that's very hard to do now because most linux systems consider poking at the echo port as a denial of service attack. On Nov 12, 2008, at 12:32 AM, Damien Cassou wrote:
Hi Dan,
On Sat, Oct 25, 2008 at 8:36 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
John released a new changeset: http://code.google.com/p/pharo/issues/detail?id=275. However, unit tests does not run due to missing NetNameResolver class>>initializeNetworkIfFail:. I think you removed that method. Could you please check the changeset, make the necessary changes, verify that all unit tests run and commit to PharoInbox?
Also, please update the issue on google code according to what you do.
Bye
-- Damien Cassou http://damiencassou.seasidehosting.st
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
I'll have a look. On Wed, Nov 12, 2008 at 10:32 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Dan,
On Sat, Oct 25, 2008 at 8:36 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
John released a new changeset: http://code.google.com/p/pharo/issues/detail?id=275. However, unit tests does not run due to missing NetNameResolver class>>initializeNetworkIfFail:. I think you removed that method. Could you please check the changeset, make the necessary changes, verify that all unit tests run and commit to PharoInbox?
Also, please update the issue on google code according to what you do.
Bye
-- Damien Cassou http://damiencassou.seasidehosting.st
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I think it was not me. I have removed nothing from Network-Kernel. We should use NetNameResolver class>>initializeNetwork. The method throws a NetworkError if it can not initialize the network. I think the method was never present in the pharo image. How can I trace back changes made to the NetNameResolver class, without selecting each monticello version of Network and browsing the code inside it? On Wed, Nov 12, 2008 at 10:32 AM, Damien Cassou <damien.cassou@gmail.com> wrote:
Hi Dan,
On Sat, Oct 25, 2008 at 8:36 PM, Dan Corneanu <dan.corneanu@gmail.com> wrote:
I've played with the change sets from http://www.smalltalkconsulting.com/html/OTNotes4.html. I've made some changes to the tests, to fit the current Socket and NetNameResolver implementations. If it is of any help, I can put up a mcz so others can have a look to the code.
John released a new changeset: http://code.google.com/p/pharo/issues/detail?id=275. However, unit tests does not run due to missing NetNameResolver class>>initializeNetworkIfFail:. I think you removed that method. Could you please check the changeset, make the necessary changes, verify that all unit tests run and commit to PharoInbox?
Also, please update the issue on google code according to what you do.
Bye
-- Damien Cassou http://damiencassou.seasidehosting.st
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
I should comment that the original method initializeNetworkIfError (whatever): was there because at the time (long ago) tcp/ip network support was an optional feature on macintosh and windows machines so there was fall back to support no network. That's unlikely today, and changing to just use the initializeNetwork is fine, where a thrown NetworkError would result in a valid sunit error. On Nov 13, 2008, at 7:26 AM, Dan Corneanu wrote:
I think it was not me. I have removed nothing from Network-Kernel. We should use NetNameResolver class>>initializeNetwork. The method throws a NetworkError if it can not initialize the network. I think the method was never present in the pharo image.
-- = = = ======================================================================== John M. McIntosh <johnmci@smalltalkconsulting.com> Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com = = = ========================================================================
participants (4)
-
Damien Cassou -
Dan Corneanu -
John M McIntosh -
Stéphane Ducasse