Hi, I finished case "11714 <https://pharo.fogbugz.com/default.asp?11714>NewVersionBrowser needs to be finished". The changes are integrated and the case is closed. What I did, I create a new SLICE with Benjamins latest changes cleaned from all merge conflicts. Add the missing pieces for diff display with DiffMorph Finished the menu There is currently one issue with the version list sorting, I 'll make a new bug entry for this, soon. If you encounter any issues, please don't reopen this case but create a new one. I omit the Tools registry changes until I have done some more testings and there are no issues left. I have remaining question: With the side-by-side diff where to put the selected version and where the prior version? Currently (Old-)VersionBrowser shows the selected version on the right and the prior version on the left. This looks a bit strange. I would like to chang this.
On 20 Jan 2014, at 20:18, Nicolai Hess <nicolaihess@web.de> wrote:
Hi,
I finished case "11714 NewVersionBrowser needs to be finished". The changes are integrated and the case is closed.
Cool :)
I have remaining question: With the side-by-side diff where to put the selected version and where the prior version? Currently (Old-)VersionBrowser shows the selected version on the right and the prior version on the left.
That is how it is in âallâ the diff in Pharo :) old on the left, new on the right.
This looks a bit strange.
Why? Ben
On 21 Jan 2014, at 00:19, Nicolai Hess <nicolaihess@web.de> wrote:
Hi,
I finished case "11714 NewVersionBrowser needs to be finished". The changes are integrated and the case is closed.
Very nice!
I omit the Tools registry changes until I have done some more testings and there are no issues left.
I have remaining question: With the side-by-side diff where to put the selected version and where the prior version? Currently (Old-)VersionBrowser shows the selected version on the right and the prior version on the left. This looks a bit strange.
I would make sure it works the same as the Monticello diff⦠and left original, right change seems to be what it does? Marcus
2014/1/21 Marcus Denker <marcus.denker@inria.fr>
On 21 Jan 2014, at 00:19, Nicolai Hess <nicolaihess@web.de> wrote:
Hi,
I finished case "11714 <https://pharo.fogbugz.com/default.asp?11714>NewVersionBrowser needs to be finished". The changes are integrated and the case is closed.
Very nice!
I omit the Tools registry changes until I have done some more testings and there are no issues left.
I have remaining question: With the side-by-side diff where to put the selected version and where the prior version? Currently (Old-)VersionBrowser shows the selected version on the right and the prior version on the left. This looks a bit strange.
I would make sure it works the same as the Monticello diff⦠and left original, right change seems to be what it does?
Marcus
Ok, I take the current version: Left -> Right old Version -> new Version / the changes
participants (3)
-
Benjamin -
Marcus Denker -
Nicolai Hess