[Pharo-project] Issue 3583 in pharo: Shout should only be active in code panes
Status: Accepted Owner: tudor.gi...@gmail.com Labels: Type-Patch Milestone-1.2 Importance-High New issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 In the latest Morphic version, the default styler of the PluggableTextMorph is given by: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do" Smalltalk globals at: #SHTextStylerST80 ifPresent: [ :stylerClass | self styler: (stylerClass new view: self) ] ifAbsent: [ self styler: ( NullTextStyler new view: self) ] Thus, if Shout is loaded, you will get it in all text morphs by default. Given that TextMorph should be general and be used in all sorts of contexts, the default behavior should be the original: useDefaultStyler "This should be changed to a proper registry but as long as there is only shout this will do" self styler: (NullTextStyler new view: self; yourself).
Updates: Cc: guillermopolito marcus.denker stephane.ducasse Comment #1 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 From Guillermo: Why not delegate it in the used Editor ? SmalltalkEditor should use shout while the other editors should use the NullTextStyler. Maybe something like this: PluggableTextMorph>>useDefaultStyler self styler: textMorph editor styler Or better: PluggableTextMorph>>useDefaultStyler self styler: textMorph styler And then Editor>>styler ^NullTextStyler new SmalltalkEditor>>styler ^... ... Anyways, I'm looking that PluggableTextMorph>>textMorphClass "Answer the class used to create the receiver's textMorph" ^TextMorphForEditView and TextMorphForEditView>>editorClass ^ SmalltalkEditor So it's what I suggested needs a lot of work more... Guille
Comment #2 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Guillermo, could you propose a change set or a slice so that we can work on?
Comment #3 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 And what about a PluggableTextMorph used to display code ? Maybe PluggableTextMoprh should have as a parameter during their creation a keyword to say if they want to be text styled or not like: PluggableTextMoprh new beStyled And by default a PluggableTextMorph isn't styled
Comment #4 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 You can set it simply by #styler:. But, the question is where should this decision be taken.
Comment #5 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 With this change set, by default a PluggableTextMorph doesn't style, but with beStyled, you make it style again. It only works with the latest version of shout where PluggableShoutMorph is deprecated. Then we will have to fix tools which needs styling Attachments: FixPluggableTextMorph.1.cs 4.5 KB
Updates: Labels: Milestone-1.3 Comment #6 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 (No comment was entered for this change.)
Updates: Status: Started Comment #7 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 12322 TODO: 1.3
Comment #8 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 1319
Comment #9 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 So what is the next step?
Comment #10 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 the next step should be to change class which actually need shout, and to specify their UI to styled the text. I'll take a look as soon as I have enough time :)
Comment #11 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Question1: does this touch Core code or Package in Full? Question: Is this a show-stopper for a 1.2 release? Meaning: Could we live wiithout it until a 1.2.1?
Comment #12 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Shout is not a part of the Core, so I think we can live without text shouting ^^ For dev image, it could be cool to have it because code colorization is really helpful. But I think it's not long to fix, but I have to work on Hazel this week :) I will try to take a look this week end
Updates: Labels: -Type-Patch -Milestone-1.2 -Milestone-1.3 Milestone-1.2-DevImage Comment #13 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 So I move this to 1.2Dev
Comment #14 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Here comes a new changeset which finally add shouting in the browser ^^ I've done it like I like to have shouting, but it can be changed easily ^^ Attachments: AddShoutingInTools.1.cs 11.9 KB
Comment #15 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Ben should we load the two changeset in 1.3?
Comment #16 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Yes I think, even if the shouting doesn't really matter in a core image, but it's another step forward ^^
Comment #17 on issue 3583 by marcus.d...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 And what about 1.2?
Comment #18 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 not a showstopper so for 1.3. Stef
Comment #19 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Shout looks to work in the OB code browser, but it does not work in the Debugger.
Comment #20 on issue 3583 by hisnamei...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 There is no shouting, or the shouting is badly done ?
Comment #21 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 In the Pharo 1.2 12324, there is no shouting either in the Debugger or in the Workspace.
Comment #22 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 It should fix the debugger (and all the codeholders) Let's take a look at the workspace now Attachments: ShoutCodeHolder.1.cs 652 bytes
Comment #23 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 That should shout the workspace :) Give me feedback please ;) Attachments: ShoutWorkspace.1.cs 547 bytes
Comment #24 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Thanks a lot. I tested it briefly and it looks good. It would be great to integrate this in 1.2.
Comment #25 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 This is an important fix. Benjamin, could you create a slice?
Comment #26 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I do know how to create a slice :$
Comment #27 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 i do NOT know (I'm tired ^^)
Updates: Cc: -guillermopolito -marcus.denker -stephane.ducasse Benjamin.VanRyseghem Comment #28 on issue 3583 by laurent....@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 See http://www.pharocasts.com/2010/03/how-to-contribute-to-pharo.html In Monticello Browser (1.2) , click +Slice. Enter the issue number, copy/paste the issue title and select the packages to include, OK. Then select the slice in MB and save it to PharoInbox
Comment #29 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Thanks Laurent :) Slice done: SLICE-Issue-3583-Shout-should-only-be-active-in-code-panes-BenjaminVanRyseghem.1 in PharoInbox. I hope it will work ;)
Comment #30 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 ben your slice is empty. Could you republish it. Or should I take the cs?
Comment #31 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I tried to load the cses but they broke on me... unstyled or beStyled not found.
Comment #32 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I have posted a new slide with the same name instead of two '-' at the beginning: SLICE-Issue-3583--Shout-should-only... I've tested, it seams to work (I cross fingers). If you want to use the cs, if you load the 4 cs in the good order, it should work (it's what I've fone to create the slice)
Updates: Status: Fixed Comment #33 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I suggest that we stop changing code in the rc 1.2 else we will not succeed to release it. So I will start to integrate this in 1.3 to see.
Comment #34 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I understand the principle of releasing, but this small thing has a high impact. I suggest to still include this one in 1.2
Comment #35 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Ok but we should really stop. In 13051
Comment #36 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 in 12334
Comment #37 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 When I load this slice into 1.2, workspace does not open anymore!!! So doru if you want this fix in 1.2, help because I cannot spend time on it now. The slice of ben worked well in 1.3 but probably 1.2 and 1.3 are diverging.
Comment #38 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I'm trying a last time for today now.
Comment #39 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Since I have to cherrypick the changes and I do not know them... I will not do it using the slice. I will try with the cs but it fails then somebody should provide us a slice loading only the changes in 1.2.
Comment #40 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 When I try to load the cs in order I get an error.... if I drop the file and ask the code browser. So I drop the file and loaded as new cs, so this means that we will have yet another bug in two versions.... So I sugges that we stop. systemCategoryListIndex: anInteger "Set the selected system category index to be anInteger. Update all other selections to be deselected." self textMorph beStyled. does not understand beStyled. I integrated the change in 12334 and now if there is a bug. You should provide a fix and before try a lot of behavior. This bug will not be a showstopper I imagine.
Updates: Status: Closed Comment #41 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 (No comment was entered for this change.)
Comment #42 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Arghhhhhh I could not release because workspace protocol changed between 1.2 and 1.3 So sorry guy but may be we will stay like that for now edit: aText label: labelString accept: anAction "Open an editor on the given string/text" ^(Workspace openLabel: labelString) acceptContents: aText; acceptAction: anAction; yourself.
Comment #43 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Hi Stef, I just loaded the following slice in PharoDev based on 12331 and everything works just fine. SLICE-Issue-3583--Shout-should-only-be-active-in-code-panes-BenjaminVanRyseghem.1
Comment #44 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I'll check that tomorrow ^^
Mmm, maybe it's not possible, but this issue is here because the merge between PluggableTextMorph and PluggableTextMorphWithShout was not completely done. How difficult it is to go back to that refactor again and have this in mind? Because this looks like a lot of patches and patches and patches... Guille On Thu, Feb 10, 2011 at 5:28 PM, <pharo@googlecode.com> wrote:
Comment #44 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes
http://code.google.com/p/pharo/issues/detail?id=3583
I'll check that tomorrow ^^
Comment #45 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Doru I did that in 12333 and it did not. Workspace did not work and too many changes that should not get in. Did you really had a look at the changes? We cannot change the system like that in 1.2rc1
Comment #46 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Here is what I see when I'm doing a merge and it cannot be. I cannot (and if I could I would not) integrate such a slice. Now if you succeed to produce a cs that I can load in 1.2 then ok but not this slice. This is why I tried to load the cs one by one but it barked. but at the end Workspace was broken. Attachments: Screen shot 2011-02-10 at 10.51.13 PM.pdf 49.0 KB
Comment #47 on issue 3583 by guillerm...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Mmm, maybe it's not possible, but this issue is here because the merge between PluggableTextMorph and PluggableTextMorphWithShout was not completely done or thought. How difficult it is to go back to that refactor again and have this in mind? Because this looks like a lot of patches and patches and patches...
Comment #48 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I do not understand ... I just took the last 1.2 image from Hudson: https://pharo-ic.lille.inria.fr/hudson/view/Pharo/job/Pharo%201.2/132/ and load the slice, it works fine. I've tried with the 4 cs, it works fine too ... Strange
Comment #49 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Loading a slice does not mean that you only load what is needed. Here you load all the difference that have been changed between 12 and 13. So have a look at it doing merge. For the CS can you open a workspace after. I cannot.
Comment #50 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I've tried to do a merge, there is only one conflict, I choose to keep the current version, and it works fine ... And the workspace two in both case ...
Comment #51 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 'too', not 'two' oO
Comment #52 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Thanks Benjamin for looking into this.
Updates: Status: Fixed Comment #53 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Apparently in 1.3 there are places where texMorph is nil and it DNU when sent beStyled.... Fix attached now we shoudl defined two method in the Browser class instead of having this self textMorph ifNotNilDo: [:it | it beStyled] Attachments: beStyled.2.cs 7.8 KB
Comment #54 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Apparently in 1.3 there are places where texMorph is nil and it DNU when sent beStyled.... Fix attached now we shoudl defined two method in the Browser class instead of having this self textMorph ifNotNilDo: [:it | it beStyled] Attachments: beStyled.2.cs 7.8 KB
Comment #55 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Ok, I think I see where the confusion came from. If you load the slice of Benjamin in the Pharo 1.2, everything works fine. If you load it in **Pharo-Core** then it does not work. So, I tracked a bit the errors in Pharo-Core. The reason the Workspace does not work is that apparently after the loading of the slice, somehow Workspace class does not understand open anymore. If I add this method, everything works fine. The code browser works fine, but when trying to browse a class, we get an error because a textMorph is not initialized. I do not know why this happens. Can anyone take a look and confirm?
Comment #56 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I've done a slice for 1.2 image (String Holder is now my friend ^^) in PharoInbox And a little fix for 1.3 in order to consider SH preferences about styling Attachments: FixPluggableTextMorph2.1.cs 264 bytes
Comment #57 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Ok we redid everything with Benjamin in 1.2 in 12335. Can you check that this is ok?
Updates: Status: Closed Comment #58 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 We retroffit the 1.2 refactoring in StringHolder. Now 1.2 and 1.3 are in sync. In 13055
Comment #59 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I checked the latest 1.2 build based on 12335. The Debugger works great, but the Workspace still does not offer highlighting.
Comment #60 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 this is strange because we tested the workspace. but it should not be difficult to fix.
Comment #61 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 yes it's normal, for two reasons: - a method that should be removed is still here :s - SHWorkspace overrides a lot of methods and break the styling (ironic no ^^) I've wrote a cs for the first point, and committed a new version of SHWorkspace emptied for the second. I've also create a minimal cs that makes SHWorkspace work, but it's really a patch. So with the last version of SHWorkspace, it should work now ^^ (maybe we should move SHWorkspace in Deprecated ?) Attachments: FixWorkspaceAgain.1.cs 155 bytes FixSHWorkspace.1.cs 160 bytes
Comment #62 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Thanks a lot. Now we should really update ConfigurationOfShout so that this version is for 1.2 and stay like that and we can move on in 1.3. Doru can you have a look at the configuration?
Updates: Status: Fixed Comment #63 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 (No comment was entered for this change.)
Comment #64 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 As I understand, FixWorkspaceAgain.1.cs should be integrated in Pharo, and the latest version of SHWorkspace should work in both 1.2 and 1.3. I tested it, but there still is a problem - I type: a := 1. - a appears red because it's not defined yet. - I do it. - Whatever I do afterwards, a still appears like undefined.
Comment #65 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 In fact, without the FixWorkspaceAgain cs, shout (should) works in: - 1.2 core + Shout - 1.3 core + Shout But not in 1.2 Dev due to SHWorkspace. So now it should work in: - 1.2 core + Shout - 12. Dev - 1.3 Core - Probably 1.3 Dev too For your problem, it happens in which image ? 1.2 core, 1.2 dev or 1.3 core ? I will check that, and try to fix it because it's time to finally close this entry ^^
Comment #66 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Thanks for the clarifications. The problem I described happens in Pharo 1.2 (dev)
Comment #67 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I was wrong in the name of the cs. What I said was about FixSHWorkspace. FixWorkspaceAgain make shout works in 1.2 core + shout (a method was not removed as it should have been) I take a look at your problem
Comment #68 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I trie din a 12335 with the two last cs (FixWorkspaceAgain and FixSHWorkspace) I type a := 1 here 'a' appears in red, as expected. Then above this line I add | a | this line is in grey, and a turn in grey too in the expression, as expected too :s So either it works or I haven't understood what you've done ... (see attachments for screenshots) Attachments: Screen shot 2011-02-15 at 11.28.37 AM.png 14.2 KB Screen shot 2011-02-15 at 11.28.58 AM.png 14.4 KB
Comment #69 on issue 3583 by tudor.gi...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 In the workspace variables are bound implicitly, and this should be taken into account during highlighting. So, after evaluating a:=1, a will be bound and it should appear as such without declaring it.
Comment #70 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I think it comes from the workspace, I'll take a look at the fix proposed to fix the declaration of new variables ... Moreover, by default, the item "Automatically create temporary variables" is unselected (the square is blank), but variables created, and if you select it (the square is grayed), variables aren't created anymore ...
Comment #71 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Here two cs that fix this problem. It's different in 1.2 and 1.3 because now Workspace superclass is Object :) Here it works, so I cross fingers ^^ Attachments: FixWorkspace1.2.1.cs 567 bytes FixWorkspace1.3.1.cs 2.2 KB
Comment #72 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Some cs about refactorisation, and reactivating the style/unstyle item in the menu: For 1.2 and 1.3: - PrepareFixWorkspaceMenu.2 - FixWorkspaceMenu.1 For 1.2 Dev (to fix SHWorkspace): - FixSHWorkspaceToFixMenu.1 Attachments: PrepareFixWorkspaceMenu.2.cs 1.0 KB FixWorkspaceMenu.1.cs 10.0 KB FixSHWorkspaceToFixMenu.1.cs 349 bytes
Comment #73 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 A little sum up :) From a 1.2 Dev image 12335: - FixWorkspaceAgain.1 - FixSHWorkspace.1 - FixWorkspace1.2.1 - PrepareFixWorkspaceMenu.2 - FixWorkspaceMenu.1 - FixSHWorkspaceToFixMenu.1 From a 1.3 Core image 13055: - FixWorkspaceAgain.1 - FixWorkspace1.3.1 - PrepareFixWorkspaceMenu.2 - FixWorkspaceMenu.1
Comment #74 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 OK doru do you integrate it in Shout?
Comment #75 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 What I've done about SHWorkspace is just a little patch. In fact this whole class can be emptied. If you want, I can take a look at the shout package, and remove useless things :) But a better solution could be to change the list of tools pushed in a core image to create a Dev one and to remove all the SH tools (for 1.3)
Comment #76 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 yes we should finish 1.2 so minimizing the changes there
Comment #77 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Benjamin in 1.2 I cannot get it work :( I check manually with textmate the changes and - FixWorkspaceAgain.1 - FixWorkspace1.2.1 here it is working after when I install PrepareFix (it was blocking) and wehn i restarted everything it was working- so this is 'working' now when I load FIxWorkspaceMenu when I press space I get a DNU every where in any pane. styleInBackgroundProcess: aText .... oldRuns withStartStopAndValueDo:[:start :stop :attribs| (attribs detect: [:each | each shoutShouldPreserve] ifNone:[nil]) == nil So I'm lost again
Comment #78 on issue 3583 by Benjamin...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 Yes, my bad, I forgot to remove a line after a copy/paste ... Now it works in a 1.2 core, and it works well when I load shout ^^ Attachments: FixWorkspaceMenu.2.cs 9.8 KB
Comment #79 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 I integrate - FixWorkspaceAgain.1 - FixWorkspace1.2.1 - PrepareFixWorkspaceMenu.2 - FixWorkspaceMenu.2.cs in 1.2 Now FixSHWorkspace.1 FixSHWorkspaceToFixMenu.1 should be integrated in shout?
Comment #80 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 - FixWorkspace1.3.1 - PrepareFixWorkspaceMenu.2 - FixWorkspaceMenu.2 in 1.3
Updates: Status: Closed Comment #81 on issue 3583 by stephane...@gmail.com: Shout should only be active in code panes http://code.google.com/p/pharo/issues/detail?id=3583 1h30 spent on that.
participants (2)
-
Guillermo Polito -
pharo＠googlecode.com