30444 ----- 11762 update #cleanUpForProduction https://pharo.fogbugz.com/f/cases/11762 11764 unload Refactoring-Spelling https://pharo.fogbugz.com/f/cases/11764 11763 clean up Refactoring-Critics-Unused https://pharo.fogbugz.com/f/cases/11763 11761 class StrikeFontFixer is undocumented and the only users not called https://pharo.fogbugz.com/f/cases/11761 Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1288.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Graphics-Fonts-MarcusDenker.85...
marcus for the critics next time please keep them else we will not be able to decide if we used them or not. This is not three little classes that will change something. Especially when they are part of a large library. Stef
30444 -----
11762 update #cleanUpForProduction https://pharo.fogbugz.com/f/cases/11762
11764 unload Refactoring-Spelling https://pharo.fogbugz.com/f/cases/11764
11763 clean up Refactoring-Critics-Unused https://pharo.fogbugz.com/f/cases/11763
11761 class StrikeFontFixer is undocumented and the only users not called https://pharo.fogbugz.com/f/cases/11761
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1288.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Graphics-Fonts-MarcusDenker.85...
On Oct 3, 2013, at 9:19 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
marcus for the critics next time please keep them else we will not be able to decide if we used them or not. This is not three little classes that will change something. Especially when they are part of a large library.
But we don't use them.
Stef
30444 -----
11762 update #cleanUpForProduction https://pharo.fogbugz.com/f/cases/11762
11764 unload Refactoring-Spelling https://pharo.fogbugz.com/f/cases/11764
11763 clean up Refactoring-Critics-Unused https://pharo.fogbugz.com/f/cases/11763
11761 class StrikeFontFixer is undocumented and the only users not called https://pharo.fogbugz.com/f/cases/11761
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1288.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Graphics-Fonts-MarcusDenker.85...
On Oct 3, 2013, at 9:22 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 3, 2013, at 9:19 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
marcus for the critics next time please keep them else we will not be able to decide if we used them or not. This is not three little classes that will change something. Especially when they are part of a large library.
But we don't use them.
Yes but let us the time to think. First we should run the critics on everything then fix the problem. We should reorganize many things. Removing three classes that are well identified is not nice because now if I want to know which rules were not good I will have to load I do not know which version. Stef
Stef
30444 -----
11762 update #cleanUpForProduction https://pharo.fogbugz.com/f/cases/11762
11764 unload Refactoring-Spelling https://pharo.fogbugz.com/f/cases/11764
11763 clean up Refactoring-Critics-Unused https://pharo.fogbugz.com/f/cases/11763
11761 class StrikeFontFixer is undocumented and the only users not called https://pharo.fogbugz.com/f/cases/11761
Diff information: http://smalltalkhub.com/mc/Pharo/Pharo30/main/Tools-MarcusDenker.1288.diff http://smalltalkhub.com/mc/Pharo/Pharo30/main/Refactoring-Critics-MarcusDenk... http://smalltalkhub.com/mc/Pharo/Pharo30/main/Graphics-Fonts-MarcusDenker.85...
On Oct 5, 2013, at 9:23 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Oct 3, 2013, at 9:22 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 3, 2013, at 9:19 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
marcus for the critics next time please keep them else we will not be able to decide if we used them or not. This is not three little classes that will change something. Especially when they are part of a large library.
But we don't use them.
Yes but let us the time to think. First we should run the critics on everything then fix the problem.
-> the critic explicitly did not run them (there are more of that kind that i did not remove) -> I checked them and they where checking for special pragma tagged methods. Some pragmas that where used in some project but I have never seen them used *ever*.
We should reorganize many things. Removing three classes that are well identified is not nice because now if I want to know which rules were not good I will have to load I do not know which version.
The rules where really useless, they where testing a convention we don't use *and* they where already omitted by the critic browser. Here are the rationals of the three: rationale ^ 'Checks that methods marked with <modifier: #final> is never overridden.' rationale ^ 'Checks that a method marked with <modifier: #override> overrides an actual superclass method.' rationale ^ 'Checks that methods marked with <modifier: #super> are always called when overridden.' Marcus
On Oct 5, 2013, at 9:36 AM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 5, 2013, at 9:23 AM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
On Oct 3, 2013, at 9:22 PM, Marcus Denker <marcus.denker@inria.fr> wrote:
On Oct 3, 2013, at 9:19 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:
marcus for the critics next time please keep them else we will not be able to decide if we used them or not. This is not three little classes that will change something. Especially when they are part of a large library.
But we don't use them.
Yes but let us the time to think. First we should run the critics on everything then fix the problem.
-> the critic explicitly did not run them (there are more of that kind that i did not remove) -> I checked them and they where checking for special pragma tagged methods. Some pragmas that where used in some project but I have never seen them used *ever*.
We should reorganize many things. Removing three classes that are well identified is not nice because now if I want to know which rules were not good I will have to load I do not know which version.
The rules where really useless, they where testing a convention we don't use *and* they where already omitted by the critic browser. Here are the rationals of the three:
rationale ^ 'Checks that methods marked with <modifier: #final> is never overridden.' rationale ^ 'Checks that a method marked with <modifier: #override> overrides an actual superclass method.' rationale ^ 'Checks that methods marked with <modifier: #super> are always called when overridden.'
yes that ones :)
Marcus
participants (2)
-
Marcus Denker -
Stéphane Ducasse